From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 3AD513858C62 for ; Tue, 21 May 2024 12:18:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3AD513858C62 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3AD513858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::530 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716293942; cv=none; b=HBcbXWmW/gKzJ4RXtLJJz/9XJPkw2FxTtsaGeBiQCorGpnvNZqeoJ0yVE6h/VZnZcSloZsaXzUDEuKTnKp7/ZciEMNQYh5/0BhK6xPrH/U7XMd68VkoE4FDjGX/IGCQb53TmWrSnFmYM2sZNIQdO3e9jK06iFxiEFVjeQZJh8wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716293942; c=relaxed/simple; bh=vBFeOKzS9jDiiwoDmGpS9fgIImuuLlacchRdzULwnSU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EUP4YtIJAAedLgRHVJguVeuue2uLuYZF85drsTFMT/ejhRIGfgMIJ61TbKHBS7ueGsbBoJeg+OCDV1FCosS8Fl+MhBJX5k2rwwSA1kuwNi1Bf5EoMKEeXR2KNtm/rEgpKHKNPo8Iu71c/8nJ2qHyne5PyD5gZVFoQXoFLGMTXEo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-56e37503115so6096720a12.1 for ; Tue, 21 May 2024 05:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716293938; x=1716898738; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7SdDkorcrPIgTxA5Q82Le1WnVoVspoNr1Iu1g04eico=; b=eRgviWKjui1rVJaNOVVjsdH1wQzox5MyvhswHMjW1Pvs2UY8NINh5i8/lTqB7F2uZ1 ZUSvZKSq362sulLeoWxUQQWWr5/Y6InOf/iqImcYQ1zX3jcaSdWWFAFjD8pkruesT0QA THGD3I41FeuAYRXMTdCgA7h2adsPnMditTzSwfh1o1GyMhWErOCXfSIMfe7iEzpSMrAA LYv9Bd/66M3WV2KLyvaA9GGkoP+34/f7cx2lP2e91q0ya13COyohYgKZAoUOPo64PXfj 55ITUVPTIz9LdIatjZCuqV/osJx3KqTF91ZIy37bmhSnpCSbgCP7LT/l0lFXFZJr3eIH 7xlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716293938; x=1716898738; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7SdDkorcrPIgTxA5Q82Le1WnVoVspoNr1Iu1g04eico=; b=DeFSf2x1eOmve1hd2vDfVA1GVJg6UoQM/InIiq65uNCDenCM6NWEuG+8jY9qM/dx2G WvsNAm2+LyUji6N4EGOx4okTvl2OJkkrZQ0Jzy0NFzQuSSHECt3dgFYi3LK4kkEMf3il r0JKNPHeRSKJ9mCuetSURQt705boGAPuVmijha4hUylAT9EfFQ2xVUve8S1NSTBhFH6K SDFgBzKpIG+MDc5fujYEX76L6dGiLbogrH7StRuEaeX/WGX5Fees6OQZN5XlE5fW2YOL SralOQ/Hz+kA/lcYIcBbt2ezm+2M68X5LWWaLltCtOZukx5wItLxhvfOaCJDNeQryJd2 nNbg== X-Forwarded-Encrypted: i=1; AJvYcCVJdu6ierAGagJawn9k4b3Y07apa6y5SgvuJbvhyrmrbRP0qgyEIYrtwudaQZYyimtoebFLfcgFWZ9EzlMRADeGe7ZSAwthjA== X-Gm-Message-State: AOJu0YzUU/xZke5UeCnNT4S8tIFhQ6J7pxgSppHEnWA3dk5y52nmykgs oj4UYGZKoZJXZVZE/eoiZRp/fJ+6X9cKaIYiYNwIY/sp5wc+XsHwVKDHxh7ZwQ== X-Google-Smtp-Source: AGHT+IEXiiI2a7Pwa1ErTCHz1EYtdnDUyERZVz60VpL2wjxEVY3RzE7G9A56Tk+sBivEyrq+nlpLrg== X-Received: by 2002:a17:906:8315:b0:a5a:d6c:a30b with SMTP id a640c23a62f3a-a5a2d65f265mr2180091966b.58.1716293937810; Tue, 21 May 2024 05:18:57 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a17b0150csm1607027066b.154.2024.05.21.05.18.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 May 2024 05:18:57 -0700 (PDT) Message-ID: <241011a5-1240-4a56-8749-ccc3a9d97a65@suse.com> Date: Tue, 21 May 2024 14:18:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] x86: Split REX/REX2 old registers judgment. Content-Language: en-US To: "Cui, Lili" Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20240520062202.1297234-1-lili.cui@intel.com> <20240520062202.1297234-2-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240520062202.1297234-2-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.05.2024 08:22, Cui, Lili wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -4303,22 +4303,20 @@ static void establish_rex (void) > /* Respect a user-specified REX prefix. */ > i.rex |= i.prefix[REX_PREFIX] & REX_OPCODE; > > - /* For 8 bit registers we need an empty rex prefix. Also if the > - instruction already has a prefix, we need to convert old > - registers to new ones. */ > - > - if ((i.types[first].bitfield.class == Reg && i.types[first].bitfield.byte > - && ((i.op[first].regs->reg_flags & RegRex64) != 0 || i.rex != 0 > - || i.rex2 != 0)) > - || (i.types[last].bitfield.class == Reg && i.types[last].bitfield.byte > - && ((i.op[last].regs->reg_flags & RegRex64) != 0 || i.rex != 0 > - || i.rex2 != 0))) > - { > - unsigned int x; > - > - if (!is_apx_rex2_encoding () && !is_any_vex_encoding(&i.tm)) > - i.rex |= REX_OPCODE; > - for (x = first; x <= last; x++) > + /* For 8 bit registers without a prefix, we need an empty rex prefix. */ As you're touching this comment, can you please also correct it? It's not all 8-bit registers which are affected here (as expressed by the RegRex64 checks). > + if (((i.types[first].bitfield.class == Reg && i.types[first].bitfield.byte > + && ((i.op[first].regs->reg_flags & RegRex64) != 0 )) Nit: Please parenthesize this line and ... > + || (i.types[last].bitfield.class == Reg && i.types[last].bitfield.byte > + && (i.op[last].regs->reg_flags & RegRex64) != 0 )) ... this one the same way, preferably like the latter. Also please omit the blanks before the closing parentheses. > + && !is_apx_rex2_encoding () && !is_any_vex_encoding (&i.tm) && !i.rex) Is the !i.rex part needed? It wasn't there before. If it's needed, it would imo better come ahead of the APX/VEX checks. > + i.rex |= REX_OPCODE; > + > + /* For REX/REX2 prefix instructions, we need to convert old registers > + (AL, CL, DL and BL) to new ones (AXL, CXL, DXL and BXL) and report bad > + for AH, CH, DH and BH. */ "report bad for" is a little odd; how about simply "reject"? Okay with respective adjustments. Jan > + if (i.rex || i.rex2) > + { > + for (unsigned int x = first; x <= last; x++) > { > /* Look for 8 bit operand that uses old registers. */ > if (i.types[x].bitfield.class == Reg && i.types[x].bitfield.byte