From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2059.outbound.protection.outlook.com [40.107.105.59]) by sourceware.org (Postfix) with ESMTPS id 1C7A23858C2F for ; Tue, 6 Sep 2022 07:40:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C7A23858C2F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5v5ZccBd44S9+frLNDjUCcm3An4nvQfmKeyHBtmyKXOBArK3Rc0aY+pAw/KNsHSSo/oVXEWyXdCRiFbIHY6EDKrggJCcRn4QwnWfrd8pIaXoxiNEAvOgD2Geptd7BdxEOECxAWDOU5nbOqNFrYieAlP7vNRirPGMB0/ZD4GzAU8Qsjr6Eg6us+nuntD8NO5FVvMoC9Zc0z7uQIlB1tMzGOrUolCnd4g0+yzXBUNUnACuoEo5MN9K8ZsocYiZZg5L1AgAnmYfHq/SJgcWx2LtAicTrVTkA7teE3DI13Ql59vGPEkkcgXclkPKBlMfXYJo5JoaqoaSti85dSncICeOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n+y4kFnGn22qQR2xj8X2Ll3/DxwdkZ19DO2cwSaPeWc=; b=fNYNLfax1tqDcGE5Dc9bJyYfh4K2pbq0ZVtz/isW3612+OQcO9kQ10yITn9MKniraAKX28NImMXuGhqtjfHeeLupWKbgnMlZhsu2Bkfpc4bhmA1Cr44JxMTpH0qxCK0JwEwrezF/D6m8HqVx5MggbUrZM881VMXEN6jnzsnhh6/9aKvl54uxPjKtlg3nfZtjYBYgVR6TQU3jsdvGZsvpCm3oeBHcpU6v9c8+wo2wRunmcrh9Ou/6J8D3vooQ9QIjxSL8ShfSD+Bv5SrclYPvZRGX//S/X2WrCgRDTrD6igYumszqWfvLzbD7bdCDfmj7G0fH9vo4wuwHSwaKUqenRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n+y4kFnGn22qQR2xj8X2Ll3/DxwdkZ19DO2cwSaPeWc=; b=kVnBIFjqA6BMsR+oa1fUOczAlupSOCXgKWrcChausLnXMAOHEMO2I9+yRLkp7SZzowesQkxwxR2WW8FlG/xycJ8ed5vV0S2AAPYx74rZGO/CC51JyLC5bbsJr3qV0qmyQPQ1CzoRpLS9MH0EwC6GN28WXcCc/cCLqVztb0g1T/7C5HZQ8xtVWGAb+WIkWuZ3Gh4p43UqAWLaAqhM+0nHia3p2+RKJYj/UXJBtauzZ5vLAfbCDK9JMeiIo0Ms1ezE6+TgEZFCYyWa0SuqfFZLKeXQ8kyOKUGkTEPEJxECFRkA3A8Ym+KvE7qRXtqfl57cZ+YshlUmIIV7oWTNLr77AA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6085.eurprd04.prod.outlook.com (2603:10a6:20b:b9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 07:40:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5588.017; Tue, 6 Sep 2022 07:40:31 +0000 Message-ID: <242a402a-57be-0738-d7b8-c19e1a631bb7@suse.com> Date: Tue, 6 Sep 2022 09:40:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] ld: pe: Improve performance of object file exclude symbol directives Content-Language: en-US To: Nick Clifton , =?UTF-8?Q?Martin_Storsj=c3=b6?= References: <20220902105903.2249507-1-martin@martin.st> <174963e9-fa71-b70e-7659-0f534db073f8@redhat.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <174963e9-fa71-b70e-7659-0f534db073f8@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb83f6ce-6583-4a06-a570-08da8fdb134a X-MS-TrafficTypeDiagnostic: AM6PR04MB6085:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: STctI/RjUcBoHEUn81FQg2eiNolKm8GZevDT+hrDGZQAilOcLPsphvOJn68kW8agjCQSQnryI7fKkoIOD8vIu2CjaNxpDjPUQ4qepMiHw8UOzXOwhKf6LGJmNY1oMkYFkQc41UYMT7hwX4Ox+F7F4N8oJE+x0NSuY81lZHIKyhCWX4JeNm4pJI7tZfCTGEv4OdS8+DA9iegj7VtA1EHQ1sRXfw41t9p2PsgDfO/jMSaJSbjZCqrIA/o9dSTDrHmxxQMPhiNKygykkArX3IQCz98VKTseVDuD2ho6655PTIA7qlP3Zbg7NpwUloWeVfwAUjROgcr67w7nwhIKiEodkEPxCuRJ9LQsdgGseIGAgTsIyhJeOOal/jn30LgPMzHpXR+awDy5vgnqIpJh4rMEqUcAS6qxIP2XDo56L024JQCOR+/FWGAwAeCO7gFc2COOGryaVgh3Sp5Ifi+ivdZiDC7oZe0J7WcmQd7pWcGjF68UbWscO8eKTrnrGCV3xE23cwaRlFfiW9uiSm1F9zWcTbawcgXWm0n0pG8lpJ5VoniNldeLPggrlBeVtos2OgK9HQbbc01MKmOjHdnWHZYFXUc08DLWsSDvRh4Iq2RCQo3Mg32vjpk31hk5vgUgzminxzKc+i19OIxfJxi6Ibk7f1e7yJdE8CBQBoyr2JHBOe9xVEFmW8bq0J3pKdgpTH+7xQ5hjUrToj07iIM6LRGZYWoquCMuL+PvYm+iIAcMk3uDRjee9BTDFLH/IQ5n30Sz+TTxn+4H9s4XvsYFKQq9qfytGaA+EodUJKVwQBUXEI8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(366004)(376002)(39860400002)(66946007)(478600001)(66556008)(316002)(110136005)(6486002)(66476007)(2906002)(36756003)(31686004)(86362001)(31696002)(38100700002)(2616005)(41300700001)(6506007)(53546011)(26005)(6512007)(8676002)(4326008)(186003)(5660300002)(4744005)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXF5NDBYQkdENEdsUXUwZlA5SVVrZFczcTNoVHF4VlMvbGIvU0E1UEJmMy9W?= =?utf-8?B?eDltM2FDZWtRZEZIeFFKYmltOGxCVnlrSmNTOFdRbUJyZGptT2hrVTN5bGwx?= =?utf-8?B?eFNnL0hkVG5EN3EwanZrRVkzd2FFUUhHTHVYSkt1T0Zab2JEYkdvN0NKSXho?= =?utf-8?B?Sm4zU1o3WDNrNmVLcVllWVRCbFFnaWtNYWJGdHFCMk5SR25LYUhQUW5xTjRi?= =?utf-8?B?Zi9aUEthSTlEU0pCMG5pRnF0dnVnOXorMllsYVdIM0VLQ1pqQWNUZGhtTWRW?= =?utf-8?B?RDFPYkd2SFhMNFJBYmVUbm1lekpodmdzZkFEYjcweVdEdWpNbzM3TmdBY1g3?= =?utf-8?B?YzVubThyYnhXNGJKeHQ1Z0Q2QVkwcEZ1Q2N4RURId0RpWUZCeWhUVmxySHBa?= =?utf-8?B?SmxSTGppSjZWWVVkb3BOTFhLUi9vWVdUeXNXOUpiWGlBMU5hcExuZ3hUdVpX?= =?utf-8?B?V2FHazlHNk93ZkNmc3laMkgzK3JNU1N4LzZzbUFRMlRXK2FlbnJiWHFZRWJV?= =?utf-8?B?aFoyV0ZPT2NrVnBVVEhnU1c3cDMrck5JeG92UTNOalpMSnlONUptV05pb005?= =?utf-8?B?d3VxRzVYS0ZwSTVkN08wNXRTMFVsdDFEc1BDemFWYnpoSWhvZjB1bmZPQ2dD?= =?utf-8?B?VmtkQTJ2Y29XVlEvN2M2V010VVBTK0N6dk1PUTR2UEpsS0ZtN1ZpR3Nsb290?= =?utf-8?B?SzJzVSsyQklMMkxIb1NtUlhDR3RMUEN3UHAxQktjZTFqVzNlTGNhOG5Bc3Jw?= =?utf-8?B?cjBHaUhaZURuYmk0dzRvdlBXRWhGYk9vSjBiSXZhV1Z4VWRFa1JIY21ucmVG?= =?utf-8?B?bjl5N21wdDIwNXFxaURQdVUzbDBzMCtnbmNGbmF3MUk1dnpyUmRXdnNTcGp6?= =?utf-8?B?eDFGQnZPbWlsbENNWlpzVmdzcVZtU3crREwyV29YOG9CektMRWVDVjM1dzBO?= =?utf-8?B?YWlFdE8razI2a2FLR0pOSkh4aDdJZUVTR0JDNGg2eTVRZTlkbzl5SGRmYzFq?= =?utf-8?B?ZTNGZk1iazhiZ1k0Sjk1TFZIZlZtWUFvY25lKzI3Um9GN3RXd0h5aG1IREph?= =?utf-8?B?VnVIMnB5RHJKczlVSkhhb3NhRDEwbFZTQTNnQ2tETzRQYXV6anZpRVhsSjZN?= =?utf-8?B?TjhML1lsSlFOL01ZOGZ2aUpkc2x3ZGQvcHV5dUNSS3dQTFJDL0g1Y3BRaXJC?= =?utf-8?B?RnFPclE0NXU1WlM1RkV3Mm9YeC9UOVI2WWFVZUs2dUlWMmpqaEhBVUNDcFI1?= =?utf-8?B?TTZPcUZrSHBqSUtUSzlmWlVmY3pwRzFsREhCUW56ejZseU40L1FNbXdVWkZ6?= =?utf-8?B?aEJOelVobkxoZ3UzNFB2RXdydE5jak9kM2VNSEUxVWZ5WStreHRHbmhQWjJ1?= =?utf-8?B?Vnl0dEdhbVk0eitoclhJSFhrNjFuVjAxQzdoeGNpQWNBeXltUXF2bHVJOHBy?= =?utf-8?B?VnZRK1BTZ05WcHVpMWlQNjkyWUpjMkQ3TEx3aDFqMjYwanNNcUVIVDVqUjIx?= =?utf-8?B?Vk1WRFBqZTlzSm1McDJta1JaVW1MendIbFV5Z3FwcWtHaGI4UEY4S1ZXdTh1?= =?utf-8?B?bWNtNUFON0VzSk1UN2grMU42VHNsRTI3Q2tmUzYrWWxEMHJhV2kyOU9SaEtW?= =?utf-8?B?dlI5bVY1TEs1KzljM0pCUW1nUyt3UDl6ZXZ1MzgrNnprTk1jMEMzZWQrbXlz?= =?utf-8?B?NDlEbFAzQlNhNk1tS3lyZkU2ZnpHUTB1TmJXYnFIMnpkTlp0RUNXMnhUTUEw?= =?utf-8?B?MnJ6REFmZzg1M0JMcHFCUm9Ta2tMd3MwdWlKeURhV29DQVVDdXN4cXV2YmVW?= =?utf-8?B?Mk1yT0hTQm5SVCtrRzFHYjdJbzJ5TnZiVVMwL0dBTTJWNFRPd1NBbXNNTG94?= =?utf-8?B?R1p2QS82MVpmbEl0NDJPTW1WSHl0STI5SnNMYUxGdk90RlNFVkp5cVBmWDJu?= =?utf-8?B?dnVxMUVrQlNFdHFjQ1A5L1Z6UTduTUxORkI1VTBtaVlCYTVoS21WbWtjanV4?= =?utf-8?B?OVRnR0l6UVBoekNBdjhwSmhxam0vMk9KTmNtNmIvelZ1eFhXQVlWU09ISWRZ?= =?utf-8?B?RDhCcWJ0eHYyRW5TMnA5N1pwc0tzaGRmVXdwdUhrQUxkbDg2SUdVZThtams1?= =?utf-8?Q?mhVVaf7yc/xHKthIZyWYY38sN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb83f6ce-6583-4a06-a570-08da8fdb134a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 07:40:31.1865 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9MLAG+rT4EtgYYaW6oIrui2u2lI2v1qxxd5yMtLcKXlwp+z1mUGfBcmBmj0O5nuEa+fC6lq2xRk7Q+TcS9F+Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6085 X-Spam-Status: No, score=-3031.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.09.2022 14:54, Nick Clifton via Binutils wrote: >> + max_exclude_symbols = ROUND_UP(fdef->num_exclude_symbols + 1, 32); > > Given that the point of this patch is to improve performance when there > are a large number of excluded symbols, incrementing the array by 32 slots > at a time seems counter intuitive. I would suggest a bigger number, eg 1024 > or 10240. Perhaps double the value, thus not overly much impacting the case of there being a moderate number of excludes? Jan