From: "Bridge Wu" <mingqiao.wu@gmail.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: binutils <binutils@sourceware.org>
Subject: Re: iwmmxt2 patch for binutils-2.16.92
Date: Thu, 21 Sep 2006 05:31:00 -0000 [thread overview]
Message-ID: <246188420609202033q5ff9aa9bi281577f841620c51@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0609201224480.12761@digraph.polyomino.org.uk>
The correct disassembly result should be as below. bit 21 (write_back)
should be set, otherwise, it will be illegal instruction.
0: ecb11000 wldrb wr1, [r1]
14: ecf11000 wldrh wr1, [r1]
50: eca11000 wstrb wr1, [r1]
54: ece11000 wstrh wr1, [r1]
This does exists in iWMMXt1 instruction, not introduced by iWMMXt2
patch. I made a mistake due to I noticed it on iWMMXt2 spec. I will
submit a patch to current binutils separately.
--
best regards,
-Bridge
On 9/20/06, Joseph S. Myers <joseph@codesourcery.com> wrote:
>
> You do not say what you expect these instructions to assemble to, and your
> patch does not apply cleanly to current binutils CVS mainline so I cannot
> tell what they assemble to with your patch. They are valid iWMMXt1
> instructions without needing an iWMMXt2 patch; with my patch, and with
> unpatched mainline, they assemble to
>
> 00000000 <.text> ec911000 wldrb wr1, [r1]
> 00000004 <.text+0x4> ecd11000 wldrh wr1, [r1]
> 00000008 <.text+0x8> ec811000 wstrb wr1, [r1]
> 0000000c <.text+0xc> ecc11000 wstrh wr1, [r1]
>
> If there is a bug here, it would not seem to be one in my patch, since the
> results are the same as without the patch. As such I hope this bug can be
> considered separately from my patch; you can enter a report in binutils
> Bugzilla, or submit a patch against current binutils mainline (currently
> 2.17.50 20060920) that fixes this bug (only) and includes testcases for
> the assembler testsuite.
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
>
next prev parent reply other threads:[~2006-09-21 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-19 13:41 Bridge Wu
2006-09-19 14:21 ` Joseph S. Myers
2006-09-19 20:58 ` Joseph S. Myers
2006-09-20 5:20 ` Bridge Wu
2006-09-20 14:39 ` Joseph S. Myers
2006-09-21 5:31 ` Bridge Wu [this message]
2006-09-21 14:06 ` Joseph S. Myers
2006-09-25 16:20 ` Nick Clifton
2006-09-26 10:41 ` Bridge Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=246188420609202033q5ff9aa9bi281577f841620c51@mail.gmail.com \
--to=mingqiao.wu@gmail.com \
--cc=binutils@sourceware.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).