From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2054.outbound.protection.outlook.com [40.107.14.54]) by sourceware.org (Postfix) with ESMTPS id 0A6253858D35 for ; Thu, 5 Jan 2023 16:53:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A6253858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ty3B3rLf1qr+YWTlQpl3zr/rE0Cwh2g5+vmb6+zZ4CqxyswsT38BbDJk7O9VQ7evYJpS5HaG2BlAdm2FljHuhwjpTdvetrvbk9uNJ8uua7GJKdPA8F1VgB31zxImsIRPhV3PwXD2d7FVXfPA5CoprIzIb1Z8tF7FRkXSeE9u5jLcUbOeY0+/l54qsIjnIW6KNwqLVTNXXD9wRmTbdpe5oh3TQ9njpbhM9DpBlu2fV1aOqI2PzGLB9acow3OHnWNK1uyFd6LN664btNxVdxNnaVziFB6nz4jxIDyJWMtxOa92U90IQ4xLnypfFEzwfnL4+xST1bNQPFzJOheyOBGhyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jakmrCl43BzfeoT5cPziuBEMWabPmlIc6bc7Dc2E/q4=; b=d7Df7C8asP33ye3Kz3t1GSpxnHZMqcxDVXBsz8K2TdYcel+xGfP88uJ222w69gBXbWraXRwR/+XtSkPTU3XIEQI0RUoJQbXlUnaZ2tuv5SATerVqPE7Z+q9szy0leRGRIGpTKuxafZeHplUyDsVwfcNw9LnqYP1eO1MqylbdGgLup0WpfV2X0bHiUf+HcMeMtnPALRnkUMV3bFRWe0FatJTe+O4hmFf/9X2LeDEJDq9cDTUHuXEvNV2BDOpS6p2fPrEESeW0hkHwX2rTXpbDAxKLqczuSO8P9XhixLRQ+BbvDI78xPZQyKoZ+JcHCVimiC5C1NoLYJl59uIJzpDgPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jakmrCl43BzfeoT5cPziuBEMWabPmlIc6bc7Dc2E/q4=; b=ogGbbSvYU0Rivb1mTLpaDVZfTMc2cXjUlpWC89s7aRyBhC6q+fxUsd3rvVhe0fmWKX67XnNoLDG4L5BNrRZMzGHatLltFsy/BpFxhg3uadL/EfG80ZYk1D4/azOewJus8admwx56gkxPJzmgM3W8VLe3eZAvR6cTxel+VYjHIBccxHirw6PpG6qDCD08I7fCvxOZUd1QwMqSCqNllSYZubPs1vOxnO3mi6GSUlyx+c+20Gqw3dTIyB1qBpyFMiRWqsXblLJCngOqcuEmuVCIGIg6kvTnFKmbokI4cXmT2DU+Ct5IX7psLzo2Rmvt49v5boFtVxkHD8BYBGWVfSxhAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8928.eurprd04.prod.outlook.com (2603:10a6:102:20f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:52:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:52:56 +0000 Message-ID: <253e0337-5c05-5e56-de71-6ff890502af3@suse.com> Date: Thu, 5 Jan 2023 17:52:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] x86: Remove duplicated I386_PCREL_TYPE_P/X86_64_PCREL_TYPE_P Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org References: <20230104191414.149668-1-hjl.tools@gmail.com> <707373e1-01e6-21ea-c407-db61da912e22@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8928:EE_ X-MS-Office365-Filtering-Correlation-Id: 75b12570-726e-44d9-3dc8-08daef3d4b78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qH/nYYVS1329rGHUKQ9y/gKptJLlG03wWgcdpOG/rGIoXtMLuQ1rvTzFOKEozsma42a15sJbo46LGJINgZ7vGecg0iGH3vHexSTvydEV3mXVzzZuhb8CoCebIEwsPI+63moRcAPhGg7WwD0lRGOKfv9YDlyyXG/kYsoPDdLITueJz+PyDAdBxoDRMxCwUxpFkLGpp8eNzAgfP3kYkn0hwx8to2bbitD0Gq+xPS246TmrLqOiWH01Zcy0kyEWPnt6uMqIkx92vCl7QD/T1iWDeB97hT6uWbmLKgPjsB3uJWI+79GQsF5X7puqu7q17aVsMnPJJ5vc4f32D3ZWc8Uz7Y6m/1LLbOnQedJNs2Y2c23GNukRGULOkhMaw5KYFyPcsP50z2mh0fZo0u0+lAcEAwXBV8t5JkJPBi9idzIgBn8BM9EPj0riTkqmpkiX5o394RvXTn3amKY3MgQt7dNatlXLxDkiwOhgb+tDAJrjMbKxtalNidwFzEZkeKWV2bpeIq8AzuCOhMtBi/CmfS2cGPtofyrKcehwcOwMo8Itz0bPiDxxx61TD5R1ye/wQKjECa9XdfBdei5YBKeOi2Jqt9LOHDmvkzvJMM0c8QvWJ3B564U+1g8fbaxP37jC3rk0TZBPoPCgTu9xVSnum8qOef8CaDcTEbajhcZzPB/0oXWMouK82w7UA3UyO/B62gb8t6K6vf9un7pfVOpFLaUmwYvaC+HYd5nnw6Z4yETMqIo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199015)(31686004)(8936002)(41300700001)(4326008)(5660300002)(8676002)(66556008)(66476007)(66946007)(2906002)(316002)(6916009)(6512007)(6506007)(26005)(478600001)(53546011)(186003)(6486002)(86362001)(31696002)(2616005)(36756003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFNBNGJzdXpsb0RWejczZzE5ZU9mWE5HQTUxaS9BdzZQNkxoODRTWlhWTkJG?= =?utf-8?B?OUt5aVJMR21FTG1RYVJWTVRHMkFiNnk5bWw1UjB2RW9sVnJaSHp0akcrMzE1?= =?utf-8?B?Z3ErZ3RPV0QrVzZlQmRMdUNraGZockxvVXFURWpoU0hkWndPeTF4ZjJZQURX?= =?utf-8?B?aEhTMkdiYVQ4RG1EaEZPcnFuU2x0d1E2R2ZsREt3T1RWVzkrSHRNNkkvaE15?= =?utf-8?B?QXRHMUl5YkwzeGFNM0srSkRMRm9EOFJtZ2x0VlluK3V0SWs2TzlBRHFVSlVl?= =?utf-8?B?RnZoWWRzNEVwc1hUcXIrZlJlekVldEZra1oxYWFCbkRwM0VEQmQzemVERkZR?= =?utf-8?B?aHVsb0VlUmtkbUNHQVNnVXJhcWpZMFhiMzBNZ0V2K2VDaXVvRG5uNTBzVmpw?= =?utf-8?B?NjJndE4zelhhY0F3N0h4aWJPWTBEOWNhdzExNFBhSWJnOUZPZHRhMWwrRmVC?= =?utf-8?B?RWo1VG5kNUpqaW5sNkdpSDJoMDNSZm92V29LNnpXR20rQ2l1V1l1KzdsZURH?= =?utf-8?B?L0s2QnBhWlRYcXRzZ2xHUTYrRkxRaiswOGU5QzlXdHBKQVlkK0JFaWtST2V2?= =?utf-8?B?Smk5b0dDOHRIWVdxb2hHenB5NXFPaXJyV1RjbFd2a2dTN2xXUW1xZXI5MXBI?= =?utf-8?B?M2VFN2o4TDByZ0pXZnJMbG9rNlVSdFFDL05iSjcvR0E3NFRMMzVUdXc4VlpP?= =?utf-8?B?Ry9UVnRFZ3poR2NXVElOeTVSYTJmMWdtdTdUdTljQURuNUtJeTVnL2tta2Ja?= =?utf-8?B?SU14OTZmbnQrWis5cXFxbUJrKzY3SGFzZkFpRk1rRENYZU1mUEZ4MWF3Uzla?= =?utf-8?B?OVRJaDhiVEdkU0JVeXM5WHBVZXdodHovcEMwbjFraHcrU0NEMFZldW9rdEUy?= =?utf-8?B?ZEhiNll5R0RidEJPMXlacmwvVS9ZcnNGbXRWNFgwOWRma0VjcFh6MlJaYnBR?= =?utf-8?B?ZHZnQjk1UnNYVEpXRi9pak1iU1RDMTBwaTRLNFBaZjlXS0EyMHZ4RklGcDJH?= =?utf-8?B?ZVBkL1o3MXpEaDNialZlUmxJNFREcHRTSENOa3c2Z0xRTHQ5d0YyT01sUHBy?= =?utf-8?B?UVBVbklMbmJtdnlpRVVxWnpwQmhDSERzWnQyaUtqbEpWQ0Z0VjN1M0NpZVQr?= =?utf-8?B?Z2tSMFR2OHJmYlVOMVBHQ1IwaThGMERzU2tjQktQTkJrb3hSelp4akNCYnF3?= =?utf-8?B?b1dsTWVweVZZNEZTaVl1QzRqSmFBRHZYNldGQ05MME1vdVBXeEs5K29JUEJz?= =?utf-8?B?WXU4ZEYwakZmUUpLQllFNUc4VDNjOHcxVTI5YU9SSUEvZ3Bsd2lDdHZvYkJU?= =?utf-8?B?L2RGZFVHbGdpZExITDJ0dys4SHZrZTZYZlZIK3VLRDBNWWFoNmpIWWpZVjRD?= =?utf-8?B?cVZ6UUhtc0JXRkZuekdBdTJEZU4xaG1rV2pBSks4Wkp1RUtkUEZRNTVPVDBS?= =?utf-8?B?QmZxWVNMcDZYNTh6Vjl4VkVGTlVVWS9xc0k5dmVmQXNPdWd0SVMwak9PaWI5?= =?utf-8?B?V01pL1QvY3lBY3lLcDBGYnFOVWtIbnlsZ2tDWDdmQlhFenhMdVhPZEI4Nk52?= =?utf-8?B?dThuWGlpQllGUTFGUGNXVkFjMEJxT0tHcC9JazVXdndNMndzYit3TnJianVW?= =?utf-8?B?akNadUtqZmZsMnhqZnRFM3ltcTRYTHREUUZmcTNPRitQOGcrVnRJUnllMTBV?= =?utf-8?B?YXpwOXVraC9aNjRzNW1KNFJXVnB4ZkMxSWpHa0orWmxNaEhtU2kxUUgwS25T?= =?utf-8?B?N1RsMzFWY21vRzYvbHFvRWZmSE11cEpPL21rOEg4ZEFCMjhJWG5ZdnJ6SWRX?= =?utf-8?B?L2hEdS9YOWdISUU3Z2hyYTNlVG5abk0zLzY4WXJhUmlpcFV2QzExQzRaaE9H?= =?utf-8?B?dnVCRlUxd2xXeUpKemJaUzdiR1hVWnExVFB3NXRKSEFwYUlLTVY1RWZ0a09W?= =?utf-8?B?R2xYR1pvTUNFTHN6dkZndzZTY01Pd0pod3VOcWVVb01xUTZubjAxbGR3ZWc0?= =?utf-8?B?bGFuNksra3JWcC9SYnJ6VDdqU21lcTB0T29mWmtENCtrUnc1TFJXS0xMeE5m?= =?utf-8?B?TGFScWFhNjhOYkNPVVkyc3RLU3BIK25PYS9MZnJiUjdVYjVteldSOEVQYjFM?= =?utf-8?Q?pCiyjY9W8kh7N0LWnIr7jRwsd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75b12570-726e-44d9-3dc8-08daef3d4b78 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 16:52:56.7686 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Idudi09d0BKkyvTt5amN5U4Yeq13wUYoHtUMaVle9SHJ/2LI1ArVp31HkUjwMpLlnMlM2/JxIoLZnAR0bXdrbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8928 X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.01.2023 17:50, H.J. Lu wrote: > On Wed, Jan 4, 2023 at 11:42 PM Jan Beulich wrote: >> >> On 04.01.2023 20:14, H.J. Lu via Binutils wrote: >>> I386_PCREL_TYPE_P and X86_64_PCREL_TYPE_P are defined twice. Remove >>> the duplications. >> >> I recall noticing this as well, quite some time back, but I didn't feel >> like touching it because I was puzzled by ... >> >>> --- a/bfd/elfxx-x86.h >>> +++ b/bfd/elfxx-x86.h >>> @@ -97,13 +97,6 @@ >>> #define PLT_FDE_START_OFFSET 4 + PLT_CIE_LENGTH + 8 >>> #define PLT_FDE_LEN_OFFSET 4 + PLT_CIE_LENGTH + 12 >>> >>> -#define I386_PCREL_TYPE_P(TYPE) ((TYPE) == R_386_PC32) >> >> ... this not including PC8 and PC16 when ... > > This is I386_PCREL_TYPE_P. > >>> -#define X86_64_PCREL_TYPE_P(TYPE) \ >>> - ((TYPE) == R_X86_64_PC8 \ >>> - || (TYPE) == R_X86_64_PC16 \ >>> - || (TYPE) == R_X86_64_PC32 \ >>> - || (TYPE) == R_X86_64_PC64) >> >> ... this does. > > This is X86_64_PCREL_TYPE_P, not I386_PCREL_TYPE_P. > >> Jan > > The current ones have > > #define X86_64_PCREL_TYPE_P(TYPE) \ > ((TYPE) == R_X86_64_PC8 \ > || (TYPE) == R_X86_64_PC16 \ > || (TYPE) == R_X86_64_PC32 \ > || (TYPE) == R_X86_64_PC64) > #define I386_PCREL_TYPE_P(TYPE) ((TYPE) == R_386_PC32) > > and the ones I removed are > > -#define I386_PCREL_TYPE_P(TYPE) ((TYPE) == R_386_PC32) > -#define X86_64_PCREL_TYPE_P(TYPE) \ > - ((TYPE) == R_X86_64_PC8 \ > - || (TYPE) == R_X86_64_PC16 \ > - || (TYPE) == R_X86_64_PC32 \ > - || (TYPE) == R_X86_64_PC64) > > They are identical. That wasn't the question, though. I really did ask about the 32-bit vs 64-bit difference, which looks suspect to me. Jan