From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2061.outbound.protection.outlook.com [40.107.105.61]) by sourceware.org (Postfix) with ESMTPS id 4771C386F821 for ; Fri, 16 Jun 2023 10:16:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4771C386F821 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IiTG/N1myvennitp3dx7ZNr9EB190/pjeKs6vGLn0cZ2Nh9wjSIhKcOJOZexDRn//hzBreefY6G/H4vxZEwtPikOBn2TwJ8GXUKkyb+fOr/npp9hTXAZegFeKKQ2RJRt0tgplHbKeifzZ5Cd6RyjQzD3f1iOpuW8VniDVuyUCX3qyJng3aEicBSXN3Zm1T90/JWHl0V6ZNwjmaMW7IYKR/8d4B6ft4Sro6xJTUaMAH+Kmc3Nbe7LdZDrmrIHh5Y0oQqt8Q06V42/2+R+84teGjQSVY20uAeslXLcU+2sI7lkSwpo+gSf5buyOgoR6Iapsv12HziIeXgoHOZXS1ERhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B1Y7UXQm+HDlczfSkEpWTl59UMhsrppjIgNuxmiymTo=; b=Jc0Z1niOcwwjQc2Z10E1l153VD8gbQM1IR3f+pekgoJgT9nzbWy1sRRhjeC8u2+sChr+zpZ2owNmVBERskN1jifnWdpPDkALRDumlcyjMmnq02jbzXW7Cbq5h5bI1m5d0+AnYqQ3xVmnT6LlAACtoAAcbqORC033xw+AqbRsFaTVWWbPrMGUzT0lpdD+M3+XLJZDeJjfaDHRbZhWsx60HhSyw9BY1WfhR5dI5/JgosVwHCvRqN6PSyPuk9rJlB/9S6myonJfiDkL72Un2FvIQ9sSchnZuUxqSb5zpISzRR0nvsnRauJUv4l7DcHqMNN6GTsoB2fa5Sgv9g+RsH/vaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B1Y7UXQm+HDlczfSkEpWTl59UMhsrppjIgNuxmiymTo=; b=lmb59tuNt20U9w5WRDRbJxX5H4sizSp5UgnX3KliLM6zbKh1Fq4nXsgosSgPfWNKLcTSaYK+Ry/3Q1OeZ64yMwc1boahLlXj2MYn4z7JKEwugqbe3gTK5uj8j0CQQQV8h8BIWd85xgsD2JQxaXioL4fZbSIPSqcXTgzqQgpaaGp3dHnQR9CJKbIkJ1PQCDU3K5/4lgtQJAQjf6q5p+PG/9cJacBFO292SldJe6yy6PhDojoL5sYJebqm8lCjEa4aQSXXireKHAVstmw5nRuPoVARzOaxwPI9eAlkBtCHG0Hht6lLSip3sriGd2bMgdNJtIC4Iy+WxdQXuQvL/Pl4og== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Fri, 16 Jun 2023 10:16:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6455.039; Fri, 16 Jun 2023 10:16:45 +0000 Message-ID: <2574a7d2-68aa-70e3-c5da-fc726c952c22@suse.com> Date: Fri, 16 Jun 2023 12:16:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: [PATCH 4/5] x86: flag EVEX masking when destination is GPR(-like) Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: <74bff744-e838-1e98-6cd2-dcaff901f8a6@suse.com> From: Jan Beulich In-Reply-To: <74bff744-e838-1e98-6cd2-dcaff901f8a6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VI1PR04MB6944:EE_ X-MS-Office365-Filtering-Correlation-Id: 02c2be26-7834-4cce-fc2e-08db6e52c9f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lxp5SG2TXQ5FIIbeh7Vv3QkZeAWnfNM4OPMhdYSVyA2lhhVmyCEa1qVeRTqqLabuE7eKHfKm1d68kTu9b07KfwGWGmXRrywjnrLGjChMSecv9xCy/RlNJJU5cZOO4g6HidlAbl9nY5BCAwl0HkRLscjtZP95FZvvZtRdwGh/zjsbnGo+j7otXXFJ0fJxyem9e37BOPDrfWS4bOaxgmzkCIQ5dxMtg9lHk66LC5DFM6WY3gNOQOjTS8bJu0FOcvMiC1zDFWMQvIF1T6VbYI4vuDXG0onv6Mdz0c1G9XoznFW0PInBAtzDsCSbKhWV/l1q+RpmH8rBDINYqMYvgx7Awxf7dQxZ2AkS2sHNH+fSJy4Q56Ig5CwhcybbiGUrjRaRVbtjoJZ9bM45uj8k/A+pbA74IS1xqOJ0JdHx5fRB6v+S8cTqJ9Qdpddh/WsYxSKPSCBxC2TBcUGXIuKosfTgLuG4gzcFmdM7vZeMLqMOUntRxZV7plGs4QsDKe7vv5tjYYJA0Jd5Eo5s+Cw6nj3aEOEJMK2WrSnb/+XNPbZvIx827d1jOjYvDjvIe8GndDxQDJv1iYSPqJzRBqraFTgK/LlLUVTaiyfOPvqYaA8mVr0go7gGzYxWFTnpEyXADgzA6wy4GRc2sBd6pHkS+t/0ZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(396003)(136003)(346002)(39860400002)(451199021)(186003)(26005)(6506007)(478600001)(6512007)(31696002)(86362001)(6486002)(6916009)(31686004)(4326008)(66556008)(66476007)(66946007)(316002)(2906002)(8676002)(8936002)(5660300002)(38100700002)(2616005)(66899021)(41300700001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWdIR2NkVzdTdFhZMHRDZ2JNVkhCY3l4cDhhNUdQMk44K2JGOWEwTUdjVEpk?= =?utf-8?B?M0c5ZjJlT216dEluTjRaZXpaTkRtZWpCV01WV3VtZWU5d1FJRUZ4eFdQd1Jz?= =?utf-8?B?c0RTY2VjZHg0QnNCUkRSeVpiNlJVY0lXRjJRTGg3bU43QzRXS1VEMW5FNUp0?= =?utf-8?B?NTVYUjgrZTJMMWpsakRZNkQyZW8vVWNjeE9GbmdzTHgwNE1tc3dEVTFlSzVC?= =?utf-8?B?SWp4WDlDcTVUMWIyYk5WOStFQVhXTUVzYkJkNVQzU1E5N3pSM3RDc3ArdWVp?= =?utf-8?B?QnlHUjR0T2V0dHN4SGt5Nmc0ZUtmSkJTbkNBKzVNNWtPWHJRMXJ6UERZVGF1?= =?utf-8?B?aDNaMGFCZmFjYi9NOHNpRFB5VFI3QnBDcFlrbnYvMkdWQ1YyaW5UNnNaRTFk?= =?utf-8?B?VUJ5clVpUnRidG5IR3RHeVNRcFhLUDcxd3hZOEJMSnk0UVJlQi9qWkRaTFVN?= =?utf-8?B?ZjVxTXUxRitNZVUrSVV0RUxvdjVYZXpvMUZXa3RlbjNHWE1uNDRzNFBPTGdy?= =?utf-8?B?c2FhbjV5ZDI1SXMxdFgrVjljc1JlWkJDVE11WmVXU1JidnkrVkZYZjdVWTd5?= =?utf-8?B?M0VidDVEUDE2QzVYT2kwME05bWtBR1dWRlhlYjZmaFFKVUw0eGNNODU1TmFk?= =?utf-8?B?R0xuWU9pUkd2bzZqZHkrQ2xsNWVzSUk0c0UwUGc2SXo2VSt4MWRwVXAwVUxW?= =?utf-8?B?MElQd0FOVG01aDB6aHBEa0swK2FJbG1sdWpLbTM4NzkxN05LRWlPMVNPdmMw?= =?utf-8?B?MjZzaUxqVlZSZDR2Wk1iWjFaSnVkWU1uL1hBbkFNUERDUmhSMmE2T2x4SXEv?= =?utf-8?B?SXRvT0s4VHlTZmxrakFpb3p5aGxjTDVVTExxSlNadDlreXEwS3BHb1FXYllH?= =?utf-8?B?TStlaWpnbENjZlMxTHJQeEpMekV3NWVQeWUyL1I4akJpbU4zYU92MGtYeC9E?= =?utf-8?B?Y3lVZUNENXJnRllNQTFxOWYwK2tkdldZNFBlNzhGRVhSR3BibTdFV01Qb1VC?= =?utf-8?B?bWFMZDJhSW9rdnRvL1ZCbWU4NGFCb2s4bXNkNjZOM2dCaS95QmkxeDJEanYr?= =?utf-8?B?LzE3MTJsalBKNlA0Vy8wSXZ5WEhibE5NNDBvMTh0Mk9VOU91bUtUTlVDTVEz?= =?utf-8?B?TUlsbkZ4SzcwWXJwNkpXVW1WMGxEL1h5OFFOQ05USEZoNWRnTjFYTXYvS2hy?= =?utf-8?B?RklOTGFVd0lJWWluWGU3RlRUcXdVazREL0VmMmNlQXFRM21KZEdwUzZjU0h4?= =?utf-8?B?NWx0TDdzRlg5S2hqK1FzdE1DZ0hra1IvOGdrSmluaGxHelRvaEppdTNzSEpX?= =?utf-8?B?K1F1b1J2bjh4OE56OThOeXcxOGtUWUtTR2lhWnRGMzg0b2FWelRicldJdk5k?= =?utf-8?B?dHVHN0NkTFZOaWtjTWNBRWFmdEZYR2ZNWEJkYnlLM2djWXp4N0tKekh4VnlF?= =?utf-8?B?L24vUHVQdVlBa2cxMnlPMzE1MGZVOG12MTFzOFNITDhrMUM3TkNUQWlPVnY0?= =?utf-8?B?QkVXWUMxdnVMSEpDVjljUGtxbzFQWkptaXY1YmJMTWx1NHBDbHdJQzRQT0FB?= =?utf-8?B?cFRXV3QvYUhYeG1GelhucFNVaDZHQmZHdjdsZHRBNzlWNjRMcGtsNXdWS1RY?= =?utf-8?B?bmdPMm5JczZiK0RuMVlsbXUyREZvWGpCSmNnUFJDZnA1K1BBUnNOTVdDZlla?= =?utf-8?B?SHNGMHZ3bitBZDJmSHpsRmpCOEhiZXdTWXRPd2ZkL3pEUWpaRklOcVZXbERN?= =?utf-8?B?WUJHRlhSZzcxV0FpREZPalpFb05aMHd5ZHdRY0RSc2J1dFlzZ0JuTGxsMHRZ?= =?utf-8?B?cllJZWMzU2ljdlhXY3p2YXYxLzZGU2o4dE5TSk9EL2s4NVAzQktLMk9EQlV4?= =?utf-8?B?NjlYc08vZk5TYmVNRUtONjM2VEg5UUhwMXB0OXpLZlVkRHlrWU9iK0t2eVpW?= =?utf-8?B?TEVObThUVHBNUG8wUnladG9iUXl3QVBpeEd1VFpqbHFYRXA2OWs4UEt1SkZX?= =?utf-8?B?UWpvUUhhV1RMSTcydDg2alltRUY2Ym56cUNzVkFPMiswL2dMQXFSeFpYUk5B?= =?utf-8?B?RnF2RHJWYmFiQlN4VDRIS0VzTE5ibGZybWc4MHBRQmp6Y3JtUWF1RjB1OXFV?= =?utf-8?Q?ZWWcEkSMdn86aPhK248zGI7/j?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02c2be26-7834-4cce-fc2e-08db6e52c9f0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 10:16:45.8687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ou/CVsVUXAtJcSpNTtI7oEKzdEPBDNDfedjVjusvTqQP85IRpjMolxRZNExCvnxQBXzkIU7UhOYD8z7OK+zFQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Masking is not permitted in this case. See the code comment for how this is being dealt with. To avoid excess special casing of modes, have OP_M() call OP_E_memory() directly. --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -11640,6 +11640,11 @@ print_register (instr_info *ins, unsigne { const char (*names)[8]; + /* Masking is invalid for insns with GPR destination. Set the flag uniformly, + as the consumer will inspect it only for the destination operand. */ + if (bytemode != mask_mode && ins->vex.mask_register_specifier) + ins->illegal_masking = true; + USED_REX (rexmask); if (ins->rex & rexmask) reg += 8; @@ -12374,6 +12379,12 @@ OP_E (instr_info *ins, int bytemode, int return true; } + /* Masking is invalid for insns with GPR-like memory destination. Set the + flag uniformly, as the consumer will inspect it only for the destination + operand. */ + if (ins->vex.mask_register_specifier) + ins->illegal_masking = true; + return OP_E_memory (ins, bytemode, sizeflag); } @@ -13156,10 +13167,14 @@ OP_XS (instr_info *ins, int bytemode, in static bool OP_M (instr_info *ins, int bytemode, int sizeflag) { + /* Skip mod/rm byte. */ + MODRM_CHECK; + ins->codep++; + if (ins->modrm.mod == 3) /* bad bound,lea,lds,les,lfs,lgs,lss,cmpxchg8b,vmptrst modrm */ return BadOp (ins); - return OP_E (ins, bytemode, sizeflag); + return OP_E_memory (ins, bytemode, sizeflag); } static bool --- a/gas/testsuite/gas/i386/avx512f-nondef.d +++ b/gas/testsuite/gas/i386/avx512f-nondef.d @@ -22,4 +22,6 @@ Disassembly of section .text: [ ]*[a-f0-9]+: 62 f2 7d 48 92 04 08 vgatherdps \(%eax,%zmm1(,1)?\),%zmm0/\(bad\) [ ]*[a-f0-9]+: 62 f1 7c cf c2 c0 00 vcmpeqps %zmm0,%zmm0,%k0\{%k7\}\{z\}/\(bad\) [ ]*[a-f0-9]+: 62 f1 7c cf 29 00 vmovaps %zmm0,\(%eax\)\{%k7\}\{z\}/\(bad\) +[ ]*[a-f0-9]+: 62 f1 7d 0a c5 c8 00 vpextrw \$(0x)?0,%xmm0,%ecx\{%k2\}/\(bad\) +[ ]*[a-f0-9]+: 62 f3 7d 0a 16 01 00 vpextrd \$(0x)?0,%xmm0,\(%ecx\)\{%k2\}/\(bad\) #pass --- a/gas/testsuite/gas/i386/avx512f-nondef.s +++ b/gas/testsuite/gas/i386/avx512f-nondef.s @@ -32,3 +32,9 @@ # vmovaps %zmm0, (%eax){%k7} with EVEX.z set .insn EVEX.0f 0x29, %zmm0, (%eax){%k7}{z} + + # vpextrw $0, %xmm0, %ecx with non-zero EVEX.aaa + .insn EVEX.66.0f 0xc5, $0, %xmm0, %ecx{%k2} + + # vpextrd $0, %xmm0, (%ecx) with non-zero EVEX.aaa + .insn EVEX.66.0f3a 0x16, $0, %xmm0, (%ecx){%k2}