From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8529C3858C2F for ; Mon, 15 Aug 2022 13:11:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8529C3858C2F Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-494-lv_Wd4JxOMSawBkzLG4Ivw-1; Mon, 15 Aug 2022 09:11:24 -0400 X-MC-Unique: lv_Wd4JxOMSawBkzLG4Ivw-1 Received: by mail-wm1-f69.google.com with SMTP id i132-20020a1c3b8a000000b003a537064611so3623448wma.4 for ; Mon, 15 Aug 2022 06:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=M22POD85NFsv0UYPwaVQgPozjjL7p954RIb+Ydj9xcM=; b=VQlSzMfsygpnx6S897WqfZriTjckP6XslBmekWAK3iY6Tch1DJTFHGxD57mJffA+al h3mtpIR2WmoHICSXIZLu4wshVnJ/sPmuFL0mOq7UrV16JOFeDaJ+KeFESfVKzkhzCbez R8OIZC6KlpvPbtm5TFcKlOJ3vtDdNdc/t3aEbx0HALb7ykqa36C3hHeK6GazuuGFUwkX ismNDL7LDQkg7igYMo/aP2Kfd/DTg2AiuCF02W72Cbh1mV7LtAzOB+yrVAOidpRoGQdS +/aX59GJ/QI7YWTNvfG5HTD2di79T9EAAAo1E2KYvzrYYpdKUJxieLdCcCl7NwVKzrr3 Tv4g== X-Gm-Message-State: ACgBeo1FFU4q3j3ovSPVoFuZN5wy4VdUj3IfNPNLaQfGQDSvnofEUQqX rWYg1dzD5kMBi/s6F6xF4RHvBi0hRs06wnW3ihHrUgTCytIcpbFpvwrCHb4rT98PgeWqy+nslHA iqmJgL9qx3js5XV44wA== X-Received: by 2002:a05:6000:2c8:b0:221:7aea:c87f with SMTP id o8-20020a05600002c800b002217aeac87fmr8181814wry.242.1660569083179; Mon, 15 Aug 2022 06:11:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR49MDj4DvArcM486YX34666RbHI7UbnM7HERXBx0jMKNTZrtAtYbY+5AE3bPGVzv8SfL9dx/g== X-Received: by 2002:a05:6000:2c8:b0:221:7aea:c87f with SMTP id o8-20020a05600002c800b002217aeac87fmr8181808wry.242.1660569083037; Mon, 15 Aug 2022 06:11:23 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id by6-20020a056000098600b0021e571a99d5sm7420354wrb.17.2022.08.15.06.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 06:11:22 -0700 (PDT) Message-ID: <25ab4902-3388-8fa7-615d-01d911e5efa0@redhat.com> Date: Mon, 15 Aug 2022 14:11:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH,V6 07/10] readelf/objdump: support for CTF Frame section To: Indu Bhagat , binutils@sourceware.org References: <20220802080452.1143351-1-indu.bhagat@oracle.com> <20220802080452.1143351-8-indu.bhagat@oracle.com> From: Nick Clifton In-Reply-To: <20220802080452.1143351-8-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 13:11:28 -0000 Hi Indu, > +static bfd_byte* > +read_section_ctf_frame (bfd *abfd, const char *sect_name, bfd_size_type *size_ptr, > + bfd_vma *ctf_frame_vma) > +{ > + asection *ctf_frame_sect; > + bfd_byte *contents; > + > + ctf_frame_sect = bfd_get_section_by_name (abfd, sect_name); > + if (ctf_frame_sect == NULL) > + { > + printf (_("No %s section present\n\n"), > + sanitize_string (sect_name)); > + return false; Typo - you probably wanted to "return NULL" here.... Cheers Nick