From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2069.outbound.protection.outlook.com [40.107.105.69]) by sourceware.org (Postfix) with ESMTPS id 72FC03858D33 for ; Mon, 30 Oct 2023 08:31:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72FC03858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 72FC03858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.105.69 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698654669; cv=pass; b=jnZ46bdXXfuDBZHTeQCWrU0ev2Ii7pXUdRf/DCJwz0ZRlsnXoa9HcRBMGe7i/DoA4t7dQY2+HlODiVZZx5QwkXANbEQs9R+my7MlPTr72E193Rq1I4sUmpG5lWDmwg9qZsodSBUFqLXviTLEOpICimpjEq8JSAvq7mKvmgvFboo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698654669; c=relaxed/simple; bh=mPfg7i8i68uJwJA+piExGc7z7yC4mp8NhUb2evBTzc8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Lmax8bvkWlCH/3aOMUa3TYl0eCS8F4vnxsXmfdolt7yiE0fGZI307nfw2wvhiIXf4I2Sgrxz3zvUInAJ5O+Q8P0wz2jHGEKcSqwK5BlC/gqmhK3a8GHyCsDftAYayADIr+WzVAg5PVIEhaMavz86WLt/qWMIDKozWC3MZMjrHO0= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCMgEUpMaQNNgVRS8YHbPcbn8iuvttwE+hIB7Sw9w6k+qEzlrOvBCJa4ZPJxDjf1v0X8krOTua8iRPEnWgo3zoTYOllFTpR8t9LFQcak+wI05cQnOAYIraqJZAudkoyVKvP9kyifmfE79tPXc8WwOQBmw2BUyDct85etjbHjlj/vc5O8cVoPLRqogHmLs6Vfma6Tn0bPGuRi7XOYmz9WL0kKo8P4r3cmm3ZVciyZP6nO/hQE2MpsJ4lAKKejmI7W3S96rYDw8JMn31vlnox9f3fI99SN7+Dsw3YMLsOjUGAji0SLSE5FcAB/82mXtXCNLbDcNU4pqPBfig9C1jw37A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YEB52in0KAWFI0FJIVJgjggw1Pv+MJhXZwULQ2db+tY=; b=Z3u2bcAGejk1b/oVAbBvFOUBJDiNLK8rY0hSlhzJM2ADLkKvkw+zd2mdqNjtxSxpOZuuu+dZOnGgWrKq3fSsXQxCRX2ZEI+Dopeb813GKN+h9Qi0E13CvglQPGn7U6t0JNWVKGoesuknYOCLraWINGWeFKvvmOadOtDuC/HLZlM9Uw8R+kSb4oMkKM9jIziDM9EHgg5mWhfNILwH/lepU3Mi6PAljdjGcJJRKsODgz55dxp9vRpl/CBZoU9CFx2wBhYSrMv93fYHHit2e6blO0jD45LfQTvyYx4pw6g1D3VFZ4TaUqgRE6lyb/3EPIcTJjYFp+XbmzgX0HkmNyjoKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YEB52in0KAWFI0FJIVJgjggw1Pv+MJhXZwULQ2db+tY=; b=2FIYXlCGDcyA4Es16uSmxWu2oKpyTnbkrhPmImc+0TZuBnzXAR6exV7gm8zQnclGQIKYZLB6qv7zIfxV+UV/Ecdzy1iWfYCH31G/UoNgao+1FlRrKmWBT/HaLuIiRt12tzIpQbama70xDAf+LKUoC+79uj9V6KZ87moXicYsXYW9PV6Vg2kpWFpQdbeSikGuRfa8gDIJdUdob3EU0GLIFlslb7+zd/9jr5xmv7F39uXx63fMRErdnWCpaNDoO70PgZ6b0KUxIhblTSoEnrbmxTqE8aQFNZBvjbP/LQRSN84sw4UuupqiYhHO2Ge5Ah993LFxd6FZyCYqnsns7GshMQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM8PR04MB8002.eurprd04.prod.outlook.com (2603:10a6:20b:247::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.11; Mon, 30 Oct 2023 08:31:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6954.016; Mon, 30 Oct 2023 08:31:04 +0000 Message-ID: <260c522e-dbb0-7e40-1419-5bb269fef823@suse.com> Date: Mon, 30 Oct 2023 09:31:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH][v5] Support Intel USER_MSR To: "Hu, Lin1" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <2b4a78d3-a4e1-9fc3-c143-63bef46b276d@suse.com> <20231027090044.481533-1-lin1.hu@intel.com> <78d5c172-399d-9224-6241-bd2d4c6fc884@suse.com> Content-Language: en-US From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM8PR04MB8002:EE_ X-MS-Office365-Filtering-Correlation-Id: 48321aa9-74cc-4549-5ff9-08dbd9228e07 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1axlQ8sp6IKFh7C2sQlO6frMWztC9dVUWp/hET6rl/IesQjqy9dVueSCFD8cdfh/QooOyoJXu6bo7AUEtjx/F1fpxPtQjsuUfnrUmc5slNGHZ+F2f41X1NnGGbRF8pfZfCp+8TKPvBAA1CIPkOsDOJdeanABemPZ8ODk7TwE2Zd1WOeRNadVR4FN2msPc/5fOY9VrQ0B8dxuOi/9qlR6XpNdqbBNVU0m9fkU5wPH5h8FSKR+3DpUO9ynXuagdavqo4VFiA6fmcd++OajzTb3wkPIBx/IZFd/GJx/F6OQ15SVNOc+1YmSV7pN7HbhMt/TfT03QXgI1zKI941UapiV8WkKmObhX1h6asQ0enhLh7g9dK64jV303qjpvsKwqcbkwv0U3+LUdwGr6s3d8cqd/XYK4AEobbVMjr7qgo1Ml9GV3uPzP4CWpLrVTmMiN1uECPKtMJmQ/dnbq6kLzKmtRKUI9hP36gJgov/XwK+BqPCK1V8eKz0HiJjBlLx9mU9YT4NOdZXkwtZjMlhxNRiyZoryg6xpXdE1sshbMeJ44E+C19wzSfGiFYnA4b5e5kYrTARFg/0u/9QTsoJyszRl10OrUAU5qFALdFWIKUoiyUN26m/tGAXc/AYoT5FxNBAKHAVs+O7Y3qDFAVI4U2cW7g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(346002)(39860400002)(136003)(376002)(230922051799003)(1800799009)(451199024)(64100799003)(186009)(86362001)(6916009)(2616005)(41300700001)(38100700002)(2906002)(54906003)(6506007)(316002)(66556008)(478600001)(5660300002)(6512007)(6486002)(66476007)(83380400001)(53546011)(36756003)(31696002)(8676002)(8936002)(4326008)(26005)(31686004)(66899024)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkZwN0hyc05COGFjUndTRVNIVmF3RHdteGNUcUc5V0VWNG5IRjhkZFNmOXkw?= =?utf-8?B?RC9SZ2p5ZEh2SW9XbE4rZUhHUkkzQzRUcU43dEsySGJsOVkxNzdsakh2eTBw?= =?utf-8?B?SEI1bTJIR1ZlZHJGUHoyYjJ4dTlxdW53a0NEcjJkZHIxQUJlOWFDSFllT09I?= =?utf-8?B?Tk9abk9PQlBNc3o4Zk1qdjVVYmNCMjV1UVg2N0VoMGhRUEhWYjFzbXhIbU5V?= =?utf-8?B?OVcvQ1k1MUJOVjNjWXhuQmFrRVBnU0lTZHN6QnVGOHY2aXdwUUFOY0FPdnNi?= =?utf-8?B?Y0lYRDhiVHcvSUtNZHpFS0FMS2NsckJrK1JXSjF4RUUxb1RKcXpuMTFFUEpx?= =?utf-8?B?ZXY1bnRZcFk0QVkxdVJKQ2I2YUtHYkpjMG41OEdNQjhRbU1FcnQxS1dObldZ?= =?utf-8?B?WWdNemZBcGNmZk1odjk2SGw0UHFSTXBWT3pNUjdQV2dseW5qQkdJbEJDRVk1?= =?utf-8?B?VUhNOXNZMW1hays0b2NyU3VSWERKaXMzd05kSTVrcmFsRHhWeWdBdVc4SVlM?= =?utf-8?B?cDgrWFVOb3Jva2ZTL05VcUJvSlFnSXc2QWF1bXdtcTYyeGlFRERqNkdoUVN6?= =?utf-8?B?Z2IyZmFNS2JEZDZNQWgrekJRKzlLckx2MnVJQ3lJU2pQeWtqYTZ0MGFDbUdj?= =?utf-8?B?ZzZxelNRYWFhWmdPZkZIc01oRGxRclZ0aytEMkdtd0NQVkFHZXdlVnhZMi96?= =?utf-8?B?SWpXby92cUlMTnZxWlRSdGdWSzFxaExLemFoR2t5bG04SDF0WjhhVHFQOHBm?= =?utf-8?B?dGZUVndlRFRQU1ExUnJBcXl4YXBMSWFveThlQTlxZlV6bTJ3bzAzS1FIZTFS?= =?utf-8?B?cHNnb21UaE93ZnI1cy92ZEpjY1UydDdabHpxSDlsU1M0MEQrQUg0OEVOWlA3?= =?utf-8?B?eXZuYnhSQXFzWWJvUFJ1SlRpdzdKS214TzBtK3lOeWFVVHR1cjhETEhVTUox?= =?utf-8?B?VkpKT2dIa1RUZ3FsMnVzM2luSXpCMlpsNVNmWHRkbEgwVHQ2UWttc1gvdmtq?= =?utf-8?B?VVc3Q1hkaUY5bStVMUpvSU40QWp2aVpzSjk2M2dia0trbmpSc2lOZXhYUUZ6?= =?utf-8?B?UU1haERwdUk4Q2tUNFR5cDdJSTNQOGtYTEoycXJJUWpZMkpVL05wUm9va3Vj?= =?utf-8?B?S2xIWHcyTnNUQjY2M0sxUGxGZHA4TzZhanA1YlNjNkIyUDZKaGNOd2lyZlp3?= =?utf-8?B?bitXUC9rRTZneC9Jd3lNR1luVDE5NHdVOGtpZjdnZGNVQlQ1djVicTBqV0F4?= =?utf-8?B?MUhrRjlZSk9Qb2s5VWY4akIwTXgvY0srMGRMN1Y1MnZpTkZzLzJhZ2lTTUlD?= =?utf-8?B?ak5IME9Kc1U0d1JiU0ZvTElTZDJoQmE3NVRTK1RiMzZoWElKRlFIZTJPV1N5?= =?utf-8?B?elk2bXplcHMwRFpneGdHY3FQSGZNaDd5ZmdtMTA2OFBTZDZvSTNkVGhHU2xi?= =?utf-8?B?SFhlamZwdlREUHVjNGhHZkY2amJPa3RzQjltMlVqMVI2OWhWTEU0d2pxRzB4?= =?utf-8?B?bXlWaDArWW1LU2tzdWxSbFZRSDhNWTBSUmVrWk8zK1hIUDAva0YzVkk5WCtm?= =?utf-8?B?Mk5ad3UzQmpNM1Z4c3dBSnFZMzlJVVNoalFrei9VWVUwbkJhR3JkUEk3c2s5?= =?utf-8?B?Y2JraUlNemtLSHNscS9iWWRQekliUEhDVXFTRjRPOEJ3RVoxT0o3b1ZFMUcz?= =?utf-8?B?TFBIaEUyMUhkM01zRGcxS1FBZnlNSnFwaFM1YVliWmZvdFZ2dmZnM1ZFTWtm?= =?utf-8?B?SHozTi95YWpPKzhyZHFYdWNlQkN5cXE1MkE0QlZVSTA1RENmakpwRWt6WWxX?= =?utf-8?B?Z1hiWThjSjlseGt4Z05LSjhTeEw1Uk9VQTNWcDNsN1psdERnVVBCQTc3TytY?= =?utf-8?B?WVVaaksxQnBHb3JxcmpNTWI5WFhvOFFFZFFiZXA4UHZXc0ZxQ3hoU2J1ZlRJ?= =?utf-8?B?ZlVrSFo5YXZqYzJvcm9FZXVZTklyV0xMR2IwWTYrTUpXZDNUOWd1eU5aQ0M1?= =?utf-8?B?bXNkNlFCTGpUNVZOUXBwRXg0ZnVYTE94MUhScW1NblBzYjVxOWk3UG42c3ZT?= =?utf-8?B?N2hWNi80VllCNnplSG1PVDhiSHBEbjJEUzVXbHJQZnZXaXdrZnBjVkx0cTYw?= =?utf-8?Q?zycNDY82s+HVVqYUj+12LJ5Sb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48321aa9-74cc-4549-5ff9-08dbd9228e07 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 08:31:03.9648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qyh1PqhSYPQHIQUHROEWNZvfuLTgmt+0rnp/DdYrX3fNOguKwMuqrZnyCGytXLPbTvjT9mPWip8//J8obZpEyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8002 X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.10.2023 06:50, Hu, Lin1 wrote: >>> @@ -5232,8 +5244,23 @@ md_assemble (char *line) >>> && (t->mnem_off == MN_extrq || t->mnem_off == MN_insertq)) >>> swap_2_operands (0, 1); >> >> Did you, btw, consider extending this to cater for UWRMSR as well, in place of >> the new construct at the bottom of match_template()? (I'm not saying it needs >> to be that way; if you decide to leave things as is, I may later see about folding >> both.) >> > > For this part, my current changes are > > @@ -5400,6 +5388,38 @@ md_assemble (char *line) > return; > } > > + /* The order of the immediates should be reversed > + for 2 immediates extrq and insertq instructions. > + And This pattern aims to put the unusually placed imm operand to a usual > + place. The constraints are currently only adapted to uwrmsr, and may > + need further tweaking when new similar instructions become available. */ > + if (i.imm_operands && i.imm_operands < i.operands > + && ((t->mnem_off == MN_extrq || t->mnem_off == MN_insertq) > + || operand_type_check (i.tm.operand_types[1], imm))) > + { > + i386_operand_type tmp_operand_type = i.tm.operand_types[0]; > + i.tm.operand_types[0] = i.tm.operand_types[1]; > + i.tm.operand_types[1] = tmp_operand_type; > + swap_2_operands(0, 1); > + } > > after match_template. Some generalization has been reduced to save on code size. > What's your opinion? Hmm, why this way, rather than indeed merely extending (without moving) what's there? (Anyway, as said, I'm not going to insist on this folding; if you don't want to deal with that right here, I'll see to make a follow-on change later.) Jan