From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by sourceware.org (Postfix) with ESMTPS id 2E6303858D32 for ; Mon, 3 Oct 2022 05:12:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E6303858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=martin.st Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=martin.st Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 2935Cpli023427-2935Cplj023427; Mon, 3 Oct 2022 08:12:52 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 54C8DA1437; Mon, 3 Oct 2022 08:12:50 +0300 (EEST) Date: Mon, 3 Oct 2022 08:12:49 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Mark Harmstone cc: binutils@sourceware.org Subject: Re: [PATCH 1/2] ld: Add --pdb option In-Reply-To: <20221003014313.28766-1-mark@harmstone.com> Message-ID: <26dfc8b7-e89d-9212-da69-b05044d2d8a9@martin.st> References: <20221003014313.28766-1-mark@harmstone.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-FE-Policy-ID: 3:14:2:SYSTEM X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mark, On Mon, 3 Oct 2022, Mark Harmstone wrote: > This patch adds the --pdb option to ld when linking PE files, which > augments the existing CodeView record used for build IDs by adding a PDB > filename. If no filename is provided, this defaults to the image name > with the extension replaced by "pdb". As I assume you're aware, lld's mingw port also supports PDB generation - and the description of this option also sounds like it's chosen to match lld's option for outputting PDB files - that's good! The testcase only seemed to exercise the form --pdb=, so I thought I'd ask just for clarity: I guess the other forms of specifying the option, e.g. "--pdb " also does the same - same thing for setting the option with just one leading dash, "-pdb=" (I guess it's a getopt feature that allows that as long as it isn't ambiguous with single-letter options?), as well as the form "-pdb=" or "--pdb=" for requesting it to set the default name? // Martin