From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 59FD83858C53 for ; Wed, 7 Feb 2024 07:51:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59FD83858C53 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 59FD83858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707292282; cv=none; b=uAOXb2JqW0QZPGKsht3liA9eU6gaTJb7vNdYKhZ7KnROud9kOBjJ4cZ5aYaOQfvNMUpriqGktq5XQUgrap4s1U546yOKb5yIu8zYTLsIxHYsKbHtdqr5sT2goZPwaLzXC7BbJeNcCCxrzgMI379MIiZ1pQO0CXjzUNoxViuYbtg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707292282; c=relaxed/simple; bh=6vpDN7XNXfHsC4mztegpB8BuhUvKnFg6nAZYxXe5hrk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=p7+/Jn3wXslR6j/dCNbyHgd/XM0tjRlPgqIYDOo4EXLurH6FIZMBHz5kmr8PPd/Y8EKp0yd7rS8Z5HWc2fk5hE1qIElBvKLLT2sNEUT7+88YP9VgHX0ntPi7HLHqgmGnmsbWDuC2Eaca0PtC3o2Z6zVqXbAopewvInFTSAE+IDU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40fc549ab9bso2535145e9.0 for ; Tue, 06 Feb 2024 23:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707292279; x=1707897079; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EJgPYcP7X8JvhiIdY3/aBo/axCCpiCqCv/nd/HGqr+k=; b=PfE17sC8eNv4NGW0k3VOvzHBqh4d8aKCDpXzRlitIjAHbq/gdSlICoI27eggFEY2A2 sRyv25We1JZmjmRpHm0D50jin3Ui4sw+XxtnfaWJo9025K2IClITVOVHPFOUp/+ePnho b6BaVM2skHtPJfuFw5thXYX73XU1yk+ujiMKzAQuQR4asxReYFo5Iaj24R9Hxg/6t59B qJDZohRIU987VowKZP3SNythQTkbuhz3DO+lxcm9qqzb0VSqQfYmsC9YQXzVU5CwYGmI 7Bcm4t5YJfmVasaKdTIumMNgA2fVPKfxL22tHjI8tyinFC6xDcK9m4cqNXkHQr3BMRGi 2tzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707292279; x=1707897079; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EJgPYcP7X8JvhiIdY3/aBo/axCCpiCqCv/nd/HGqr+k=; b=XsL+vUQGrVuHsYwp0WO6IzzW279idQEgLC57ltEehhRHEYRO1gEr4FTOpzt38m5WFI yBwSuyIrqXEcbBqZr+lq6VeV1cYrx/YycH8kOUsCAd907wG0C+f6nwoHj6guuXlIMo9g OGY3ajUeH3Z+xO+FGQd5Vej5462+aEX+N6urW8Hz+9zHePjUM5GHmWqbiWM8TzsNwJ2A Mnl4CH3FPZEb5nQV3ztnMzOlentdicR9bzfm9AuC+yPIdcQO6wzixF3/WmaqaISUA2Iy vq0HrvrLlVQQokqnmKgKKvhnqRlfGcEPM39cX8nHIZsWd1Y8g8NKslK874k+EZOu/nUu fcfw== X-Gm-Message-State: AOJu0YzxfUxVM57xYEQu6Coy3Is3psbkoS46gaUnKBakxRBLaAp0iiRL Baa3Zrv/QJC5/lRveLM/1oP+lhrq9hwhr3jJyC5UBuFk7YeO6r8eSf0/iROkgg== X-Google-Smtp-Source: AGHT+IG3kV02ftbXwhP3KwwwIJap4YckniLkLdZX9p3K8gjwg6vkjRO5tti1gHSrckDCi38GWLdnHA== X-Received: by 2002:a5d:668a:0:b0:33b:47eb:e08f with SMTP id l10-20020a5d668a000000b0033b47ebe08fmr2727617wru.11.1707292279027; Tue, 06 Feb 2024 23:51:19 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVnimGHjpOnzfdvfYE7ncK6bkWvjj6FHnygeBRQjcbObQqRPYCJ3QdV6rGRI8g0WLUAP1g+MLDtvV8cVoM= Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id j8-20020a5d6e48000000b0033929310ae4sm804363wrz.73.2024.02.06.23.51.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 23:51:18 -0800 (PST) Message-ID: <2721d4bc-e29f-4ed1-8fac-064fe0711029@suse.com> Date: Wed, 7 Feb 2024 08:51:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: Warn .insn instruction with length > 15 bytes Content-Language: en-US To: "H.J. Lu" Cc: binutils@sourceware.org, Michael Matz References: <20240205200028.219844-1-hjl.tools@gmail.com> <4b1c3da8-d218-460b-89e6-6844096ed393@suse.com> <533a896f-8eec-b73b-cb18-26240ad822fc@suse.de> <8059bdee-392a-b9cd-41d5-8dea538c957c@suse.de> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3025.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.02.2024 19:06, H.J. Lu wrote: > On Tue, Feb 6, 2024 at 9:05 AM Jan Beulich wrote: >> >> On 06.02.2024 17:28, H.J. Lu wrote: >>> With as_bad, assembler will continue to assemble, just not generate >>> an object file. We ran into this with APX. Not everyone checks >>> assembler warnings closely. It led to mysterious crashes. I am >>> not against it if someone else implements an assembler option to >>> turn this error into a warning. >> >> But it should be the other way around: The compiler could pass an >> option to promote the (default) warning to an error. And if you >> don#t pay attention to warning for assembly files, you could pass >> the same option as well. Without harming anyone else with anything > > People who use/need instructions > 15 bytes belong to a very small > minority. If they want to do it, they can use .insn or use binutlls 2.41 > or older. The default assembler isn't for them. No, staying on an old assembler isn't viable. And minority or not, you have to face it: In the present discussion it is you who represents a minority. As such I'm even inclined to suggest that your earlier patch wants reverting, on the basis that it was put in despite there being disagreement. Unless you soon come forward with an incremental change undoing at least the worst of its effects ... >> that has worked before. > > The reason that we didn't run into the size limit before is that normal > instruction usages never exceed the 15 byte limit before APX. Didn't I earlier give examples of "normal instructions" that have this issue? I don't see anything "not normal" in insns using e.g. segment or address size overrides. The impression I'm getting is that the problem originally was of no interest to you because initially it affected AMD-specific insns only. And the subsequent appearance of the same issue in HLE insns then was mentally put off by you for being "too exotic" (and I partly agree that _there_ one may indeed consider the example contrived). You only started caring when it was an Intel extension which was noticeably affected. Yet that's not the position you ought to take as a binutils maintainer, imo. Jan