From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 173593858D1E for ; Tue, 8 Feb 2022 13:11:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 173593858D1E Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-25-KVYLPmLNPACBgC795djBYw-1; Tue, 08 Feb 2022 14:11:01 +0100 X-MC-Unique: KVYLPmLNPACBgC795djBYw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C1DAFrTy9bKl+/OMMoDQdDvnaiESreTIarNb7XjyidBNzOVI1wiunkZLYY1z+l6vBMVVMcVr/B1fp0XRpSRolxmzXkTlLDbVbbh0L3sZUB5QW38RW/Y5rQH6dbnU8dVfImfNuwxtYSMSBh6TX/u/BY5zq0ovvFflsa7SKVV8TM0/jGJQGCXMvjTGu5e5N27jgGQWukLlrdY73rMSKjTiklXpBO7ncm4uYWzRhA7aSDdD1cz2ugUZrIcVGDhmFpuNcO7YAF6ABmLSx0k7cGDYTlwZdEyOsytELtZt7FBLCAFGb7NfAqfme8dqgMbc6xGpWqafVVb5fW1MEXGF+axGDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wLkOIdHo9pbhBHa/zMRBLQTX8bV3EdS19jJELHBEZug=; b=f9O8sBzfaXFz0nCYdGoq4KOa4Sgo7n0wpy2B+QLNDJTMYAjjR+2w7KDeByPHhn8i3ILLl00X1XxmFwU9BSx7jJDSnWt7sfjDRpVnN4Q4IBg6BBdarp4JG9/2B7N8vkx+l461kGesKi2nndx6VYi5HaFQ5jPepWpC1juhreUqioc6lgdh1QjtSYkBnDTQpIsE8EOvwwbl9h699BBLluorHWJHyi4vcCxDxOlZjFElarkKJiNkVpoPeWS3cdn+czZvMe2F4dwxtA+4fPTR4LOdN2i9DSADbR5sZUTBduoOZ2d3SgEO4LNvwoxVlZlg0TNxKhp+uw0EpVL9KfwQZ1krbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by AM6PR04MB5302.eurprd04.prod.outlook.com (2603:10a6:20b:7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb 2022 13:10:59 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022 13:10:59 +0000 Message-ID: <272c580b-7428-3cc6-9a21-e9aa802eeb90@suse.com> Date: Tue, 8 Feb 2022 14:10:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] i386: Allow GOT32 relocations against ABS symbols Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20220208000322.4108601-1-hjl.tools@gmail.com> <4785d6f1-cd0c-2ad4-9a13-6a05f6557b69@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0053.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58c1cf2f-b62b-412c-8a6f-08d9eb04732b X-MS-TrafficTypeDiagnostic: AM6PR04MB5302:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wtuqPbajWnojHuvrm9GsIvWnh4ekzfmE7Gx+9QSJC9z5IgIeNtMFwG8y/54KHqSmYqnp57YEymT+cBeAGaTzt2RvqlFCJizq0AHXpvILKLMbAPiVXB0RCUCB/0wFf/jYzhRUgLrXw62hC/0uWCpVnu1Ymk0ayfc4wktDAkDpl/ATLqr6GjSWQMgJBMD8j8DDwgOWP6hwGzwExpz4hDFRXHAQKhZIMXpVgew22JlTCxAcBdd/r5ZcBk/BU3JVaoQksVDhzfXe2GBdu5ba0pnbARbcAdZUnzP4GF4A3W9mkvbF5Pd9Ud57yp8JdX0hT7X/PFbDKT2lD9gylGmqPVkvjn5WiHsSvFJMBSP6tIFiSJngyYsgalDPmhLgtUqGZ50HEsEKGf5lWWb9GMvI58fUV1rM4vhwhD4sPlEFX1Z8/RrTrzKThUHRfsx2xRvi6fTlCEW56ulySTRQXCgpVQMoGyPEGkJYXg6eeg7br3ODxRmRSYuPiTU0NMWsiL0LLpzxnq/4+MThjytTz+7BTTL/fbmLMAiFuG78IvqW+vJZpfh6FPwk/EMamyz1tTnOEGuNlLFJbtBUB/PhjpjjZHqf8GENHetmLsYOgMzlUkR9Lv93AsyyWXU7+wtjiP99rpaBjzptZ1mNv4lf1y5WxVKO6fhlycI87cYYiKwX30+nZh8YOyKaWlvyyNPFZHz194c10MoRlOU+X7ZrKcUXUi9FKeRgb7W24Xkr2+dxROnpN9w= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31696002)(6486002)(5660300002)(66556008)(6512007)(66946007)(4326008)(8676002)(6506007)(83380400001)(66476007)(31686004)(36756003)(53546011)(86362001)(2906002)(186003)(38100700002)(508600001)(6916009)(316002)(26005)(8936002)(2616005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzNTZTUrSTVTREFjQWw4S1JtWFN2dHdjSTZzeWp2cDUrZFF2VklMaklOemJU?= =?utf-8?B?WU1NZlJTaVJKREZWUUIrYUxGZGNRdHErZ24yQi9zWXQ0WnFkbWR5aFlzZlFz?= =?utf-8?B?ZktiOFhPbXVibHo2aURoRFdtcGd0R3htYzc3eGdjVEpqYzk2dEtzd3RmSUVW?= =?utf-8?B?NnZVbjRtT2FINktZcHZvMWN1ZnRrcEdsKzRSb01tKzBuSjF1NENYK3lLY21X?= =?utf-8?B?Y2k1VnFIWDB0SDZkc1ZBNkh6RjlWTGpIelk3amZSM3JCRGtOaFRYZkVtL0Rt?= =?utf-8?B?NXpLUnRvdUJaUjJmbUFwdVA1WTA3MGx2TXh4bkJhSHFYWWpaMkdUMFphWkJw?= =?utf-8?B?aXFBcjBTdFhvbmVPRWd3WEtRVWNrL0JPaExOdG8wWk1kRi9RVFB3R1hrcW91?= =?utf-8?B?TzE5RCt0Z0dTZXhXdFdRSjIxY3p0bjFKWk9WbUQxM3hHOFM2WExsdkcvM2h5?= =?utf-8?B?dVZxSnEwenZ4OWRHU2pKL1NqdUNZeGpyb210YjNzZDRoTXhmM0F0VjdMZ21D?= =?utf-8?B?ZU9jRU5vNDBON2JMNkNLTGJwRkJFSGVocWNSV1dkQ0UvS3FlY25PMjJyLzQ2?= =?utf-8?B?bXgxZkgzcndhZDc2dmIzQ251MmlzSEMrZCt3UldRN1Z0K1lhWUx0R0s3djZi?= =?utf-8?B?L0VISGd1ejRMaEFtdGtUMi82bzBQSEhDOFFSTHZ6ai9jcFlGeEkzbEJRM3h0?= =?utf-8?B?aDczUTUraDRNV21VOU82dFFIaDZNQktzSDZ3NDZYc0k2TWZQbDlIRStJcVU5?= =?utf-8?B?VDhNcjRIbHc3S1NTL0h0VDVGakVGYm41d3NWbEtJbkFUa1Z3aktmTXU1V1NP?= =?utf-8?B?Mi9tdGNKOWZCaDNYc2VXS0RZdUdseGh6Sk9ET2xJVVk0LzBHR1JqVmZ1Z2h3?= =?utf-8?B?MDV0UHFCWHRPN0hBN0c3LzF0RUpwcG1EeFIvS0syZXlUbXNvVERIZ3JlNG5F?= =?utf-8?B?SWUxbW5uWnZpY2xqZTNtT2QxalRRRGEvMXlyUzQ3ZzZjeXdwS0RhRmVKNi9o?= =?utf-8?B?dHJDR296NDBvK1RpdGlJRGxrZldmQ3RIQUNWL25lbU42VUhNYkhIeXpYcTBL?= =?utf-8?B?eWZLYVk5TEkxa0k3WndXOGZuM2tGSnVhNkVlUWJDWlFsWS9KcFhydlVnQmpz?= =?utf-8?B?SmszQlk2dTlnWGxhYTI3NHFpNE15YVB2aU9MUnFVVDVZbC9zR3hOTjJST09p?= =?utf-8?B?SHBYY0R0OG5QY3hWWHNpeHdQUXZ6ZzBDdkRaOE9FUW82SW9SRjJQNUdrWHo3?= =?utf-8?B?OHNPNWN3YWNISGNVR2Q5enpVL3ZtU3hiYnkwT1M1K1lBWEp6Q01BU0VXOGZO?= =?utf-8?B?cWloaThqL0UxOFlhZDNJUXZTWVY0MEpYWTI1UlBwM0hZZHNsM3lPQitMTUR4?= =?utf-8?B?QUplcE1KcXQ1RlU4a0lkTUZ3YkZqRUgwQXU2eFVLTnZzaUhYVDNVOVhOUHAr?= =?utf-8?B?WjZSS0dTQnVHQ2krKzJGbWRuUFdOZ1ZhNGxObkFHZW9SMkVmdW9HcjVYYlJq?= =?utf-8?B?QVB5VUJhZjdISDRzWjJHZncrQ1VzbjBCWDdaM2JRTmZZZ0daa3hkZ3dwSnFq?= =?utf-8?B?NUd2Skg2c2hqRGw5bWJXMi84L0JuTElGNUQzQVM5V09XOWdjcHlsOW5FRlQ3?= =?utf-8?B?T20ra21oOWVRT0Fkc3hnVzNoM3UrOFBUaVlGMm5SYXU2Y1RmaWpPTXNBU3FH?= =?utf-8?B?L09lbWYrdzYzSk81dUU1amVlbDdPMmhpVTU5WGJIUXhaUWgxNUlwTEtJNHV1?= =?utf-8?B?a3p1SjVnUWNtYWhncGdyMVBGR28xWHE5a3ZSbjV0bHF1K0REZ005d08wN2Ro?= =?utf-8?B?emUyQ2kvYVNQOHIxOVJPZnI4bzBsNWVxSXJha29NaStGdUtWY2hqM09Gc1BS?= =?utf-8?B?Uzl3aGtoQXBBOWJBdTV0cHJtUm1mWHcxYjBNM2pQbDRsejRJanViRjNVanhV?= =?utf-8?B?RzcwUDdyaGd3M1RlRWtVeUdRTmRZV1huc01GM2djb2U3Qm9qditqa3VHSmdR?= =?utf-8?B?Zy9EanFWSDJzeEx0RDFweEdFUm1GcVYyb1dSdlJwN3p6UkVYcGZnOVNrWDVX?= =?utf-8?B?VGVvWWNFYW85U3dCMGlaSUZQYWRRK21uck1YenpjRURPOFBBSVRNTW9ja3Vt?= =?utf-8?B?ZzF3Rkx6aVgxTTVHVU5KaUYxTVA0bmNJSW54M0phVXdtN2pXV1VXNENQSDVO?= =?utf-8?Q?zki51cinKsaRJwoEA3ubdYE=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58c1cf2f-b62b-412c-8a6f-08d9eb04732b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 13:10:59.5984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w2Qa8/5brN7KrWmhWnDlTiavkq8E+rZti8MGpsV7sceFCEMzUKuOtkbANwyqdpTHACPtrKHNophVeGWStcBbZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5302 X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 13:11:09 -0000 On 08.02.2022 14:02, H.J. Lu wrote: > On Tue, Feb 8, 2022 at 12:37 AM Jan Beulich wrote: >> >> On 08.02.2022 01:03, H.J. Lu via Binutils wrote: >>> GOT32 relocations are allowed since absolute value + addend is stored in >>> the GOT slot. >> >> Before permitting this and with you specifically mentioning addends >> here, I think it needs to be clarified what ... >> >>> --- /dev/null >>> +++ b/ld/testsuite/ld-i386/pr28870.s >>> @@ -0,0 +1,6 @@ >>> + .text >>> + .globl _start >>> +_start: >>> + addl foo@GOT(%ebx), %eax >>> + cmpl $0, foo@GOT(%ebx) >>> +foo = 2 >> >> ... missing (here) variants thereof actually mean (and whether the use >> of addends actually works as intended): >> >> mov $v@got+3, %eax # bogus, meaningless operand >> mov $(v+3)@got, %eax # wrong (gets treated same as above) >> >> Comments are my own, preliminary judgement. > > GOT relocations should only be used as @got or @got(%reg). > Other variants are undefined. Which raises two questions: 1) Why did you say "absolute value + addend is stored in the GOT slot" in the description? Where would an addend come from if it can't be specified in the assembly source? 2) Why isn't the assembler at least warning about such undefined uses? Jan