From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id E9369385734B for ; Tue, 17 May 2022 12:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E9369385734B Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-26-ZY1cp3ylMC-AyLQ3A7stuQ-1; Tue, 17 May 2022 14:00:13 +0200 X-MC-Unique: ZY1cp3ylMC-AyLQ3A7stuQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCY+n3WIbSUpsAcu1kQGmDTy9LmUQjLJW1p12JsfQQCaJCzArZNm+KefihuiwH9yFJrwmNw9Mr1X+52DIu9/4zCqqyFyaGC2EhshKmk6qUYH5eLdmaIECIbZgVrEzVMc4cnS+C/FbsktjS+QzPy8xvyYskC876ei8PIn9Iqb+Vq0PUPi7X3wPaNiLIU48ECoRaI90FRj733h/wW47E1IFk0a9MqQ6oPGLF0ZChbXP+NKMKL0Yh5xEc9X2G97mbG2jzAID9rtaIpFKi+sfRXCodE+aFTVkwK3Nf1DMaWsJXLQvm7U6gKQZcPYU+1jnAfmu+XvBDHJXsQibrKIowhpDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MYTVQ6how+kRZy1LI+ET9KWv/h+yC39r4K8OaWRW6aA=; b=D6ByB47DpGsVP6CPcbxRaFazscuhhfXIo11KQBB1qW9/BfVGhezQh2aFWS35KdWwIR9epZTlSXL5MpzF5/BfMliU2k+g6Md5lfm0Q5Ek7dOYoPEZ+wTh7cKo/HpotCsm2vakysxRq+a4KvjxCVpV6jp6Cu+lgOqcmBvltEG/TjPK2uMXLs3a3TLm7zjEUIYfi15xdBHFxwHlqjcrWezkJsQYCnbdmH3TxeWr1e6Iv6uZT9RY1vZ70rj+CeMSfQeKxbRgNIyx5cTRSi+nCgcQlo5Ahd5ckvP0rAUIkVbTUMgfs8owhLJpiCVUKALE5v76Gz2710FUHkf8uWkkkernxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7847.eurprd04.prod.outlook.com (2603:10a6:20b:2ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.18; Tue, 17 May 2022 12:00:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::91b8:8f7f:61ac:cc9b%7]) with mapi id 15.20.5250.018; Tue, 17 May 2022 12:00:12 +0000 Message-ID: <274695c3-fcaf-9af6-e6be-53c42568225f@suse.com> Date: Tue, 17 May 2022 14:00:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 0/5] x86/Intel: AVX512 syntax enhancements Content-Language: en-US To: "Cui, Lili" Cc: "H.J. Lu" , Binutils References: <26c648e6-d76b-052e-6392-48265a859a7c@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b4ad658-b238-4835-9be2-08da37fccc12 X-MS-TrafficTypeDiagnostic: AS8PR04MB7847:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qgr7Y53SWUITjldRQeQ9m/xiDN2b7tTZZCcTTHqG+wNZUosoPsaY5iB+LSqNONSGlPJErJLpCI/It9yaqRa7pFnsgHv/SsluXZmxltmV40Ag4Q+asJsVZxxg9JpR1YjcXoAZCwTyk2VOHaQ25jGHabNGYSdJ5HZN/5yVdULWLoUw5n7WqbGqktB2CMENlgCzCgqnv6/9mWNINusKjTUqW54kG21+TlmnBxGJn/b/JkijpMf1L6jFA0U//Kb8VlEDMsUckJFCLyPEiMOmFOb3XpgxTdtV68aUAmsGS+N9l3uSOOLPNjDtAVIUV3+aIgAkiwO21WaFFvfcnfRdWCslVryCJSn1RSLPD4foH67kZaJ8diK5OnajY9AoOdEFyiSWmHq729Lsfu2PXaRGYzymZN1/bssjwFtLHOuhJHyFVS0oGOGvs5DKdLwD3iDeeHzy64vrh+jKF1OUFCSe1KNWQ45EA9t/SoOxvRTWoWl6A2wBDap2/3nZ1rfMIjll7wrT1kQp0nejCtaMegRaIFX0chv+fPqt2YVOMD3eCxs+Bx8e7IW6DIZAFIT05PLEPWDqACOovtcZavAZqAnGfTy6/vChG/G8niP+av5Cve70QjQWFyydmTgBRYXJ66RHS5iGat5eWiuKTT26ypDKa99QntWd/63LBmAUghgfzA7n5l6Fn8DvarBcM6mErSZkJeIVX7gejUqoK/S41V88EBMpRL7I8efl1b1y9NOgugQC4iA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(86362001)(38100700002)(26005)(53546011)(6506007)(31696002)(6512007)(508600001)(2906002)(66556008)(6486002)(4326008)(8676002)(66476007)(8936002)(6916009)(83380400001)(54906003)(5660300002)(66946007)(186003)(2616005)(31686004)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STZnOWNrSkdTZWZVK1R2Ky9BQjk0ZmRUMTYwWEJKY1E3MjB4cjNnRkVMRE1Z?= =?utf-8?B?ek10cUZ5OTQyQ3haQjJFbkFML1Y1aFp0SVRKWjJjY0wxMjByMDdnWkR1WjNB?= =?utf-8?B?R3F5V1E5czY0ZzFyOVNPaks5VWZxNUtXVEorUkNGSnpmZjdodUQ1NlhYK3l6?= =?utf-8?B?eUR0MmFiQ3ljWVF1WlY0SFcwaDY0MHFpMXZMT21SMWZaWEttQWtQWXhSMTVX?= =?utf-8?B?U21HZ3cvMDEwdXNnUzFodk1qWmJhQXhYclBJenl2RmxMTkk2V0o3VkdhU1Ro?= =?utf-8?B?aHltU21EcnB4NklzakY5UXB3OFRPbDNwRXVOZjdxNHIzcE01N2x1d0JQbUJL?= =?utf-8?B?WG1mRndmTlZNTWxUU2JFSE9GT3ZTdmNjaWZySmE5SWpGNTJGQ2s4aFl1bGxv?= =?utf-8?B?bm1QL1h1dXJiVmF5Q0wzcms4SmpiL1ZJc0piSzlGQ0NySnJNd25JWUJoQUZq?= =?utf-8?B?dVM1ZmN4SWFpY2drc1UwUERIak1PMGFlSkZjdGdZK0o1T1pWdlRqTit0WGh0?= =?utf-8?B?c1BxblB3dnRkdkpEMHBFOGJKc1RqcjVHQW54SnFZMEJjV3l3Slo1WU54eCs1?= =?utf-8?B?OWs3a24zTGhKTThMdkhWeWdtV3FoOExjUHlXQkYzcDZqanVFeDlLOVVHRXNi?= =?utf-8?B?eHdDSjZJcjc2MlVkSDBDb2M2cDV0ejk1SWhRM0FDWDFma2puSHNmNWZkTCtI?= =?utf-8?B?WW9oV2hCOFdvNmw3YVQ5QVNOWXdFKzRxZlJCeHN6cHFNMFF2c2pCQjRaQUFO?= =?utf-8?B?Q2R3cjV5SUtuVXc1TW5CK1JIQTRWQW1xdzFiQ3BTc3ladVFUZTNlR2pOdDdC?= =?utf-8?B?Ri90dHhsck8rZXp3ME5ZTEV2VlB1cmVLOTU5Vjg3bnU3NC9VbkhlcFNtZyt3?= =?utf-8?B?SVBGdTZEMHpZdm5mdlpNWEIvYm1HRE9IWTAxcGcvVjNEdTJSbWdackpWT0U0?= =?utf-8?B?M1V6eFJVQlNGbURMNEFGR0NySmw4QTYvNjFHYjM0MnhIUnh1REVBSzBEK1JF?= =?utf-8?B?amNTaHBialFjZ0hYMEwwS1UySktsSThDeG4xS2hFcXZ1bTlzZmJ1KzZrYzcy?= =?utf-8?B?aHAzTEVJTHQ1QUdIVyswOFhQQjdtSFR0TlZGOXQzNkV2M0FQSnZCUjBMRWdQ?= =?utf-8?B?NlVHbEg0TXdvTVlKNkQxZStRUWIxVU1sL3V4T3RjV2V4OVc4MVlNU0s1V1ln?= =?utf-8?B?a3pmUS9kWi82V2JNd2ZYellyOHhpTWpESjd2RWhydlQ3UjNzTmphelNudkN3?= =?utf-8?B?bDBubkwxdUQ1Y3NoMlhJRHFla25Qa2tqYjJZUUpmbzlqemVsSnRHN25DYjIx?= =?utf-8?B?SDFERWdYaTFEMUNQSDhDdEt4WjM5dUEzRHhxVjNXcTc0ZERhcXlYVWV4NjA4?= =?utf-8?B?V01LU3drb3E5ZER1T0pCc1pzeDl5VnhuYlFHNzczMmdxVEx0aHRqV1gxNG9a?= =?utf-8?B?V3RwaVJkbTl3MDZBSzgzOHo5SzJYOHlmTlZyTFpUWjYwRm5YdUticW83N1ZE?= =?utf-8?B?TlZmZllxRFhjUWwvbGtBMnV2QmE4a0FBL1NINDJucHZpT0FhZUttVUZzZVVN?= =?utf-8?B?NUg2d1Fhc3BIY2dOL1diejJUbVBuaTdWZklIVkZGRno3QjRadUhJYWoyRWRm?= =?utf-8?B?T2VPditGR1pkNVM3SXZoS1ZncmdzVUhqbU4vZkZaeUQ3eTVaY3Vua1lqbnpz?= =?utf-8?B?aVNBSXJJQU1KWHJKZWdIQXlsYmNqNVZVN3NkUzdDdUMyeGFTVUVpdHc5RHhD?= =?utf-8?B?RndHYm1keE11YVNyekpXTHhvaFZzT1FXaGU5bFdFZHB1UE5GWDk2MmprU2JJ?= =?utf-8?B?TFE4TnYvVFRkTWNyMXZKVXNUc2x5eG9iUFFOQnhwT1h2dkxRREF6WVhZWWhz?= =?utf-8?B?NTgxWUNOQU1leWtxL0NBQjlWSzFXeENrZEFodkUvQVFHRVFRd2RUdG1UVk9P?= =?utf-8?B?WDU1b1JwUUYvTFA3OGZIaDdFM29sS21kMmp1QWNYdkp0NmZKUXRrNmNzWk9H?= =?utf-8?B?bzA1NmxoUldnTnNrQTYyQUZIUVBOZFlrV2tpNjRzdEpXd3FzaXdxakZQTkZF?= =?utf-8?B?TjJ6bm1yamg4am44NkdTVU1VR0VVM1d1M1lPaFhRbUpSckNuR1pRRXNyeWtv?= =?utf-8?B?VWwvQ01tQ1FtRjd2L051VXJteG1haTNhQkpuMEhMVGFjZXhuTFZWYUpEOWo3?= =?utf-8?B?dmxBT3hyK2pFYlJ1dlkzWEpheWlEdUpHUTNKR1htSmpuVzhERUVVSUpJZk03?= =?utf-8?B?aytvWllhTnlUNDBsWFhsaU9SSnpmSkZoR1M3YjFqTXdsQTFJUy9XMzYyRkFr?= =?utf-8?B?QVlQRUpuUE5WSlpXc3RMZDJ1Rk1jQks3TkVOZzVSeUdweVl1WXIwUT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b4ad658-b238-4835-9be2-08da37fccc12 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2022 12:00:12.3279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S6X7PY+it8QK6FtFCevMtZa1/NqhbGoYe6MSKFpFxsV/jFH3eFTDxxZXAsItpQDXmW3uzCv4arIHYYHjQ8osfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7847 X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 12:00:19 -0000 On 10.05.2022 04:37, Cui, Lili wrote: > >> -----Original Message----- >> From: Binutils On >> Behalf Of Jan Beulich via Binutils >> Sent: Wednesday, May 4, 2022 7:45 PM >> To: Binutils >> Subject: [PATCH 0/5] x86/Intel: AVX512 syntax enhancements >> >> As pointed out long ago already, what gas accepts and what objdump emits >> isn't in line with the SDM. Finally I also happened to find mention of this in >> MASM documentation [1]. This series extends (gas) and converts (objdump) >> respective support. As a nice side effect, a few hundred insn templates go >> away from the opcode table. >> >> 1: Intel: adjust representation of embedded broadcast >> 2: Intel: allow MASM representation of embedded broadcast >> 3: Intel: adjust representation of embedded rounding / SAE >> 4: re-work AVX512 embedded rounding / SAE >> 5: Intel: allow MASM representation of embedded rounding / SAE >> > > Hi Jan, > I reviewed all the patches in this patch set, Thanks. > I have only one doubt, the others look good. > > 1. If we use BCST instead {1to*}, it cannot directly reflect the broadcast number. When the register size is zmm, but broadcast number is not the same. > > -[ ]*[a-f0-9]+:[ ]*62 f5 54 58 58 31[ ]*vaddph zmm6,zmm5,WORD PTR \[ecx\]\{1to32\} > +[ ]*[a-f0-9]+:[ ]*62 f5 54 58 58 31[ ]*vaddph zmm6,zmm5,WORD BCST \[ecx\] > > -[ ]*[a-f0-9]+:[ ]*62 65 7d df 5b 72 80[ ]*vcvtph2dq zmm30\{k7\}\{z\},WORD PTR \[rdx-0x100\]\{1to16\} > +[ ]*[a-f0-9]+:[ ]*62 65 7d df 5b 72 80[ ]*vcvtph2dq zmm30\{k7\}\{z\},WORD BCST \[rdx-0x100\] This case is clearly disambiguated by the destination register. What I think you're worried about are conversions where the field size shrinks (e.g. from 32 bits to 16 bits, like in vcvtdq2ph). In this case you will note that for the purpose of keeping things unambiguous the disassembler will continue to emit {1to}, and the assembler will continue to require that extra bit of information. > 2. Just remove the last comma, it's ok for me, I remember FP16 has an instruction with {sae} on the middle position for the ATT format. But the intel format is placed at the end, I don't know if there is any problem. > > -[ ]*[a-f0-9]+:[ ]*62 f5 54 18 58 f4[ ]*vaddph zmm6,zmm5,zmm4,\{rn-sae\} > +[ ]*[a-f0-9]+:[ ]*62 f5 54 18 58 f4[ ]*vaddph zmm6,zmm5,zmm4\{rn-sae\} > > FP16: > vcvtusi2sh %edx, {rn-sae}, %xmm29, %xmm30 > vcvtusi2sh xmm6,xmm5,edx\{rn-sae\} Well, yes, this is not only not a problem, but intended. See how the SDM places the rounding/SAE modifiers. It's also not FP16-specific in any way. > 3. This can reduce the templates size, it is good to me. > > -vsubsh, 0xf35c, None, CpuAVX512_FP16, Modrm|EVexLIG|Masking=3|EVexMap5|VexVVVV|VexW0|Disp8MemShift=1|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { RegXMM|Word|Unspecified|BaseIndex, RegXMM, RegXMM } > -vsubsh, 0xf35c, None, CpuAVX512_FP16, Modrm|EVexLIG|Masking=3|EVexMap5|VexVVVV|VexW0|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|StaticRounding|SAE, { Imm8, RegXMM, RegXMM, RegXMM } > > +vsubsh, 0xf35c, None, CpuAVX512_FP16, Modrm|EVexLIG|Masking=3|EVexMap5|VexVVVV|VexW0|Disp8MemShift=1|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|StaticRounding|SAE, { RegXMM|Word|Unspecified|BaseIndex, RegXMM, RegXMM } I'm afraid I don't understand what you're trying to tell me here. Are you asking for some kind of change to be made to the patch(es)? Jan