From: Nick Clifton <nickc@redhat.com>
To: Faraz Shahbazker <fshahbazker@wavecomp.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [PATCH v3] ld: Add --no-print-map-discarded option
Date: Wed, 10 Apr 2019 15:57:00 -0000 [thread overview]
Message-ID: <27829deb-fe7f-a183-5c88-c70f355e2d46@redhat.com> (raw)
In-Reply-To: <20190402201735.285064-1-fshahbazker@wavecomp.com>
Hi Faraz,
> * NEWS: Mention new option --no-print-map-discarded.
> * ld.h (ld_config_type) <print_map_discarded>: New field.
> * ldlang.c (lang_map): Conditionally output discarded sections
> in map files based on configuration option.
> * ldlex.h (option_values) <OPTION_PRINT_MAP_DISCARDED,
> OPTION_NO_PRINT_MAP_DISCARDED>: New.
> * ldmain.c (main): Enabled print_map_discarded by default.
> * lexsup.c (ld_options): Add new command-line options.
> (parse_args) <OPTION_NO_PRINT_MAP_DISCARDED,
> OPTION_PRINT_MAP_DISCARDED>: New cases.
> * ld.texi: Document new options.
> * testsuite/ld-gc/gc.exp: Add new test.
> * testsuite/ld-gc/skip-map-discarded.s: New file.
> * testsuite/ld-gc/skip-map-discarded.d: New file.
> * testsuite/ld-gc/skip-map-discarded.map: New file.
> This is corrected version 3 of a patch posted for review few months back,
> but not committed due to pending copyright assignment. Somehow managed to
> reverse the previous version before posting.
The patch looks good to me. Once the copyright assignment is in place
please ping me and I will approve it.
Cheers
Nick
next prev parent reply other threads:[~2019-04-10 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 16:03 [RFC] [PATCH] " fshahbazker
2018-08-01 14:56 ` Nick Clifton
2018-08-01 15:04 ` Faraz Shahbazker
2018-08-01 16:01 ` Nick Clifton
2019-04-02 19:58 ` [PATCH v2] " Faraz Shahbazker
2019-04-02 20:17 ` [PATCH v3] " Faraz Shahbazker
2019-04-10 15:57 ` Nick Clifton [this message]
2019-04-10 16:19 ` Faraz Shahbazker
2019-04-11 10:54 ` Nick Clifton
2019-04-11 14:05 ` Faraz Shahbazker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27829deb-fe7f-a183-5c88-c70f355e2d46@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=fshahbazker@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).