New x86/PE gas testsuite failure: i386 inval-crc32

New x86/PE gas testsuite failure: i386 inval-crc32

[Nick Clifton]

Hi Jan,

  I am seeing a new failure in the gas testsuite for various x86/PE
  based targets:
  
    regexp_diff match failure
    regexp "^[ 	]*23[ 	]+crc32  ax, ax$"
    line   "  23 ???? 909090   	crc32  ax, ax"
    extra lines in dump.out starting with "^****  Error: unsupported instruction `crc32'$"
    EOF from /work/sources/binutils/current/gas/testsuite/gas/i386/inval-crc32.l
    FAIL: i386 inval-crc32

  (And similarly for the x86_64-inval-crc32 test for 64-bit targets).
  
  This turned up in tests of these targets:

   x86_64-pc-cygwin 
   x86_64-pc-mingw64 
   i686-pc-mingw32 
   i386-pc-go32 
   i686-pc-cygwin 

  Could you have a look please ?

Cheers
  Nick
  

Re: New x86/PE gas testsuite failure: i386 inval-crc32

[Jan Beulich]

On 21.01.2020 12:31, Nick Clifton wrote:
> Hi Jan,
> 
>   I am seeing a new failure in the gas testsuite for various x86/PE
>   based targets:
>   
>     regexp_diff match failure
>     regexp "^[ 	]*23[ 	]+crc32  ax, ax$"
>     line   "  23 ???? 909090   	crc32  ax, ax"
>     extra lines in dump.out starting with "^****  Error: unsupported instruction `crc32'$"
>     EOF from /work/sources/binutils/current/gas/testsuite/gas/i386/inval-crc32.l
>     FAIL: i386 inval-crc32
> 
>   (And similarly for the x86_64-inval-crc32 test for 64-bit targets).
>   
>   This turned up in tests of these targets:
> 
>    x86_64-pc-cygwin 
>    x86_64-pc-mingw64 
>    i686-pc-mingw32 
>    i386-pc-go32 
>    i686-pc-cygwin 
> 
>   Could you have a look please ?

I'll take a look, sure, but
- I didn't touch the source of the test at all, so I don't see
  where the 0x90 (NOP) bytes would come from in the listing all
  of the sudden,
- I think in general test cases shouldn't be as fragile, and
  there shouldn't be a need to add funny alignment directives
  (I guess that's what may be needed here, based on prior
  experience); such should rather be taken care of by the
  framework.

Jan

Re: New x86/PE gas testsuite failure: i386 inval-crc32

[Jan Beulich]

On 21.01.2020 12:31, Nick Clifton wrote:
> Hi Jan,
> 
>   I am seeing a new failure in the gas testsuite for various x86/PE
>   based targets:
>   
>     regexp_diff match failure
>     regexp "^[ 	]*23[ 	]+crc32  ax, ax$"
>     line   "  23 ???? 909090   	crc32  ax, ax"
>     extra lines in dump.out starting with "^****  Error: unsupported instruction `crc32'$"
>     EOF from /work/sources/binutils/current/gas/testsuite/gas/i386/inval-crc32.l
>     FAIL: i386 inval-crc32
> 
>   (And similarly for the x86_64-inval-crc32 test for 64-bit targets).
>   
>   This turned up in tests of these targets:
> 
>    x86_64-pc-cygwin 
>    x86_64-pc-mingw64 
>    i686-pc-mingw32 
>    i386-pc-go32 
>    i686-pc-cygwin 
> 
>   Could you have a look please ?

Here's the patch I'm about to commit.

Jan

x86: testsuite adjustments after commit 1a0351246a5c

The odd behavior of certain COFF/PE targets makes necessary some
mechanical adjustments.

gas/
2020-01-21  Jan Beulich  <jbeulich@suse.com>

	* testsuite/gas/i386/inval-crc32.s,
	testsuite/gas/i386/x86-64-inval-crc32.s: Add alignment directive.
	* testsuite/gas/i386/inval-crc32.l,
	testsuite/gas/i386/x86-64-inval-crc32.l: Adjust expectations.

--- a/gas/testsuite/gas/i386/inval-crc32.l
+++ b/gas/testsuite/gas/i386/inval-crc32.l
@@ -43,3 +43,5 @@ GAS LISTING .*
 [ 	]*21[ 	]+crc32  eax, \[esi\]
 [ 	]*22[ 	]+crc32  al,al
 [ 	]*23[ 	]+crc32  ax, ax
+[ 	]*24[ 	]*
+#pass
--- a/gas/testsuite/gas/i386/inval-crc32.s
+++ b/gas/testsuite/gas/i386/inval-crc32.s
@@ -21,3 +21,5 @@ crc32  ax, [esi]
 crc32  eax, [esi]
 crc32  al,al
 crc32  ax, ax
+
+.p2align 4
--- a/gas/testsuite/gas/i386/x86-64-inval-crc32.l
+++ b/gas/testsuite/gas/i386/x86-64-inval-crc32.l
@@ -67,3 +67,5 @@ GAS LISTING .*
 [ 	]*32[ 	]+crc32  al,al
 [ 	]*33[ 	]+crc32  ax, ax
 [ 	]*34[ 	]+crc32  rax,eax
+[ 	]*35[ 	]*
+#pass
--- a/gas/testsuite/gas/i386/x86-64-inval-crc32.s
+++ b/gas/testsuite/gas/i386/x86-64-inval-crc32.s
@@ -32,3 +32,5 @@ crc32  rax,[rsi]
 crc32  al,al
 crc32  ax, ax
 crc32  rax,eax
+
+.p2align 4