From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1E3D33858413 for ; Fri, 4 Mar 2022 15:58:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E3D33858413 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 224FwkQE004909 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 4 Mar 2022 10:58:51 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 224FwkQE004909 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 91A9C1F0D2 for ; Fri, 4 Mar 2022 10:58:46 -0500 (EST) Message-ID: <28007181-d2fd-d2c9-7eb7-c5432bfcf213@polymtl.ca> Date: Fri, 4 Mar 2022 10:58:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] binutils/readelf: fix indentation in process_dynamic_section Content-Language: en-US To: binutils@sourceware.org References: <20220225222428.1429817-1-simon.marchi@polymtl.ca> From: Simon Marchi In-Reply-To: <20220225222428.1429817-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 4 Mar 2022 15:58:46 +0000 X-Spam-Status: No, score=-3039.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 15:58:53 -0000 I pushed this, since it's quite trivial. I added a ChangeLog entry, which I initially forgot. Simon On 2022-02-25 17:24, Simon Marchi wrote: > Clangd shows a warning about misleading indentation in this file, fix > it. > > Change-Id: I43a7f4f4c75dd080af614222b980526f5debf297 > --- > binutils/readelf.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/binutils/readelf.c b/binutils/readelf.c > index b208db593342..16efe1dfd2db 100644 > --- a/binutils/readelf.c > +++ b/binutils/readelf.c > @@ -11297,12 +11297,12 @@ the .dynstr section doesn't match the DT_STRTAB and DT_STRSZ tags\n")); > filedata->file_name, > filedata->dynamic_addr, > (unsigned long) filedata->dynamic_nent); > - else > - printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n", > - "\nDynamic section at offset 0x%lx contains %lu entries:\n", > - (unsigned long) filedata->dynamic_nent), > - filedata->dynamic_addr, > - (unsigned long) filedata->dynamic_nent); > + else > + printf (ngettext ("\nDynamic section at offset 0x%lx contains %lu entry:\n", > + "\nDynamic section at offset 0x%lx contains %lu entries:\n", > + (unsigned long) filedata->dynamic_nent), > + filedata->dynamic_addr, > + (unsigned long) filedata->dynamic_nent); > } > if (do_dynamic) > printf (_(" Tag Type Name/Value\n")); > > base-commit: 820ed8af6a757408873d8955a2db03b0989fdaeb