From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2081.outbound.protection.outlook.com [40.107.105.81]) by sourceware.org (Postfix) with ESMTPS id 750473858010 for ; Fri, 28 Oct 2022 08:15:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 750473858010 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZTebk9nKhTRUWAcX98B11pXrNMG5d52RZubG+b09PGimowgcduu2bGfzzIG5mhUKbZwgLQTxaQMrPBcP8zloqHMKTXayDU9jVw6oFdH/M6wzZ0vj+/OBroGLnm1vBG3d0f3yR4V7OsxcCp+7X6xPeWZ77QFbFtZCXSujmHG5dfi9ZLcBKGaK6q3GXKZu1CZ317UIn2tVxtGdMCe2NpZxSRzj4imkN52RSzlFfr7wUkjm0pK2OR+JEDEDRud4aJXgI5OOgBblmr31gkaqlzgZJUypO8ZQqLklWquuSy+V2IC3pUGMpiJuzG1qZgV3PiXalrbclSBxMFtuyK4CtsaNCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F6vRtNTQ0MnsN0TTpSF0+OFwI7F15aDa29+EBFjIPiw=; b=WRcBNSA/t+TC6V+6iZXR/uAA7EfSB+0N+LnXsK9QbJnp/jgjQflEhH14jt17i1R7/Rjur1tjCWC7KyZ9e+sygouVfdPAmsUJeuEqV1hEAuoAg1SBZVRKPeamK/wwH8yPtxEzgF+V/KQ7umW1ZyfCcAAoW3V5caJOjjthhbPymUNJcjHM1F+98I9RvR/8iu3GzbZnJzUKlqQ/17ydkattAerXGQUVTyjlSYDaPlZ6ptcqOSzpAAWycdIkpdrTHQQM6YfJVZ78hdUE8/K+//JUnCCHD2YrXfVEGtOdV984Us+SAzLng1VOrzy57vaNDPVa4wuzk/2Mqjd7WqanSeCzOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F6vRtNTQ0MnsN0TTpSF0+OFwI7F15aDa29+EBFjIPiw=; b=B+HtMKMTY8c6KPDoE1EGGcK6xPN9tpjWaoKuaxmy2vdaUtI1VyU5rItcgrDHIl3U64YecAVNDVpwDX4+AQtu1vYepMRMZ37HfUTG/rZxjpbFWmcRRsm/fno+bqdNCeKCnAz/bPIxIN3+ePxA8ITdwi6vyIal2wFRqTEfUIIJX+BA9ZLEscOVO8L+T48v18oykc99Mil+uA2hXS3x+lPUUChiCR/OlSSmWZj1k8CzTuQSvCXJBmXI7lNG9mvg9rzdZU9zjBxG6q6gWta/59Ueww/NDguTreLDuGQCL6/LAv6RyVL0ILcuLjBnLDr/2s9XBTpDWDuzqRtzK7+ZKaexQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7287.eurprd04.prod.outlook.com (2603:10a6:10:1a4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.15; Fri, 28 Oct 2022 08:15:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Fri, 28 Oct 2022 08:15:02 +0000 Message-ID: <28044500-4513-3d31-db60-946f873524ae@suse.com> Date: Fri, 28 Oct 2022 10:15:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] Content-Language: en-US To: "Joshi, Tejas Sanjay" Cc: "hjl.tools@gmail.com" , "Gopalasubramanian, Ganesh" , "binutils@sourceware.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0009.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7287:EE_ X-MS-Office365-Filtering-Correlation-Id: b2306956-cbbd-4a32-8a40-08dab8bc8391 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n6CpW5CUwuTU2n1UyoeWz8F1Mza9lzmZM0z4cs7KIXLhORprKyCtDqiCRAZmeUtdtunEVWfN0YHC7X90GNLIrFEeGNJG1hO+SZXWoKD0zhyBDzZNUIww5Z3Vs92mlA9FaV9pNB2HdN2q2QBp+ndk+qZaqptuZrSViFc1YrWJbfMdZ84Kl075sN0D74iJXN58sperEojRGf7K8kDbG8WMRdJ0UtPkwEyIlbhWQxC6EjuSWITRkgH0ULd6EA2bLqQ1QUWO3ccvJlEbEJHPypnOgY/YC4Rb6nOkK/ARsYXA1TqOAhZi88zR7ERhaU4pQCFspmRU2HvEVTSl2NwBYprN0yrB8ZGv3/d+E7h/2V6bzDTcjgz8ATaohbRnGSpelcX3/AcDKyPaoe0itX4PAV1mBRBkXEep+qEP2h1RWvkIq6r17un+lyp9L//MC6/nEeqpI90b4yiS9CyXPhLOWuDQwaRznIuoRNQ/gbOe/qk+bS7mm2lzYSyECp8f7EbLTrFUg+JxYrnAm5eA8C/Js48cwfo8UFSDZ8qojSIQWvNCiVGYO0PEoGDgijhi2/HVp6Q0UeE2oxA3ynNtsJpmESL8Rheb9NdQbjPkVyyP/kSVwQ2E+xbC97Fr9TDg8CDPqcg28F5Tnqck2X7XCccScIguVCh2Ha8/4x9yBSe34S21IPyKetoo8+JZoYKmHv5F40zTT8rTTEQ9kl3gd/Bl4NinyhXL/BLXzgmVTMWpuFUnsjueP9AQrwJBJqGnsfKx5YY3nf5I8+E7SfukrfwMLTrP2YowTK1MJ12NXzw98bK6AYo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(86362001)(31696002)(36756003)(31686004)(38100700002)(2906002)(53546011)(6512007)(26005)(6506007)(478600001)(2616005)(186003)(6486002)(54906003)(6916009)(4744005)(316002)(66556008)(66476007)(8676002)(5660300002)(4326008)(41300700001)(66946007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFRXdlY0N0x0bWRQcVR0RTM0ZmpUTWdPd0hobGhpcVpnZEwvMFRVUUFXb3lq?= =?utf-8?B?U08yU0dPeGJrOVRnbmMwd0VIOVlaUHQ2VzRteU1QcDU3NXVtUWo0RVlCQnc5?= =?utf-8?B?WkVqZlNWNXlwQXVWa0dnK002V1I5eXgvZkRmc2FUcFpwTXAxVjFYano0SVBR?= =?utf-8?B?c1E4aEVmbzhIdkJWVTJlRVJ0NHdEUmNjaGw0VGpvL09RaEFKL09wdXVHMngx?= =?utf-8?B?Vk1HOXc4Y3BuUkZZbmhRNndEMzIrQnp5V0dvRlpKWWxWQk04SjY3SlFHdkxk?= =?utf-8?B?bExyNzUybVZ1dDhBWi9rdVNITzN6eFJuamlISXJGSWdOWVdFQm51bnY2QzBk?= =?utf-8?B?eFV4VXVKdjZ2cFVjUmxmSnA2QUxjM2RwZUpzRlczQjhhMURFK3VER1RpU0tO?= =?utf-8?B?RGF1bmlEc1BGbDBKSFBzL1FkdTVEbTB2M2QvK1RVQkdyaHVmL0lQNlBJdXZk?= =?utf-8?B?bDlMVHRrNkUvUzVhTkx2N1BHdkg2VE1EYzZhNHA1ZFJWb2kvOTkveEZRMitz?= =?utf-8?B?OW1aUEc5NzdqYWx5eXFHR2ZJZTBNOEM5THQrZUJORnhvRWRaS3NZTktER0RE?= =?utf-8?B?eldsSi9heWFtZFQ1ZStDTGg0ZWI3bTFVRFpZeGk1cWJYQkZld0sxbFc4K215?= =?utf-8?B?NFV5ZEhiZWc5UVlQTUJma1J5aUlqZDVLejBoOXpCR2hBUFZhN1FvamNrOEdO?= =?utf-8?B?aFZ0bER0WXFVWEpOQkF5a1hDSkUyMXBBV0FiN2tXa2Y5Y1M4ZWsxWmpLa0Q3?= =?utf-8?B?V2xzVzN4K3FmQVRnMlgyUUdkeTI5UmZyQ2cxejJPTkF3NGtKcDdwRERtZGd4?= =?utf-8?B?QnEyZG1PSy83bUROWlJQZnMyQ1RvTVU2MVdCRmFEZmdSSmJDQzk0ZEl0V2Vq?= =?utf-8?B?Q2lYclV1TmRlZkJCMStxbDR6RUJxeWZpY1dFNWt4UG1rM3dkMXpPQlZjZ3R3?= =?utf-8?B?K0VDbDdxUzBPUldCSEpBb3JkLy92YUhkL2Fya1c2R3hBemJpVVRmV2VIQUIr?= =?utf-8?B?end5U0dJMkVFL0VNZFkyRU1PRXQ5YXRmN2t0S2MrZWVZTEZjVlhsSGV1bkNJ?= =?utf-8?B?cWpaTnVZRWdKSSsyRWN0T1hnSUZXZytRRnU0TjVhU0hwd2dkcGZnQmhuS1By?= =?utf-8?B?dVFzS0hKYVcvMEVWeFIveG9MdDhFczUyNWQyeUJVWC9yemdXcWlvRkRURkRH?= =?utf-8?B?OXJmZjRMSEhsVGtxd3p6OEQ1VFIyMWFnaVd5RWFiaDBFZGpsZXVIdWRrcVJ2?= =?utf-8?B?NlQxUk5JQ2dnanRQKzExb29WQ3pxbm9qcFJUVGdTZElqQkttU0pNeUl5eVpN?= =?utf-8?B?RnAvYnkrcU52NkhXZkhrVVY0ZEY5R0Fpb2hQeVlGZHUyR0lQd2Y1cVR0VG43?= =?utf-8?B?YytmVGZ0aU9XUzlZM3cwRytWRFphZWdMdmxYZlczVmRpQ2N4c2JTQWJhU2ZE?= =?utf-8?B?QnhCTmNreFQ3S3p1VFVtbk84U2luRE1HbjcwN0hXQXBEdEJ4emdBVlVTbWNH?= =?utf-8?B?TVV0WTNiQlNNYTVocjdlR1ZkVUNadVhVeVM2QTNzbTZXZ2lqTmdxQXE1V2tF?= =?utf-8?B?QmdWMTBWU2s2NEMvRVZqZExvRVhhbUlGeDBlRHJkN2l5eDk4aVJiVnJEL3Bw?= =?utf-8?B?WmUvVTFJUWNSSGxrWXlyRXJxYjUzTFMyNWsyVnE4K0N3MmYraHdjMUZuMHRI?= =?utf-8?B?M1gwSHZ1NG0xRUQwaS9oV0tjRmRkUHVHeURTdm9WM0xIcEVXL1BaQUptTXZq?= =?utf-8?B?Nnc1RnFYY1ljTGs2MGxWc1lobUIvODkwbitnK3R2d0FiWHZBbU4yc1JvRXF2?= =?utf-8?B?c0hzcG53dmZFZmp1T0poNU02emZpNTlNK3ZBSm1ZRUhvWDRQZndXcE9MRFBG?= =?utf-8?B?SGxKSXA1TXNOcE1mT3haQnhGMFJ3WjA0eG03Q1NRbEd0MVh3MGRCSU9qWWNJ?= =?utf-8?B?VDlUR0JPdnVzVHROR0pVZDU4MUtNZExVTDRLY1RVQmJzLzJTVVdzS3h1Q3V0?= =?utf-8?B?RmU4dUtrVktYVHpOTTJ2VmRFL1hvMDZhYzF4K1IybFVwdG1HZVZhLzdrdk1D?= =?utf-8?B?c3FvQk1ZNy9jbDkyaUgzUkVGekR3aXJVUkIyZ0RtM3ZIeTg2eXlDbVppR2J4?= =?utf-8?Q?5ZQdstO3aE6Gi0NkrwD9cx6Tg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2306956-cbbd-4a32-8a40-08dab8bc8391 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2022 08:15:02.7999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ev3VP8Ss5bBuPjZTTBJ/1EPNjy+Lqe4NiyC8siRTFqQE75j5iSA5g86G+ONzwH/7y3+1HgLSOF1NgI7CwkXmxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7287 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.10.2022 09:20, Joshi, Tejas Sanjay wrote: > opcodes/ > > * i386-dis.c (x86_64_table): Add rmpquery. > * i386-gen.c (cpu_flag_init): Add CPU_ZNVER4_FLAGS and CpuRMPQUERY. You also (afaict needlessly) add CPU_RMPQUERY_FLAGS, whereas CpuRMPQUERY isn't applicable here; you already ... > (cpu_flags): Add CpuRMPQUERY. ... mention it here, where it is applicable. > * i386-opc.h (enum): Add CpuRMPQUERY. > (i386_cpu_flags): Add cpurmpquery. > * i386-opc.tbl: Add rmpquery insn. The three relevant SNP insn have a comment: "The single-operand forms exist only for compatibility with older gas." Therefore I'd like to ask that new insns (like the one you add here) don't have that strange form also added. Other than these looks largely okay to me. Note that commenting on patches would be easier if they were (also) sent inline, not (just) as attachment(s). Jan