From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1874 invoked by alias); 11 Oct 2002 20:04:49 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 1862 invoked from network); 11 Oct 2002 20:04:48 -0000 Received: from unknown (HELO smtp.superh.com) (65.219.1.204) by sources.redhat.com with SMTP; 11 Oct 2002 20:04:48 -0000 Received: from sh-us-ex01.us.w2k.superh.com (sh-us-ex01.us.superh.com [192.168.4.40]) by smtp.superh.com (Switch-2.2.0/Switch-2.2.0) with ESMTP id g9BJuBN08125; Fri, 11 Oct 2002 12:56:11 -0700 (PDT) content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C27160.1A7CFF56" Subject: RE: [Patch] sh64: Fix refcounting for SHmedia X-MimeOLE: Produced By Microsoft Exchange V6.0.5762.3 Date: Fri, 11 Oct 2002 13:04:00 -0000 Message-ID: <287E4644B5249D449C56FA5409A874AE03C7AD@sh-us-ex01.us.w2k.superh.com> X-MS-Has-Attach: yes X-MS-TNEF-Correlator: From: "Clarke, Stephen" To: "Alan Modra" Cc: X-SW-Source: 2002-10/txt/msg00254.txt.bz2 This is a multi-part message in MIME format. ------_=_NextPart_001_01C27160.1A7CFF56 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 856 > From: Alan Modra > Sent: Friday, October 11, 2002 2:34 AM > On Thu, Oct 10, 2002 at 04:58:23PM -0700, Clarke, Stephen wrote: > > *************** sh_elf_link_hash_newfunc (entry, table,=20 > [...] > You should get rid of "eh" here as "ret" and "eh" have the same type. > Also, avoid a cast by writing >=20 > ret->datalabel_got.refcount =3D ret->root.got.refcount; >=20 > Other than that, the patch looks good to me. Here's the revised patch. I've cleaned up sh_elf_link_hash_newfunc as requested, and remade the whole patch now that the tls support has been merged in. The code in allocate_dynrelocs and sh_elf_finish_dynamic_symbol will almost certainly require extra work when tls is extended to sh64, but I've treated that as out of the scope of this patch - it requires an understanding of the interraction between datalabel and tls. Steve. ------_=_NextPart_001_01C27160.1A7CFF56 Content-Type: application/x-gzip; name="datalabel-got-patch.gz" Content-Transfer-Encoding: base64 Content-Description: datalabel-got-patch.gz Content-Disposition: attachment; filename="datalabel-got-patch.gz" Content-length: 5299 H4sICIAppz0AA2RhdGFsYWJlbC1nb3QtcGF0Y2gA7RxrU9tI8rP8K5raqhzG j/gdwAt1BEzWtQ6kgFwqdbWlEvY40kVYLkmGsCz32697HtJIlmQbyGbv6lxJ MDPTrX4/RjNpNRqtWrOBfwAuQza32QyOXcv/yuDnQPxeH/Pf/x4s5sy362Pv 5rBUMnaAudN2qxbgCGzjdzOwTdeZfTVtC7+xWejfl/fhgs1da8xKxsQKLde6 Zq75xQtNbzoNWAh3TmjDYuZ4M/CmkFhSMuQaazYBn03H3mIW1kvGNiHHp8WP mrG76WI2xocNZ07oWK7zO0viquvwlut6Yytk5uR+5jP8HiDkCXNZyJCUGRuz ILD8exh7EwZTzy8Zl1dX5snR1dHo6O1gBOH9nNUBjn2GSIDzCc4M8DFidfRk uGV+IFkL7m+uPRecaQ5hcAgNjTlOF9EYsHGIKJDCj0GKKSE3DejL2AzuGJub tud9RYgPC9dFLm5ukATOTOghoUpCJcPmomU2eIuQ04jaGNsQhPjgG+QLmTxh pHsGAWMzMwhDM6IAn6tJ25GLfQ6YxyMXD1EuxA53ZGzLqMEJIPQXDB8RoyR5 CNNR6AIpe8QaPxBi9GRAAkxKP9BkNfbm96Yzmzg+CtgU8yiyYxxOSXnqMHcC HupSB7fZ+KupWc8GYvpUzHUVdSSZTjlN5AXgW6HNfAhti9tdPcM9pqhp/Io2 bt04Y41DYbZSA6FXMmKT4MLLEuqSIddLpeFswr7tw/V08joOBKWD539KF8eX KHWX7cPr8W3wOvDH/G/ySdXbks9C32G3zuwLsnPrcAqb9V6rNHGmU6gtoDaG Whtqc6j5NK4FrNLOzk6KdKPZhPNxCC0MiNDs7Ldb+w0EbuDH4FhrtVohyN5+ u7ffliD0AP2DXuUvcGl2nOTktLuNbrXdRZwEUAL8aEApCPA9L+zjIvzzkzOd sCkMz45HH08G5uUv7wcnw6PSFiJAes3bGwuygi9B/8TQBaYCDcDrHbjyrfFX kFajrASdxWETbhOhjWYqbQBg5zWXiqK8C/hb7WUo58GNf3vg/wpeAufLjAmW lM33tWkaV8zR6GOS8ZfheEmzOfkIkyLxW4XQunbRrYWSe81etd1r7SolG/jh 9MtVKDg06HK5z+nDfLGNZg5bB7BdaEGwU4azj6NRmYPFQoNiw4MdZpOootWY DdZ5lM8iuRNM7RDlJ8MhwhMhyWkU/tyNQzeuafSL9U8ffApizqobkEap7zLU mgm9aqChG5iUrXH5u/Mr8+PZr2fnn876GYvmiLfdwnVTyw1YX1h1r9UgVe0p q/7uqhL85kuSz7+UKOsaBj5LflnXJ15erGnXWS7FYNumBDgtc2/pNFtvqp1m pxd5y6PyXG7aiNlGZdQOA+7dtTwp1CQA6QitURB/AIm6royrjAf6Z6XP2IFN DxNr0w6ToW1bCndRd+o03ZeQwVrOZsfLc70hqB2avnWH8fF3xpc/RjwzlDyN CC+s54L8xBcq0a5enbALfRoqB9CJrQFD7AUqwrwaXZrvTmDG2CSAFkbYGda2 i9C5ZWRFELheGIgAC5q2YlsTxiawlLmDonXsonW0O8JBNzeu7h6C9zrCuATG Dtnbm904kWlSScskHYJKlTz7q0huWFqDifq/zNdRQKhICViy/IedoB8NXnue y7DwQ7ZoMBpHQb+3sG0LFliJalmLCkus8OdY5FsBWFGqU5VcBY3rIxZzWDFi yrtj1leawurcm/0thHtk9ZrBDXWAE0IgwYWqKpqqRBbAmvobKavW5Ijh1Ss+ k/SMqWt9CeAVDEan5mh49qt5en5xPDgxR+fHR6MygXNhGA8CB2Hf4gme114C ERbunj9JFbiwjer1qmCXywKUR6OFP1MRqEKuoQktHULU+LKmclwhQrTsAWoK SYyewuNARLPQbmCOeVE+6Sfk+Wk4Gpkoj5F5OjwbogedfD47ej88Ni8/v397 PoJtRMPNOeZXcoLWjhSnCKKfWL9vD7gIB99C5s+wo7pgrlVWD37kP7nJV1aJ IWn9FRURKhBlw3RdcJBIe1Iv1PJw58kpq9KdMGwLWzbx8Zx74ct7e3vVbqPR jcuq9aI4zybGRsF4i69HOZBS82Jyn6N91DOoqB3g7emJeXR5Obi4QlYQyVZS lGVRfHQbzTYy1NSKjx/EUP35DD1Ltd1Gu4uS6DS1inkjUWwsi8Jc+8cBNIUs uDBkRajShJSN0GCHTLLb1crHH0B3fRO6cxSV2FiCbUvpBwMPqq4KvlDU7l67 2mu0GkpRJeHmLuLmNSaPAhUCwThIv5lRmQm81cL62Y1W9ukn/CwR8N8qlbIs aOVWldrs8Oahc4PxbWJSvcDhVSbAFIPh7sK8+vxhwB+AzzZpqlwVQiNBqEUY WZNr4iWHB5QVMb6a9sTHGGuLBeWowo7L+DGm7bjmGZ2Y7dY+IaKYKAnm6uNt hKCzLApmd3KTURVs8ZJ0M8AaVzdCXmNq+cptapk8LKgEaRkT56enOTMfjmli Rb+RgMC8/qnZy0FnIuCq+V+G+dMFc83G28+dgrndfN4LSab5FVTLJQXE0YqC 6Q/HhSTg9AoKxIriJ6hZ6f7ZBvxOGXDW5HCgrNunEowXf/nu1FduEC3OcSth 8w/ih+ixcBm3fhb8M4KuZQH/1ldgsirN8SiOODUbuQ3VQviDwiNHk7X9vKUK miSxOcsjqn9L0VC8Nk1RkT+fDC+yNXUxGP0JWlprpyljpVYj7uzM52usmnMB 1J5mHFx0kaa2aJSmLR/7G+xW0CTmbpHBJGZrMq2qFWvun9k6DE998zkCvkqW zH0cxlGUSVkZWx/EwnntcMa+hRplxAyOYnalSht/lHmaf5DlHU3n50ICiS2l LGEAEOFcpunYEg0+vjwoKZCbSgdSbhzPDqdaEq3WR6Zs8O0KbuG1yML5/kra kD+MeMZaud2VgMgPpDRZFEblfF4QpWkxB3EI/QsHwo3teinsbOWUEZvrRQAV 57gV2omXFGW5UWGJgNNFVYKc3v3La3j9uKOZRNbOfNIsRPTIWhc7fpFxGYWW RZ/HiAOVav/3MzZ6iLVww/2EYylxRH1TYnvkUfSUe4032GK96ame8ju2WA+r i3wH5Z/xIpu/kdjS3rRFLyHW9BuJXXeen3N9x15+4UQ97RYYUr+be1Qu24jt znao91Jb+mpvmjY8Yn9TBwuEC/zxBxQvv7P8Gb1JUhb2EJtahnixk897h6H5 1ZNeS0joR70lMB5jwW5W3EgOXrBVN1a36kZhqy5sIq9BFzb35Bb96U16VAvx /GokUpCkLas5N1L9XGFfnlwcJ97UuJ5wl6dUJk3NZA9HiXV5eDeTpzyi0v12 5mw2DXqXnRZX3uNSvXXWZC7KpY46ZWxRM50aj/toWa2lctWKeKz1AMsRQ7iG 3giseg+lyvaCdXH+f4yfLyNvzLxRlNCNwmwelQYbZPT1pSQjhzWZUOp8Bc1l IWVl+Yy4gul2uU4w8sqEVQg2EOt6FYuxQbkSiTwnGkX7C9pYvLVQZLgqm63V 96/u/OPeecMm3ljVvz+/GzcyGnGhh4fIMp7WjOe34zkNeWFLntOUa8o3DK08 T1oGpCxD9n/rpZ9E35cazwm8qT4vNbMcdNewxcK2pbBpKXaSuBteOxnnCSSj B86czclGo7zErDe9mTO7T5Jmbjup70MV95Ir1MIL2xwPli8nV8T+KJn8gDQJ CZEmqMlNkd8hQa4W0n9ngoQ/P0GKMKi383r4VI1Tfk+f874163A6bF+zSRVw rAoOf9/aa7RoM6Ddis8v9Rq79Ap2rxmfX4LCs7g7HN8OPosIekgf3c3cxhcg jMMUnnhKHdgNb+baOREpEsK2VlOJ68QuBj14LQhO4DMl3OvSdktDk3Cz1an2 mu09XcKPEStZxzOJ4KXxmJecE52FkkVREmL+wOzA04/OnNHan8l904fLisAj souwxxzkIpE6F0JKnS3Sz40UoiHqly2HeONQ6+zDSGqpNFRa0vDzuijPUrSb HllHH5iwlGYHLaXZ1S2l1URLabVauqU8xCcmC5zSjk9PLmbCgzBG0TUHGZRW mAcXT8HeXFqUPDattTcXr5YHgPOr2HzfW1Oi3RZJdDe+DRGlphWbgqBvCipA tSn4hLeFS0yv3soSS6u0Cyfzbz/BwhboHYu0F4osrU4jEbufz/D/d0FfaBf0 T7GE5/lMq9tDE+q1tBNYy8U7LIk3XWRWVEktpj1X8JXkWZPitl2ObwVEgI/i izh/Tgbebu9We+1uR3t5UUjdS+x2rTyTgAxF9eh6B+20RiYnYVXW28T5/mJ/ pjXReb7W3p5+phbIocZoq+Q6mQ1HJTNGJe6SJORSXHyvJZMYRTTHuSpDjCkh H2mPu5iz23s9/YjtC/L3jC7rKY1RJfleddncfoigcyww83aqfv5XWOBeBzuc va7W4bxpdDrVN026malfykKlCFHG7zzLWqCtVJam1aS8DVBQTamKeY3jTdHF gvXflFUiW8g9a58+UB3VePx6hHZHRN5g0IeQYz40QBqGM+3MP8gZmqRbkNp9 EVtcE4lSbXTFPbQZfHG9a8uVtyzFTbi6vGpxiQNOCIu5uhtC40TU0h0LIxCv oRP3FfiE3hRwUJkYqHLnQFtRFhX4cazua9cCA37zQRqSlEPtEEVHiw0DDUVf IODUVL4KXv1bU0GzXNYkN5yKyzYOCY3uzjtjIFVXwfNJHHy89lbIVs7xi/co TSm4+J6OuoXDHc29JxR3qI2p549xNPToKo640n7NxtYiUBi8KT5E3dKmu9NV uGPwr0UQIjymFoRkN0iMBReD0dHV8B8DcQRAqe7KZivVDHeO64Ll+sya3KOR 3DIkgs0khvgW+UThWDrfT7di6YuyD0P0cFr5I+/s0KUhOS7FxlUkSsilS0Y0 vukdo7L+qNWwvxzR64/BqXkxePdxdHSh4B/iW0Zkhjwox03R8Oz0HLYb1Wg3 n0ueG48GJIP/QVxOL+poB/Vby10wYZo8hkFyOrLtXFtfB0ooWJFEwdCQLbrO HZk+rW63knc0Yp9AJoVjjT2MMphalE/luVRaCpmii7UtZfhudP6WCv1cGTY0 TuhbfGksuLPm8sqJSf/hRYKRVzhRFSQT1u2sW1IUsEUaSfIo5ZyZgHBBZu5R EVxsijxmbm6sa5Zng8HJpXl8/uEzfy/ViO8V/werJNvk3EUAAA== ------_=_NextPart_001_01C27160.1A7CFF56--