From: Jan Beulich <jbeulich@suse.com>
To: Alan Modra <amodra@gmail.com>
Cc: Mark Harmstone <mark@harmstone.com>, binutils@sourceware.org
Subject: Re: pdb build fixes
Date: Fri, 6 Jan 2023 10:09:38 +0100 [thread overview]
Message-ID: <28870cd9-1668-8867-73df-24dc832542ff@suse.com> (raw)
In-Reply-To: <Y6WIDO8tOPdLz0+5@squeak.grove.modra.org>
On 23.12.2022 11:50, Alan Modra via Binutils wrote:
> --- a/ld/emultempl/pe.em
> +++ b/ld/emultempl/pe.em
> @@ -15,6 +15,13 @@ case ${target} in
> ;;
> esac
>
> +case ${target} in
> + x86_64-*-mingw* | x86_64-*-pe | x86_64-*-pep | x86_64-*-cygwin | \
> + i[3-7]86-*-mingw32* | i[3-7]86-*-cygwin* | i[3-7]86-*-winnt | i[3-7]86-*-pe)
> + pdb_support=" ";;
> + *)
> +esac
> +
> rm -f e${EMULATION_NAME}.c
> (echo;echo;echo;echo;echo)>e${EMULATION_NAME}.c # there, now line numbers match ;-)
> fragment <<EOF
> @@ -66,7 +73,7 @@ fragment <<EOF
> #include "ldctor.h"
> #include "ldbuildid.h"
> #include "coff/internal.h"
> -#include "pdb.h"
> +${pdb_support+#include \"pdb.h\"}
Sadly this doesn't work with older bash (observed with 4.4.23 and 3.2.57), where
the backslashes make it into the resulting ei386pe.c, causing the build to fail.
Consulting documentation I take it that this is a bash bug, but I still think we
need to find a different solution here. I'll try to experiment some, but only
after dealing with another issue that's relevant for 2.40.
Jan
prev parent reply other threads:[~2023-01-06 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 10:50 Alan Modra
2023-01-06 9:09 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28870cd9-1668-8867-73df-24dc832542ff@suse.com \
--to=jbeulich@suse.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).