From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id 308D1386547E for ; Mon, 1 Jul 2024 06:15:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 308D1386547E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 308D1386547E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719814525; cv=none; b=dMiQMZ5QXEHpjJA88avpRU5nXQeP5Lzc3az5XsmHlcka6+wStw6rsIJP36IK0wmfckTews9BQTYWtC4UD7glnM7Ha86IGVWZWBbSB4/ruV8KytXclAh1fmGcsq4sthp5U6TN2IbKunnsYGOuI0g5wuAIhF7uAzllD/PmRMy/NHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719814525; c=relaxed/simple; bh=3VkWlM1sIE6bn6iNX2RyknbUMyG+6rIYX5AnpEVFTUg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=QAx8gMHdE9dtFCsT7EFAOX05qqUdHGnEP/Tgo+lpAkOt9EAN6wug6UaLSm5gk3qmgrgWdiyMpamK0zVBBmQBYy9zN2ektYTm3nbf1LJyENuF1JfySb+GdhY4ywQh3jPAPkWAmI4RsdoqsbM9t5F1F6qzGrLqJsfLraf+LZ29+6k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ec58040f39so25337691fa.2 for ; Sun, 30 Jun 2024 23:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1719814521; x=1720419321; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=V8FPGHKAGFYQh+dcTKiKPQnkgLY1NaEUWkqkfX+5Szs=; b=eTUidbyzZH75KT4/19hrUEp2XIKNaivIdOBIh3J7p5uYmsmBe5yDwYhtOF3jkc/qpk HwocixgCp8A5pXRSMdXqPW9q4xJPAs9oedKdRznbA3jJiXHJVCnRqYUB9/OW+LttUX8F x19CtfzCM9YlQJFvE5wCkYBd1H7rUGsIWfTninyEKwOElhge2JtSLDFILHfKfh2RWPST 4c3YQdJzvG22ka4f/7CJR9B5Agqz0T+89WUwYkTnkGQ6Rwskb+5xkMwJeXpzy0Kz+9zr cygZvajr2VOshR4TK//OxdZ7W1M7ybRdiDZlQwI2wlo50nPvSZfejqOX4pg+FIoGhoLB KMVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719814521; x=1720419321; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V8FPGHKAGFYQh+dcTKiKPQnkgLY1NaEUWkqkfX+5Szs=; b=vlV6JS8n1z9nzHVeRrCxgP1aLrDpxE4I1oDrrmo64wASGjL4pBCE6hCpErK7ZuSlLM TcbwrTeU2SvgDzB24MoWwB18UX+nuYLOxhhjxyeBfH/2oH7XsjQu2ur0rY7e7sMgGkZD 1DrTjSormf5TBMMhIpM/VgT20D7pd9dIHyV3OQq/rbkxewrDP9UGKQT9CRj5ryDuu59E 8rrvSfk/OsuV89tGzy9WuVWtKwURiffwWg6W97bwMtMW9ZT2BJ5mZMAU6kSPCzLvR22Y COp8622xPr9lmnTMoFwnvEuk2o+6SyfAecJJUGsUAf0VAZ2XbLBUiRmqWPHlFQVXbzaK wSHQ== X-Forwarded-Encrypted: i=1; AJvYcCUl1Rn2Pzk3iFXZKBVcVmHw5GLKGTHHDkGQ5udtdMFP8RluXj1SPMGhsNutIBQYBfvGY1JmVWKOdL5hc83fdSaPhiPmXd4JyA== X-Gm-Message-State: AOJu0Yx1Ni/RMhnYhevviWquAIpb83Dhral6P//7VKC1FLPhsxVp1DOl wiqXmfuJPLZmz1QYXvekoZMSpRYz9D6yxCSfHGE1LPOwyS1X0aH+ZkIAD0JR5A== X-Google-Smtp-Source: AGHT+IHhKL40mWiny0kcI5m6ahG6UrMoC4fqVZrPJmuAR/T6LHQJAmMl3u1SlcAj9TkQCd68DIWijQ== X-Received: by 2002:a05:651c:4cf:b0:2ec:5921:bb21 with SMTP id 38308e7fff4ca-2ee5e3594f0mr32016311fa.10.1719814521580; Sun, 30 Jun 2024 23:15:21 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac15698cbsm55909145ad.232.2024.06.30.23.15.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jun 2024 23:15:21 -0700 (PDT) Message-ID: <289780a1-6b2e-4bd7-bf0d-f924d21bd700@suse.com> Date: Mon, 1 Jul 2024 08:15:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86-64: Relax BFD_RELOC_X86_64_GOTTPOFF check To: "Kong, Lingling" Cc: "H. J. Lu" , "binutils@sourceware.org" References: Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01.07.2024 05:03, Kong, Lingling wrote: > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -7137,8 +7137,14 @@ md_assemble (char *line) > && i.base_reg > && i.base_reg->reg_num == RegIP > && i.tm.operand_types[0].bitfield.class == Reg > - && i.tm.operand_types[2].bitfield.class == Reg) > - /* Allow APX: add %reg1, foo@gottpoff(%rip), %reg2. */ > + && (i.tm.operand_types[2].bitfield.class == Reg > + || i.tm.operands == 2)) As before: You allow more than what you claim in the comment below, unless I continue to be overlooking something: Aiui you want to exclude forms with memory destination. > + /* Allow APX: > + add %reg1, foo@gottpoff(%rip), %reg2 > + add foo@gottpoff(%rip), %reg, %reg2 > + {nf} add foo@gottpoff(%rip), %reg > + {nf} add %reg1, foo@gottpoff(%rip), %reg2 > + {nf} add foo@gottpoff(%rip), %reg, %reg2. */ > break; I don't think the {nf} forms need naming specially. Or if they did, I wouldn't see - as mentioned before - why the {evex} forms won't need/want mentioning, too. >From the presentation below one can get the impression that you're altering indentation of the comment. It was properly indented though. However, your patch also pretty clearly came through with corrupted whitespace (no hard tabs at all), so it's not really clear what changes. Jan