Re: [PATCH] Support AT_BSDFLAGS on FreeBSD.

[John Baldwin <jhb@FreeBSD.org>]

On 3/25/20 2:04 PM, Simon Marchi wrote:
> On 2020-03-25 4:37 p.m., John Baldwin wrote:
>> I can add something.  To date there aren't any user-visible changes.  There is
>> one flag defined that indicates that the running FreeBSD kernel supports a new
>> 'sigfastblock' system call that allows a thread to register a signal mask in user
>> memory that is treated as the signal mask so that sigprocmask() can just modify
>> that mask in userland without invoking actual system calls.  It's not documented
>> though aside from the upstream commit message.
> The commit changes fbsd_print_auxv_entry, so I presume that GDB will start printing
> this auxv entry, if it is present, won't it?  Isn't that a user-visible change?

Ah, yes.

> Even if there is no user-visible change, it's good to mention it, as well as why you'd
> like to make the change.  The reviewer and future reader of this commit are not in your
> head and don't have the same context to know why this was added.

Fair enough (and I often make similar points in other contexts).
Note that in this case I reused the same commit log from the last
new auxv entry I added (albeit back in 2018).

-- 
John Baldwin