From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Victor Do Nascimento <victor.donascimento@arm.com>,
binutils@sourceware.org
Cc: nickc@redhat.com
Subject: Re: [PATCH] aarch64: Remove asserts from operand qualifier decoders [PR31595]
Date: Thu, 18 Apr 2024 10:50:25 +0100 [thread overview]
Message-ID: <28efe493-8369-4670-84c2-1c392f1bd01b@arm.com> (raw)
In-Reply-To: <20240417094400.2151234-1-victor.donascimento@arm.com>
On 17/04/2024 10:44, Victor Do Nascimento wrote:
> @@ -1014,6 +1037,8 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED,
> if (value > 0x4)
> return false;
^^^^
> info->qualifier = get_sreg_qualifier_from_value (value);
> + if (info->qualifier == AARCH64_OPND_QLF_ERR)
> + return 0;
^^^^
> }
I see Nick has already approved this, but spotted the above while scrolling through. Mixing 'return false' and 'return 0' within a single function is poor coding style. Please fix.
R.
prev parent reply other threads:[~2024-04-18 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 9:44 Victor Do Nascimento
2024-04-17 9:48 ` Nick Clifton
2024-05-15 14:58 ` Victor Do Nascimento
2024-05-16 11:11 ` Nick Clifton
2024-04-18 9:50 ` Richard Earnshaw (lists) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28efe493-8369-4670-84c2-1c392f1bd01b@arm.com \
--to=richard.earnshaw@arm.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=victor.donascimento@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).