From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 5F5733858D37 for ; Thu, 18 Apr 2024 09:50:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F5733858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F5733858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713433829; cv=none; b=kGJKRS0tWHfmBge1Mf50bR57kfQC8bhlCs8yz6nL1zhsUaNFhz06ETCysUZlabBuzd1hP8ZXhlLCHPscA5rL3mla0T+ZeqkQRmDjL17hGZR4GXdRMdb07dUXPuPHyuhDk4qPzjxknz+sp+MohFTAeLLz2lQ9X3VUhb+xz207vTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713433829; c=relaxed/simple; bh=iX3rEfexuSN6u1Ie+/LeHiJ4KxbGw5PBPc/3VVQxCR4=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=HLoRBtDE8aztclsjiuwmNS+G/Kk4NMHBK9wcdp6YbyDC7niLZVwYs7kXW5IUZ+uLDp+JUckdSX3GEib4wqlQr4Ij/X00Vp230w4HpUCNMPTALsgvEvILY9Odigpt+WbzMdrfaEo4hkPYbie2/p7w6RFg5Qr9b1C8dSBikqCmHiE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 818C5339; Thu, 18 Apr 2024 02:50:55 -0700 (PDT) Received: from [10.2.78.64] (e120077-lin.cambridge.arm.com [10.2.78.64]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2DB9C3F64C; Thu, 18 Apr 2024 02:50:27 -0700 (PDT) Message-ID: <28efe493-8369-4670-84c2-1c392f1bd01b@arm.com> Date: Thu, 18 Apr 2024 10:50:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] aarch64: Remove asserts from operand qualifier decoders [PR31595] To: Victor Do Nascimento , binutils@sourceware.org Cc: nickc@redhat.com References: <20240417094400.2151234-1-victor.donascimento@arm.com> From: "Richard Earnshaw (lists)" Content-Language: en-GB In-Reply-To: <20240417094400.2151234-1-victor.donascimento@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3491.5 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17/04/2024 10:44, Victor Do Nascimento wrote: > @@ -1014,6 +1037,8 @@ aarch64_ext_ft (const aarch64_operand *self ATTRIBUTE_UNUSED, > if (value > 0x4) > return false; ^^^^ > info->qualifier = get_sreg_qualifier_from_value (value); > + if (info->qualifier == AARCH64_OPND_QLF_ERR) > + return 0; ^^^^ > } I see Nick has already approved this, but spotted the above while scrolling through. Mixing 'return false' and 'return 0' within a single function is poor coding style. Please fix. R.