From: Simon Marchi <simon.marchi@efficios.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] binutils: put DEBUGINFOD_CFLAGS in AM_CFLAGS
Date: Wed, 17 Nov 2021 10:12:42 -0500 [thread overview]
Message-ID: <29990da7-b2a7-03b9-9f09-e49815c6f3ff@efficios.com> (raw)
In-Reply-To: <YZSIlOuWQZRXXMW/@squeak.grove.modra.org>
On 2021-11-16 11:44 p.m., Alan Modra wrote:
> On Mon, Nov 15, 2021 at 11:08:52AM -0500, Simon Marchi via Binutils wrote:
>> Ping.
>
> I can't say I like it, admittedly mostly because you're putting a
> thing named *_CFLAGS into AM_CFLAGS. If it was only -I options and
> guaranteed to stay that way I'd be happier, but the potiential for
> someone to put other options in DEBUGINFOD_CFLAGS worries me.
>
>>> Fix this by putting DEBUGINFOD_CFLAGS in AM_CFLAGS. I think it would be
>>> a bit better to only include DEBUGINFOD_CFLAGS in readelf's and
>>> objdump's CFLAGS, but I couldn't get that to work, because of the
>>> special build rule for objdump.c (if somebody wants to try it, please go
>>> ahead).
>
> Does the following work for you?
It works, yes. So if it's more in-line with how things are done in binutils,
this is fine with me, thanks!
Simon
prev parent reply other threads:[~2021-11-17 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 18:35 Simon Marchi
2021-11-15 16:08 ` Simon Marchi
2021-11-17 4:44 ` Alan Modra
2021-11-17 15:12 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29990da7-b2a7-03b9-9f09-e49815c6f3ff@efficios.com \
--to=simon.marchi@efficios.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).