From: Jan Beulich <jbeulich@suse.com>
To: Alan Modra <amodra@gmail.com>, "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: x86: remove i386-opc.c
Date: Tue, 20 Dec 2022 12:44:39 +0100 [thread overview]
Message-ID: <29b9b1a9-c3f8-eea1-2953-02164ee56f9f@suse.com> (raw)
In-Reply-To: <Y6Ge7zaVP/wuvdCL@squeak.grove.modra.org>
On 20.12.2022 12:39, Alan Modra wrote:
> On Tue, Dec 20, 2022 at 09:40:14AM +0100, Jan Beulich wrote:
>> On 20.12.2022 09:33, Alan Modra via Binutils wrote:
>>> Regen opcodes/po/POTFILES.in
>>>
>>> diff --git a/opcodes/po/POTFILES.in b/opcodes/po/POTFILES.in
>>> index 9906bf14848..effd73f8f78 100644
>>> --- a/opcodes/po/POTFILES.in
>>> +++ b/opcodes/po/POTFILES.in
>>> @@ -73,7 +73,6 @@ h8300-dis.c
>>> hppa-dis.c
>>> i386-dis.c
>>> i386-gen.c
>>> -i386-opc.c
>>> i386-opc.h
>>> ia64-asmtab.c
>>> ia64-asmtab.h
>>
>> Which makes me wonder: If this is the list of files where string literals
>> may/will need translation, are files like i386-gen.c (i.e. build time
>> helper tool sources) really supposed to be enumerated here?
>
> Probably not, but the build time tools don't tend to use gettext and
> thus all it does is slow down generation of .pot files a little.
Which then perhaps means we want to remove
#include <libintl.h>
#define _(String) gettext (String)
from i386-gen.c. H.J. - any idea why it was put there in the first place?
Jan
next prev parent reply other threads:[~2022-12-20 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 8:33 Alan Modra
2022-12-20 8:40 ` Jan Beulich
2022-12-20 11:39 ` Alan Modra
2022-12-20 11:44 ` Jan Beulich [this message]
2022-12-21 17:51 ` H.J. Lu
2022-12-22 8:49 ` Jan Beulich
2022-12-22 9:43 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29b9b1a9-c3f8-eea1-2953-02164ee56f9f@suse.com \
--to=jbeulich@suse.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).