From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id 44A5E3858C60 for ; Mon, 29 Jan 2024 07:30:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44A5E3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 44A5E3858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706513459; cv=none; b=lwJTsQyT8awbPJSB2CUAY39Aj0WajFs1x5Y4v46U5HlgQ0s3n2744JpPdO5Rwx1K2qlPDNwt1jP4jvQTiRJGE01NmnDFnzoY7g/FdUKrFEHRi34nBCgqN5Xxk5Sl6JG2Gk9R9AzRNMuBHilI2Ueaxko760IQ4mmVCQ3TBA+L+So= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706513459; c=relaxed/simple; bh=BJBSNhLZ+NZfSt9ag+YkhtuIQMfoX17hC0ady1+BTi4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aur8J60VuzgMejBLWcbn1uW5OPFx/7qwEU/22QUQl7DvEJZAtDBedsOp+17CX4tKysS7E10gJPCZgmqGy+GJ2y8ZlIXGI7ytaCgBWjdir0qAMSP54RNg+EpYTFwlECFbqhl4W3k8qSDpAOVTXCPM1IF0Vvfx/g4Z01PAbjOJA4A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2cf1288097aso32409971fa.0 for ; Sun, 28 Jan 2024 23:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1706513455; x=1707118255; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=MO3HGqomO9CMRN6URj2s/m7x3sRCihuxZvWnw5N/Mbc=; b=K3D5KNMG7rxSyfzbB5DbxI1+mEeji2QqDTKL5ioTf/fOgh0jp+rsol1WAJhzOEb6GI L9hHzeVS7qmhCFK2oN4Rfii8FGRKLgymw926Qiv3826KgtYd5mXw7Le6zRQUjNQLVSlt zvX4UMIFoqtlZxU9DYFBhHcE5qbCgviMSkCBKw0Z99Vw8NnZ8QPG7NvLEYCOOzgbng4/ WwGMt9Innv6bvJPM/xCp/19iAgVjZzJzhNHl3mn52xoAVFFhC0IKZ8d+yrwcomD1HZFJ VloYMJAqr9ObYuAvuC1GBI2y09LtpWP71MdIEP8u920qn0x3YB8AbHDE7VPj2N0uTioZ 4sKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706513455; x=1707118255; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MO3HGqomO9CMRN6URj2s/m7x3sRCihuxZvWnw5N/Mbc=; b=m3SaXTTE6p5fp9h1sqgjsBT3yA7FjnW+tL9amV3Me6wemrLthE7+0FRbM9sSic6YY2 ppCAr18D8c8MzzwPWpKDD9NNiyR99aKX20qZ9lHlwjNmjfbiiyKC4V1eK3gSps7LBGNM BJIln6RGsUjiXaQeZkKHF5xQVFm8UtaQnAGkaqy+n2ES863KUF1MlYX9hBcOjyoXJO10 1Dixx1OY768DGElc/+8sX1KJPiVOR2yQ+CHAm317aatOG97naZTW9eSv5L3ykqZ5X4M+ 1tkq4LVTwOhkZEjCR85CTbgOY97NUdahzqq6rFrrYKQ7QmGKTkEDO1wfKCe5TVqwa0DL slYQ== X-Gm-Message-State: AOJu0Ywt89ZoVMnSFGn82Wz+gUQTCxtlq9iKg1aMc5FYEGUmDgK3JGaC 2+P9Ft8hXkg5AuLAFSR9dgGwasFD5YdKCLIWUwBzvQibEmjIS8y6FE8lneT46QCPWkyezoerjKE = X-Google-Smtp-Source: AGHT+IGKyHuqSLUUWJNGH0s7Uetxxyoh5p9jOOqN/aFI+bfRxQHQYnK7XdLDjenvpU8LQKhcDdlVhg== X-Received: by 2002:a05:651c:19a4:b0:2d0:4f51:531 with SMTP id bx36-20020a05651c19a400b002d04f510531mr568942ljb.45.1706513455619; Sun, 28 Jan 2024 23:30:55 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id q14-20020a02c8ce000000b0046e78d36f34sm942173jao.67.2024.01.28.23.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jan 2024 23:30:55 -0800 (PST) Message-ID: <29c60b5a-8594-4c4d-b97d-f1d96761a27e@suse.com> Date: Mon, 29 Jan 2024 08:30:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ld: Turn on --error-execstack/--error-rwx-segments To: "H.J. Lu" References: <20240126214553.46536-1-hjl.tools@gmail.com> Content-Language: en-US Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240126214553.46536-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.01.2024 22:45, H.J. Lu wrote: > --- a/ld/lexsup.c > +++ b/ld/lexsup.c > @@ -1947,6 +1947,17 @@ parse_args (unsigned argc, char **argv) > && command_line.check_section_addresses < 0) > command_line.check_section_addresses = 0; > > + /* Override --no-error-execstack and --no-warn-execstack and turn on > + --error-execstack for --warn-execstack and --error-rwx-segments for > + --warn-rwx-segments if --fatal-warnings is used. */ > + if (config.fatal_warnings) > + { > + if (link_info.warn_execstack) > + link_info.error_execstack = 1; > + if (!link_info.no_warn_rwx_segments) > + link_info.warn_is_error_for_rwx_segments = 1; > + } > + > if (export_list) > { > struct bfd_elf_version_expr *head = export_list->head.list; If I'm not mistaken and if the comment is properly describing things, this placement of the addition means --no-* last on the command line wouldn't be honored anymore, when later arguments ought to override earlier ones. Jan