From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2043.outbound.protection.outlook.com [40.107.8.43]) by sourceware.org (Postfix) with ESMTPS id 106DF3858D3C for ; Mon, 10 Jul 2023 06:37:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 106DF3858D3C Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hl9GmbN9m6BEFxkNk9omIkzyqEGY6zy6R/U7XVU4CdjWP6kQhKnZdWji2uI2KLgw5ENz1benFrP/ju1FtYYRx9OpIe/FubV9nBx1rOY9xlR3JYzySe7TCoYiJffuxeLdgL3EUjNtmMPaHi4ee2F223Y+TfJ7y6ybwPveLUp1cohSOnYoVyW1lCjNuTTugHpw63nWfdcyIra83E6Sctg+HMqvuElkwI/YmcbvxJHRxe0C2GS/wPpD5m5nNNtIck5cu3+jX/joIiJpMKvbokN7l4I28p+o3nvvIPUmXE1nWpGJm81eLgulGN7nmCAGle3AhLpQDgah/OY5vrMdMM+b5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UYs4JvZ5US67Ybth57OGyy4KGmxjrgvn/zQJmUsupSI=; b=UsvWHQCyODCDZELWbX0CMw78fOqr310q7ZumI1Dw2BQQaaZS4bZ9Qvfy8lz2eXnucQaORLkcqYxzVajSRnd7k9jw7CqKkHrx8oe/pUHTOz5/LmRKsFiq54LzOihb8bCQZ9l4J6E1Xw++N3bzqf4vNq4lnOzE2rdUheuXc0Q9CzATc/rbD6aGcs4zxqio/QpYcrmUVKfwnW4VJEn6GTHcA65i8M4+WGyi7xBjNH9PQRiCe2wHhw1Cy0SY4yZHjEOeGR3M2idWuv2EYmh3Hwfuvp2P3Rsy8gFsX8KUmMDNYJ3lPg+tHMgXy4CLY2jkVlU//DTBuiNxfLs7jaG3YLfDsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UYs4JvZ5US67Ybth57OGyy4KGmxjrgvn/zQJmUsupSI=; b=GY2arIostFxkLqhboKjLmZL22/wC+cVHgcpkIy8FgisVykqbCAd/RuCTNl4KMl4ESFHh8dwuz+w84qnAm33T4Jg4hOa2XgqO7fSltQ+DxATfG/mJ0p3rxqFgJl9GI2+DsQajsRbMt1FtypGPhL9fVYslKumyHTK4ueZjX0AC0oLJ9N5AzpkRAkmlQZd1Ru+0r+cXFRQGtp+qY+xmb1vkJm+0CjhWcHkcAl/0ldfrgKSbooSinGVonmAaPL97N5aqqogjB53pXOH5ogHfs6sGZe7+7+5yVDzIGXSitdf9QAKXb2B+NvS9iZMP+2ZlHid61FwRQSuhvRaawOs1b8RzIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by VE1PR04MB7485.eurprd04.prod.outlook.com (2603:10a6:800:1a6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 06:37:26 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Mon, 10 Jul 2023 06:37:26 +0000 Message-ID: <2a422912-1b90-d1d0-49ba-c2898680a6fe@suse.com> Date: Mon, 10 Jul 2023 08:37:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4] PR30592 objcopy: allow --set-section-flags to add or remove SHF_X86_64_LARGE Content-Language: en-US To: Fangrui Song References: <20230708053035.528911-1-maskray@google.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230708053035.528911-1-maskray@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0186.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::16) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|VE1PR04MB7485:EE_ X-MS-Office365-Filtering-Correlation-Id: c37ab811-5c3b-41d1-a1c1-08db81102032 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PxZzVtk/soo908QSrdcxP+cpjFcMMdTgOQ193LPqPwHUHT29jt1hbOUxmPBUCWJvmB7i+ggl2+0kvZxHOY2LD8voBLwZF7nkcf05G1nLph5G0Ks//mes+mrb66fkqZDqvnK2YEESAaofbuiuyVHqP1lYFVqPLJ1HMhl2fLl55yvly3kYPJEgoi8PPPgk7oadL3ajpxYJv7PaKypfjva32udnMkI4fVLlSx1WHkAWSSC0/MTERFfwvnzny/c/lyw1vCSOETf3r2wKN+iVwcDbCXnVan/ae2eVOa8f/ZI+uLHraTqO9yDpoJ3j8MxG3m+gFdfRITdxY/g34IT24EWjexAOfLVlDVgL9rsy3mzgmbTIWc0258sLROfMT6/rRmO4hYUuBz6Zxm+ITeuQiAguH8BwAKpedO90vG66ilHp/r/AY7W7Uet4oyN/BvQDI7BCyceVevNw1Jloyu1zgfC8JWO42wCteninqzQ7HtAkBX3UgUjpB9tAYvtFOp5LKFT7YPRNAN2ggsGPRaUbn486Bfnu7v2sxhY0TnmueqRCorq8aBKzn+/vsMlAKirmyxRovhDzisFVXGX+zsWKhaI2ccGq8j0PiY+VeAPAB7PCLiOCo/xg9u100F7tqm9XTF2XOpGQzp4i8SzamQMZWa0+eg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(39850400004)(376002)(346002)(396003)(451199021)(31686004)(6486002)(478600001)(83380400001)(36756003)(31696002)(86362001)(2616005)(2906002)(66946007)(186003)(6506007)(26005)(53546011)(6512007)(38100700002)(8676002)(6916009)(4326008)(316002)(66556008)(66476007)(41300700001)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWNoRkFMNUpiSXBsVytEZDNqUDZISFFwcWZ3WU4yMmRITDJBcjdmN01jSWdj?= =?utf-8?B?RThVQko5dzlrNHNtZ1pZTVRGL3J1NEFVNjZ3aVhaRTdMbk9SZHdibDNRR2U3?= =?utf-8?B?QWxiMTAvbHVscXB4TnhSTmpUYXFiT25MdUYxeG9ET1FVTWtQcVoya1VLME41?= =?utf-8?B?T2F5aU1nV09GSFJ2dlV1SHRMb2ZlSURPeDlPOVJ2SjQxY0xFeCtDcGhTK0RP?= =?utf-8?B?T1ZpK2VzNHFUSlQzTFpjWU9HRkFmeHdlQkdPODYzQktleGtEWDE3WU9aTkRl?= =?utf-8?B?ckJjcUxtQ3NLakhGZEhtSVVCeGxwbGJhMzEzSUV3a1U5eFhrR09jc0NCTkQv?= =?utf-8?B?N25IR2ozOUVRTVRpNkFzQnFpTkRkb3g0VVhoT3FqMjh0T0JMM0dRc21ORzU1?= =?utf-8?B?aVRxclhlZTdkbEtua2hoOS8wWUVwR2xLK2dZV1dWTWFmNnJ4UXB1ZHcrTmpY?= =?utf-8?B?ZWtMR2RCRmkreUljZ3pnaWxyVTJGbyt0UzdJUS84ZnpoMzlvREVJRWFteVNZ?= =?utf-8?B?TThUcERzRU5uMy9OK3FjQzFiM2lia0dpWWdtUUZwSXUySUZaUDRLVUx3cmJG?= =?utf-8?B?UHFPZjZnK3RqREFQQnh2Rk9LOWxtand1TTNONkI1TUlhdWE0SXZxOENGY1A4?= =?utf-8?B?alZJL0dPUVVpS2h2enpkeHJINGNPTzJ3RE1IZUN6a0d0a1dQZzB4aVQ3Vk12?= =?utf-8?B?bGdVMTZQV3dGQkg5OWNpSWg4SFhuUERXYUo4cDZnK2FTTWZ4L1M1bjRwMVdy?= =?utf-8?B?TEhzdDhuaTRlTVc3dU1hNGFhRkZPNHZ6eFFWY096dkZTcXROb0JlMVdMMHNB?= =?utf-8?B?U0pkRGhqRnp4YUNBZmhHVm8xclRVdUxrbXQveFlRcGcrWDk3amhIMXlwcmFq?= =?utf-8?B?TWNCdG9RTW8wb3FzdXhISTB4b3Q3ZVpTZVV1Z1UzQVJDWGY2SlU0cXdkZXdB?= =?utf-8?B?d0lyRERtemp5NEUyNXRmSDF5eVFVdXJkQkYrT1JMVUNJU1daNVBVUC8yOTBz?= =?utf-8?B?elpaUjJXR2kyODEyWDhXeTJHSWZINFdmV2VsTXpFTzFaZFZDc2dyVUhWU013?= =?utf-8?B?QStUN2JMbUlESjVsaURqQTRQcTRMRHdWaVBKZGh1SCsrdTZ1NkhmMFRKVUY5?= =?utf-8?B?TGRpNHpoQUlackpWZENVZU9ISllpb0xhMUJUTW56MlRRK0dIMm5iWTFNL01Z?= =?utf-8?B?T0Z5S0dQVG94eDRzTUFvUWVNSlA1MFRMcVh2TzFldERveE13QjU0SjIzdk40?= =?utf-8?B?dWFzOThvM3NaSFYzVW9od2lKRkV2NDFYY21SaWd3R21WSkVpazBjZVloZXVU?= =?utf-8?B?bHhXcW5ra2FvbGZmM2pYeE1NWE96QWUxRysrZHpuNkxXWTVHRFlTR0hpbWR4?= =?utf-8?B?NERSN0M5ckNYdkFsUlg5aG1oZ3R6eHpMTlNmWU9BK3VISFlxTzJnL2lGWjhM?= =?utf-8?B?aHI3NVNxbFEvYTVML2o5QjN1WTlnNGlsODBBS0ZjSHd0V2RFd2NhTFJNS1JO?= =?utf-8?B?TElaTzNYa2tYSUdsaTBiMVZRUHYrUjF1MGVSTWo0OTBEcUFLUDNtOXZrSFN1?= =?utf-8?B?M3lFWDFXamduanoyM1pGT0Nrd0x3T05wL0pRd0ZmTXpxTENSRmduSHIxV0tp?= =?utf-8?B?Tml0SHIvcWNQSTArbTlrTG5JeVNoQmZjQ1ptTzNMMG5MaG5TZUVodXY0V2RH?= =?utf-8?B?dEIxczU5aDlKZ2lMUy8wSERGcC9SQzdYbDBET0ZydTJud0oraU5GZlIwZjZW?= =?utf-8?B?QjRTSi91QXJEM0FoMEFMZDBvSEpDNlduYm03eG43ZUttbUhlaE5SbXgzVDE4?= =?utf-8?B?YVB3cDM5eXpXQVhsYmdTbjE5aDl3aUZIMlRuTEx1NDNITkQ1VHNXQTgrbzQw?= =?utf-8?B?aURmK0xMOGhCUjd4MUVMYWNuamFQanUrdWVJWVIvcG5jVUtMUi9hSjI3N2w2?= =?utf-8?B?aWVhbXhldnhNUWQwS3IwdzhUVWE0TWZNQVNGMW1JUmMrU0xSZFRjTnk2d2d2?= =?utf-8?B?OXRQTlpNTjVkcFBYZjBqUk1sZkNvajNQODlIQjRDdGVCYWsvNm40QzB2VzZC?= =?utf-8?B?MkZZQjlOS05jcDFsTlpSOVo2RE4wVlpMNDNiRW9BTnRUN0l1Z09KZjhnWnNB?= =?utf-8?Q?otryCt4TsWTjQtd9p4jIjXVUf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c37ab811-5c3b-41d1-a1c1-08db81102032 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 06:37:26.3800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 36EUoQvEO2zu7UNH6WEvNlkv9eayThxXB5LvD8KxaSfCJQw4sWD1bZTs5qdCHiILaIZ4Pegs36wzOs+nN3Bkmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7485 X-Spam-Status: No, score=-3026.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08.07.2023 07:30, Fangrui Song via Binutils wrote: > --- a/bfd/section.c > +++ b/bfd/section.c > @@ -359,6 +359,9 @@ CODE_FRAGMENT > . TMS320C54X only. *} > .#define SEC_TIC54X_BLOCK 0x10000000 > . > +. {* This section has the SHF_X86_64_LARGE flag. This is ELF x86-64 only. *} > +.#define SEC_ELF_LARGE 0x10000000 > +. > . {* Conditionally link this section; do not link if there are no > . references found to any symbol in the section. This is for TI > . TMS320C54X only. *} > @@ -2618,7 +2621,7 @@ merge_gnu_build_notes (bfd * abfd, > } > > static flagword > -check_new_section_flags (flagword flags, bfd * abfd, const char * secname) > +check_new_section_flags (flagword flags, bfd *abfd, const char * secname) Nit: Stray (and inconsistent) change? > @@ -2631,6 +2634,19 @@ check_new_section_flags (flagword flags, bfd * abfd, const char * secname) > bfd_get_filename (abfd), secname); > flags &= ~ SEC_COFF_SHARED; > } > + > + /* Report a fatal error if 'large' is used with a non-x86-64 ELF target. > + Suppress the error for non-ELF targets to allow -O binary and formats that > + use the bit value SEC_ELF_LARGE for other purposes. */ > + if ((flags & SEC_ELF_LARGE) != 0 > + && bfd_get_flavour (abfd) == bfd_target_elf_flavour > + && get_elf_backend_data (abfd)->elf_machine_code != EM_X86_64) DYM if ((flags & SEC_ELF_LARGE) != 0 && (bfd_get_flavour (abfd) != bfd_target_elf_flavour || get_elf_backend_data (abfd)->elf_machine_code != EM_X86_64)) ? Jan > + { > + fatal (_ ("%s[%s]: 'large' flag is ELF x86-64 specific"), > + bfd_get_filename (abfd), secname); > + flags &= ~SEC_ELF_LARGE; > + } > + > return flags; > } >