From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 9B74E3840C26 for ; Thu, 31 Mar 2022 06:22:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B74E3840C26 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-37--L8W7mjyNvq_8fSw84d2Cw-1; Thu, 31 Mar 2022 08:22:14 +0200 X-MC-Unique: -L8W7mjyNvq_8fSw84d2Cw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MTrhMO4b7uST23RHNwZFvpci/PODoh7UDnsHNfJIr8GafHAKxm+i3XfcwoAXuvcSFQlkz9OkrY07TuqO42t6c5BPJBTM6z6/iG9+6b/Om6FXBmXPEe4Cuz44Pza09w7/tOX/pu1HGYLiERwThgoyreb1fjX2FHXBprsTN0P2OOMxD+nl7F8QlaMB5WB1zZODDQQwPsLbesiygBNaNQxwfndjlcc7G/DoLp3S38xAefkh+z+qtGC/QexFeFr7R5c9dmTvg4aPugt9K6YDX9qb5hhtq4oBHGmV3R8cdeghgMUofIRXKYGl3R3ECaKX+xLY0XC0hNSLEdC4FncGhxUpoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFiUNe5NJGGCjZEFM6/Us6JH+U9fgpvwP9epX2oLUaA=; b=iZ0kJBOazfNYLiGYh5z2ZZk015RITAYDpba0ca2akTABDWI9aiZ+As+PikwC4X7UNrGpZvX/32UnQGbhD4K4H6qM3gyzt+LL5kEjKhaQAYs88k77HIFPhn+nSs2XXayLJzi/QegyWREjJPu1GHP5w8sA+VWMjvJ/uv+8AJJZtkrOH7kIWJwIwFtqLoKTGGV3zqEtq6vpK98t283652kicZjnAyYQNjhxvRXGt90tl9jzyuAHmWpSCqnTz/ODyw1f7fjBLUZVyNMlRKmOQEin7Nckq4qG4PSWb15MK5TX2/3pXkjLxjcnO1BKQ0ulUA4qxETdiKVZWvcuJpC3ws/ZFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by DB7PR04MB4601.eurprd04.prod.outlook.com (2603:10a6:5:2e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.21; Thu, 31 Mar 2022 06:22:11 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476%7]) with mapi id 15.20.5123.021; Thu, 31 Mar 2022 06:22:11 +0000 Message-ID: <2b2801ff-0bc4-2680-2526-74dd87be3ea0@suse.com> Date: Thu, 31 Mar 2022 08:22:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] gas: copy st_size only if unset Content-Language: en-US To: Fangrui Song References: <20220331033729.1813121-1-i@maskray.me> Cc: binutils@sourceware.org, Alan Modra , Nick Clifton From: Jan Beulich In-Reply-To: <20220331033729.1813121-1-i@maskray.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0156.eurprd04.prod.outlook.com (2603:10a6:20b:331::11) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 796a6add-97cf-469c-c176-08da12deca46 X-MS-TrafficTypeDiagnostic: DB7PR04MB4601:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ll/836A9US9kBwVSYJnpevSV7/R/PWgpizLtIjhjF2Q93cPlH7mIMZn5c05Wqm9nq+4XlDOunz6Q6DjWI2XQG1Hf9SZvFEb46JIcf6bgqnGshQA0MxNB/rEU3+8zG5jJcWBWctbJvuGLh6aBtKGaHI9dQUpeZ0Ptc2bFVZtKNf9dXFDPYHCEWuTFL/HHKe2K8qDJKvZN73OIULcERVZnQKnHsPfaJnqiofJACblklmBlEAB9/g24YIO/APT6zwmnqcXUPrgdGUg/5m2dGjUisrXOual0q0gOAEx4LhuS/CFaaasoc1mrQcB9IaDU3RlzrHPSy1yF+TJdi6fYAWMw/r0pGjTpdXaku7r89iwH5XWQu0i0OzrHUlgfk/3X5w8kqjfse/UKF6ApAE3gHAM1f6QMuvjVEmmmLwScY2+9pIhTvfEEksIlp7NEKsZ3dWr9hjMX4A0bzNwIb81yFIwnAqmFw/PzkXkaD4+rz8/MTb2YcffQTnPsMG9IqPLH04oU2pV9s2X8LEZuTjuS1TZBn6py9pQLII1qksJNGPzbKzvnJToQB7DFN8AoxreoAm+u9rbfMJVcSENBegDL2Lm79JB+8NS+tPVubShba6yDXwUXeg7P1qnIyUgg5SrngO/LOpgq3WyUuRIBZvLDx7BNr/CqAW4R/NdvDkaTNUQEeYHdiARulufzu2AcaqolRcNU3OBvnlqgSeKvMv3JZUk/BEtwdEd0aWz3Vf9Hasvd5hX4DLeMJUb53IczwcuyYWmK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(38100700002)(508600001)(26005)(31686004)(6916009)(6506007)(186003)(316002)(54906003)(53546011)(36756003)(2906002)(66476007)(66946007)(4326008)(66556008)(8676002)(6512007)(8936002)(31696002)(5660300002)(4744005)(2616005)(86362001)(781001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDV1S3VoRDl4SkE3SmhaeWlhR0NKdzd0cVJLM1E3cjZxcWliSDkvZ2JsVFdo?= =?utf-8?B?Y1lRU0s4emFVS0xyQXNiQTBudGJrTXJQY2ltcW1WS1haUitWcFhseVo0QStr?= =?utf-8?B?OTI0QU1sRWdnQVNLOHc5dEs5dGlpYVB4bnhnTWNjeUlyVnFmcnZLQXFwRW5P?= =?utf-8?B?cUFqKzhCL3d1b1ZJMDhPaEdDcmF3L0JSeU41anlCbWlhdFZPUWt5WUJoTkwz?= =?utf-8?B?Z01rbnBRNTdJYXk4eE1pdWk4TlZoVVNBZG1GUURMZmhLbVd5YXJoRG5SNVQ3?= =?utf-8?B?WXZ5OUVwL0k1dklBL2JlWERZcm5SY1dteUhCbno0TEZFVmZkdHpWcHZhMWp5?= =?utf-8?B?N0RIZUFXSmhMOXhhWUEycmIwSmxEV3FBdzNGM2l4TndudVhTUGhwc1RFRTJ5?= =?utf-8?B?eW9NdVZkVWFpV2ErWXVsdzgvbzJTMmUwVUVRQVllUmFybTAvcEJXemdtbW45?= =?utf-8?B?S1dDS0ZnMXByRFVhdFRNaStRaVJNaGQvL09nWE9zdG92MjB0Z1VyZUo5K3hZ?= =?utf-8?B?cVA1L0FrOG4rMFZqcFliT0UwRk1YKzZXSnRtQ2VzZFA2TjFkekY1VCtyMUJV?= =?utf-8?B?K3BLSWVWcVphUWlZTDhUdG0wVE03ZUszcE53UURLa1VCelQvWWovb21Eb0U5?= =?utf-8?B?QXdUa1U4STVucWdZdzVjK1FCZDlvQ0ZoT296VWdHQTVna2JsVWJhOVBjeCtJ?= =?utf-8?B?Z3k5VC92djAvMEJFbTl0SWxma2ViTTYyZDRuK0FxOFhyeDFaUXhkNlhkQVVI?= =?utf-8?B?R2FFRms1cGdGeHFzWDZrcmU1OHNmb3NjYnIvN0t1bHhmRno1a1pOcEtKRDd1?= =?utf-8?B?OU15WGdReDhpeSsvejAxNCtMY0tOSkZDeEhuTzhraXFva2dlMlNRdThFNGZL?= =?utf-8?B?SklmYUhxZkJmVm1UVHlVVVZvVHFCU05rR0lDd2FjSWhlem81VXkzVW5yWHNn?= =?utf-8?B?cC84dlFUY21IcnhsTGVzVVlRM0kxVzY4Njd5czdOeDlLRE95a01CNjZDMTN4?= =?utf-8?B?QW9YeWV3RUhWNlYzM1RmbG9manc2QU1TYmhpNytQQkFuSUdzdXZjSnZ5QVNW?= =?utf-8?B?ZitpQ0pUc3VKQndxcldlTm1WU2RDQ0Vjd1BZT1JyUDhkZXB2WHRYWmFodDRU?= =?utf-8?B?ckdUeURPV01ORXQ0V2taT0VmR2E0ZTNoSE9ZbmRoYWppT204cEtUNGtIY2JF?= =?utf-8?B?ZVBubnlobjRHUk83dHZzZUJaQUpYcDQ0anEwdnRQM1J1K0ZCWjV4bkZWOU4v?= =?utf-8?B?a3ZjQUZSemhTeWhsaWtzTFQ5eklPSUM3czhPQVQxTEZDWmhXZDFVeFNqajlk?= =?utf-8?B?elFoclluZVNnNkIxMVR2ejFsclpYK2NxWHVUVlNTL2RwZytjVGpOL3ZwZ1U3?= =?utf-8?B?YkFPaEZtRVBiZnVmNEJMT3NPWmtyWTd1K2cycURVT0pldURrTk1xMGt0c0F3?= =?utf-8?B?cHZqeHJRZ0xwd24zYW5kVWpIVTg3OU54SXVZYWVqeXBHV3BrUzB6N2dYbE1T?= =?utf-8?B?bXcwNGF4dW1heG9qWHdCK0Y0dnNjWGxrT1VlcFN3TXRSalhJSDFORkN3bUdC?= =?utf-8?B?WHAzeXZFNzN2TVBONnJBd0ZUTVJUdEwwMTE0dFZWeFBUNnltMVZvTEozbzFS?= =?utf-8?B?Z0l2VG5QdGtxdUJrdlJzK2VkV2tHdCtycEpzOGdZSzZWTU04ckJiK3ZyMGd6?= =?utf-8?B?cTVudTlWMWNZelkzTm9FcmF2Y21qd1BIak4zZ3IzU001ZVkxaENrSW1IcUdl?= =?utf-8?B?SFQxcEVOY0xRemwxZmFadEdNVkNXZFZ5ZFVOek1pWDhpQlFZcDJQTmdBdk1z?= =?utf-8?B?SDIrN25kZ0tFdEdleWw5UEtZR0hjNUFHRFp1UmR5NG9TcEplOWlJTDlVK2ZM?= =?utf-8?B?ditWSUNlM2YrcUJSMVNWck95VFBMVFRRSngzeit0U1plR1N5aUJjYlkyeVRS?= =?utf-8?B?cVIyWDVNU0dxWWRobWVRQ2NYbCtWdmJmSXFsck5ZTG1JS3NjTlVYYis5R0ZB?= =?utf-8?B?OGxIVlZmYURlMFdWdDdwTHp5MDJhellZa0lKQXl0N002Ym1hTGNkSC9VRHdT?= =?utf-8?B?dGdLZ3pKRitGdHVXa1RqaGFWeTdqb2ZxaUxTL3JQYzk4TU0ycTlDYmsyWmpE?= =?utf-8?B?bjlQYWVTR1lsUlFPSjYxcTNwbWtZYzNmZkhiY3Q5VUx3Mmpxc2ZSZHpua0R6?= =?utf-8?B?eGlRUTk0RFRXSXA1UkpUYnBJTy9CV2kxSGV2eU1qK0hnUjNIcjVTQnpBaWM3?= =?utf-8?B?ZXhKTTZneCtlaW5WdWllRVgvaExBMEVTdy8yUmw1blZHY1lJSnYyck9KYmNQ?= =?utf-8?B?ZzMwOGZHVHY4M3pSaUgvMGpad1VFNE9McjJNdHVWMHc3alZic1lvQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 796a6add-97cf-469c-c176-08da12deca46 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2022 06:22:11.5770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eU/3mF/UOvaCyCmAtZErFivSk33zdrFt1oegEZ3R3FIU+WQ6xLJrWF3Z2giK4/L3/EQz12gNQq3S7Fcoy4BTpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4601 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 06:22:21 -0000 On 31.03.2022 05:37, Fangrui Song wrote: > For > ``` > .size foo1, 1 > foo1: > > .set bar1, foo1 > .size bar1, 2 > .size bar2, 2 > .set bar2, foo1 > > .set bar3, foo2 > .size bar3, 2 > .size bar4, 2 > .set bar4, foo2 > > .size foo2, 1 > foo2: > ``` > > bar1's size is 2 while bar2, bar3, bar4's is 1. The behavior of bar1 makes sense > (generally directives on the new symbol should win) and is relied upon by glibc > stdio-common/errlist.c: But what about foo1: .size foo1, 1 foo2: .size foo2, 2 .set bar, foo1 .set bar, foo2 I would think bar's size should end up being 2 in this case, whereas I think it would end up being 1 with your change. Jan