From: Jan Beulich <jbeulich@suse.com>
To: "binutils@sourceware.org" <binutils@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>
Subject: [PATCH v2 4/4] x86: extend LEA's segment override warning to applicable MPX insns
Date: Fri, 14 Feb 2020 11:44:00 -0000 [thread overview]
Message-ID: <2b37489d-aa20-9c84-08b9-515de2032d12@suse.com> (raw)
In-Reply-To: <1fc51e5f-f2d6-67d5-a034-11b32a1e750f@suse.com>
Besides LEA there are a couple of MPX insns behaving LEA-like, which
should be warned about in the same way.
gas/
2020-02-XX Jan Beulich <jbeulich@suse.com>
* config/tc-i386.c (process_operands): Also check insn prefix
for ineffectual segment override warning. Also cover BNDC* and
BNDMK there. Don't cover possible VEX/EVEX encoded insns there.
* testsuite/gas/i386/lea.s, testsuite/gas/i386/lea.d,
testsuite/gas/i386/lea.e: New.
* testsuite/gas/i386/i386.exp: Run new test.
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -7195,7 +7195,8 @@ duplicate:
}
if ((i.seg[0] || i.prefix[SEG_PREFIX])
- && i.tm.base_opcode == 0x8d /* lea */
+ && (i.tm.base_opcode == 0x8d /* lea */
+ || ((i.tm.base_opcode | 0x010001) == 0xf30f1b) /* bnd{c[lnu],mk} */)
&& !is_any_vex_encoding(&i.tm))
{
if (!quiet_warnings)
--- a/gas/testsuite/gas/i386/lea-optimize.d
+++ b/gas/testsuite/gas/i386/lea-optimize.d
@@ -10,4 +10,12 @@ Disassembly of section .text:
0+ <start>:
[ ]*[0-9a-f]+:[ ]+8d 00[ ]+lea[ ]+\(%eax\),%eax
[ ]*[0-9a-f]+:[ ]+8d 00[ ]+lea[ ]+\(%eax\),%eax
+[ ]*[0-9a-f]+:[ ]+f3 0f 1a 00[ ]+bndcl[ ]+\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+f3 0f 1a 00[ ]+bndcl[ ]+\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+f2 0f 1b 00[ ]+bndcn[ ]+\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+f2 0f 1b 00[ ]+bndcn[ ]+\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+f2 0f 1a 00[ ]+bndcu[ ]+\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+f2 0f 1a 00[ ]+bndcu[ ]+\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+f3 0f 1b 00[ ]+bndmk[ ]+\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+f3 0f 1b 00[ ]+bndmk[ ]+\(%eax\),%bnd0
#pass
--- a/gas/testsuite/gas/i386/lea.d
+++ b/gas/testsuite/gas/i386/lea.d
@@ -9,4 +9,12 @@ Disassembly of section .text:
0+ <start>:
[ ]*[0-9a-f]+:[ ]+36 8d 00[ ]+lea[ ]+%ss:\(%eax\),%eax
[ ]*[0-9a-f]+:[ ]+36 8d 00[ ]+lea[ ]+%ss:\(%eax\),%eax
+[ ]*[0-9a-f]+:[ ]+36 f3 0f 1a 00[ ]+bndcl[ ]+%ss:\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+36 f3 0f 1a 00[ ]+bndcl[ ]+%ss:\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+36 f2 0f 1b 00[ ]+bndcn[ ]+%ss:\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+36 f2 0f 1b 00[ ]+bndcn[ ]+%ss:\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+36 f2 0f 1a 00[ ]+bndcu[ ]+%ss:\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+36 f2 0f 1a 00[ ]+bndcu[ ]+%ss:\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+36 f3 0f 1b 00[ ]+bndmk[ ]+%ss:\(%eax\),%bnd0
+[ ]*[0-9a-f]+:[ ]+36 f3 0f 1b 00[ ]+bndmk[ ]+%ss:\(%eax\),%bnd0
#pass
--- a/gas/testsuite/gas/i386/lea.e
+++ b/gas/testsuite/gas/i386/lea.e
@@ -1,3 +1,11 @@
.*: Assembler messages:
.*:3: Warning: .* `lea' .*
.*:4: Warning: .* `lea' .*
+.*:6: Warning: .* `bndcl' .*
+.*:7: Warning: .* `bndcl' .*
+.*:9: Warning: .* `bndcn' .*
+.*:10: Warning: .* `bndcn' .*
+.*:12: Warning: .* `bndcu' .*
+.*:13: Warning: .* `bndcu' .*
+.*:15: Warning: .* `bndmk' .*
+.*:16: Warning: .* `bndmk' .*
--- a/gas/testsuite/gas/i386/lea.s
+++ b/gas/testsuite/gas/i386/lea.s
@@ -2,3 +2,15 @@
start:
lea %ss:(%eax), %eax
ss lea (%eax), %eax
+
+ bndcl %ss:(%eax), %bnd0
+ ss bndcl (%eax), %bnd0
+
+ bndcn %ss:(%eax), %bnd0
+ ss bndcn (%eax), %bnd0
+
+ bndcu %ss:(%eax), %bnd0
+ ss bndcu (%eax), %bnd0
+
+ bndmk %ss:(%eax), %bnd0
+ ss bndmk (%eax), %bnd0
next prev parent reply other threads:[~2020-02-14 11:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 11:41 [PATCH v2 0/4] x86: segment override handling adjustments Jan Beulich
2020-02-14 11:43 ` [PATCH v2 2/4] x86: optimize away pointless segment overrides Jan Beulich
2020-02-14 12:06 ` H.J. Lu
2020-02-14 11:43 ` [PATCH v2 1/4] x86: extend LEA's segment override warning Jan Beulich
2020-02-14 12:03 ` H.J. Lu
2020-02-14 12:06 ` Jan Beulich
2020-02-14 11:44 ` [PATCH v2 3/4] x86: adjust segment override prefix emission Jan Beulich
2020-02-14 12:09 ` H.J. Lu
2020-02-14 12:17 ` Jan Beulich
2020-02-14 11:44 ` Jan Beulich [this message]
2020-02-14 12:05 ` [PATCH v2 4/4] x86: extend LEA's segment override warning to applicable MPX insns H.J. Lu
2020-02-14 12:08 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b37489d-aa20-9c84-08b9-515de2032d12@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).