From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id CA70B385802E for ; Fri, 5 Aug 2022 07:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA70B385802E Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 37FA5300089; Fri, 5 Aug 2022 07:45:32 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Jan Beulich , Cary Coutant Cc: binutils@sourceware.org Subject: [PATCH v2] gas: Fix a testcase broken by new ZSTD support Date: Fri, 5 Aug 2022 16:45:30 +0900 Message-Id: <2b7fa463eb7c9a6b78c8d02fd61c2a243bc3a9ea.1659685511.git.research_trasio@irq.a4lg.com> In-Reply-To: <88262e9dfc11097d08b552171f1af2e8e026f554.1659683506.git.research_trasio@irq.a4lg.com> References: <88262e9dfc11097d08b552171f1af2e8e026f554.1659683506.git.research_trasio@irq.a4lg.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 07:45:36 -0000 The commit 1369522f36eece1b37139a81f7f2139ba3915172 ("Recognize the new ELF compression type for ZSTD.") added the new ELF compression type but it accidentally broke a GAS testcase. Since testing for the section type "2048" (SHF_COMPRESSED) is not going to be portable in the long term, it now tests SHF_STRINGS ("32") instead. ".word 0" should be okay to represent no null-terminated strings. gas/ChangeLog: * testsuite/gas/elf/section10.s: Use SHF_STRINGS to test. Put an empty string in it. * testsuite/gas/elf/section10.d: Reflect the changes above. --- gas/testsuite/gas/elf/section10.d | 3 +-- gas/testsuite/gas/elf/section10.s | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/gas/testsuite/gas/elf/section10.d b/gas/testsuite/gas/elf/section10.d index d51bd4e36e5..4ab3e8e56e9 100644 --- a/gas/testsuite/gas/elf/section10.d +++ b/gas/testsuite/gas/elf/section10.d @@ -13,8 +13,7 @@ [ ]*\[.*6000000\]: OS \(.*6000000\) [ ]*\[.*\][ ]+sec2 [ ]*PROGBITS.* -[ ]*\[0+00806\]: ALLOC, EXEC, COMPRESSED -[ ]*\[: 0x[0-9]+\], .* +[ ]*\[0+00026\]: ALLOC, EXEC, STRINGS #... [ ]*\[.*\][ ]+sec3 [ ]*PROGBITS.* diff --git a/gas/testsuite/gas/elf/section10.s b/gas/testsuite/gas/elf/section10.s index d52b3458fb1..8b140715fb0 100644 --- a/gas/testsuite/gas/elf/section10.s +++ b/gas/testsuite/gas/elf/section10.s @@ -3,8 +3,8 @@ .word 1 # Make sure that a numeric value can be mixed with alpha values. - .section sec2, "a2048x" - .word 2 + .section sec2, "a32x" + .word 0 # Make sure that specifying further arguments to .sections is still supported .section sec3, "0xfedff000MS", %progbits, 32 base-commit: 731d2cc1d5106c077584bd83e96dbba4f7e11118 -- 2.34.1