From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9C27E3858CDA for ; Thu, 30 Mar 2023 15:50:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C27E3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 32UFoYfZ017070 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Mar 2023 11:50:39 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 32UFoYfZ017070 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1680191439; bh=3deSbY9y3l2WJR7dRpEcvJ2Ps5wpPO+Jrqw3FZxzcD0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=sNIQo2Xv2AIxYj5Cahg0a7ZqGChHRsKelGf7GMy0KmXTSTWxBcrUwsYYiNNmU/aab 7pEuXICZLsLhq7KSPVl8ckjs6fhWo9KgRrITk4mdG6qRdTzUIrzJ48vTgOIy54oadZ gYuBAq740WqjulklqdbU1PFN/P2LeOFVF3yVDobY= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B27531E0D3; Thu, 30 Mar 2023 11:50:34 -0400 (EDT) Message-ID: <2bdfbe35-8159-32e0-bac1-1586e5294c2d@polymtl.ca> Date: Thu, 30 Mar 2023 11:50:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 42/43] aarch64: Add support for strided register lists Content-Language: fr To: Richard Sandiford , binutils@sourceware.org References: <20230330102359.3327695-1-richard.sandiford@arm.com> <20230330102359.3327695-43-richard.sandiford@arm.com> From: Simon Marchi In-Reply-To: <20230330102359.3327695-43-richard.sandiford@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 30 Mar 2023 15:50:34 +0000 X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/30/23 06:23, Richard Sandiford wrote: > SME2 has instructions that accept strided register lists, > such as { z0.s, z4.s, z8.s, z12.s }. The purpose of this > patch is to extend binutils to support such lists. > > The parsing code already had (unused) support for strides of 2. > The idea here is instead to accept all strides during parsing > and reject invalid strides during constraint checking. > > The SME2 instructions that accept strided operands also have > non-strided forms. The errors about invalid strides therefore > take a bitmask of acceptable strides, which allows multiple > possibilities to be summed up in a single message. > > I've tried to update all code that handles register lists. Hi Richard, In a binutils-gdb build with --enable-targets=all, I get: make[4]: Entering directory '/home/smarchi/build/binutils-gdb-all-targets/binutils' CCLD objdump mold: error: duplicate symbol: ../opcodes/.libs/libopcodes.a(aarch64-dis-2.o): ../opcodes/.libs/libopcodes.a(aarch64-dis.o): reglist mold: error: duplicate symbol: ../opcodes/.libs/libopcodes.a(aarch64-dis-2.o): ../opcodes/.libs/libopcodes.a(aarch64-dis.o): __odr_asan.reglist mold: error: duplicate symbol: ../opcodes/.libs/libopcodes.a(aarch64-opc-2.o): ../opcodes/.libs/libopcodes.a(aarch64-dis.o): reglist mold: error: duplicate symbol: ../opcodes/.libs/libopcodes.a(aarch64-opc.o): ../opcodes/.libs/libopcodes.a(aarch64-dis.o): reglist mold: error: duplicate symbol: ../opcodes/.libs/libopcodes.a(aarch64-opc-2.o): ../opcodes/.libs/libopcodes.a(aarch64-dis.o): __odr_asan.reglist mold: error: duplicate symbol: ../opcodes/.libs/libopcodes.a(aarch64-opc.o): ../opcodes/.libs/libopcodes.a(aarch64-dis.o): __odr_asan.reglist collect2: error: ld returned 1 exit status > diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h > index 61afe561a12..ef59d531d17 100644 > --- a/include/opcode/aarch64.h > +++ b/include/opcode/aarch64.h > @@ -1122,6 +1122,19 @@ struct aarch64_indexed_za > unsigned v : 1; /* horizontal or vertical vector indicator. */ > }; > > +/* Information about a list of registers. */ > +struct aarch64_reglist > +{ > + unsigned first_regno : 8; > + unsigned num_regs : 8; > + /* The difference between the nth and the n+1th register. */ > + unsigned stride : 8; > + /* 1 if it is a list of reg element. */ > + unsigned has_index : 1; > + /* Lane index; valid only when has_index is 1. */ > + int64_t index; > +} reglist; Probably because this last "reglist" shouldn't be there. Simon