From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C206839AF4E4 for ; Fri, 16 Jul 2021 14:04:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C206839AF4E4 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-269-6c-CnsJZNa6ZX1US80pn2w-1; Fri, 16 Jul 2021 10:04:43 -0400 X-MC-Unique: 6c-CnsJZNa6ZX1US80pn2w-1 Received: by mail-wr1-f72.google.com with SMTP id i10-20020a5d55ca0000b029013b976502b6so4901573wrw.2 for ; Fri, 16 Jul 2021 07:04:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pedmGDhV8R/ssMr6HBz+auiRcitZce+AljxKlETnrsY=; b=gkL7U3JrgeJzIbATMln+MKdw8jYF3qUTrf4Ym1FQWZN+I5GNqNq2uom8XHjSsK9GB6 6eak12j00vucjc4Z9lBNQS6BRFM0mD9PtSZXM2jf9C6Ht7fsGpVTPX0JEVb/nDtGmo+l Qr18uKv6uvmOkvn8QITnVarsCVcU4gz2z77shNL0AyKbR/JkG4McxU34K4ed4PzQXMjF f/hYqVzEXz0z1EX9INR7g2hBu9/9/Zh7IHX7UiQzBLJbprR9kT6XDep+Z6386WSJET7X v/NsB8IfRMZi5f82gGcrKj06UAk9orynaJAuaepWYlZ9wDAh6LghzenyjatLHYxaBaG/ XmnQ== X-Gm-Message-State: AOAM532uvZBgnm5MeZl+/2hnc8dKSUXCwkj/YGEfS/+GHwCWzBvVy2b4 bK02eB5jgBkvVRy8pI3fLzmACxizvq8ARLq7EkjfdSIXSX1qWtohhCVAayzcQRwrNS8Rr/uJFaB 9gRi93B8BINGK8XnFuA== X-Received: by 2002:a05:6000:1c4:: with SMTP id t4mr12697868wrx.181.1626444281972; Fri, 16 Jul 2021 07:04:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLpAj0Ivjlvi+xMUvEhyyOAAGoLwXllVSc0cl1Q8zxOJF8NUABy9xQcFzAHuRhlgMqJcAOCQ== X-Received: by 2002:a05:6000:1c4:: with SMTP id t4mr12697846wrx.181.1626444281797; Fri, 16 Jul 2021 07:04:41 -0700 (PDT) Received: from [192.168.1.5] ([80.168.238.114]) by smtp.gmail.com with ESMTPSA id x18sm9767380wrw.19.2021.07.16.07.04.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jul 2021 07:04:41 -0700 (PDT) Subject: Re: [PATCH] or1k: fix pc-relative relocation against dynamic on PC relative 26 bit relocation To: Giulio Benetti , Openrisc Cc: Richard Henderson , GNU Binutils , Richard Henderson References: <20210712103256.2275617-1-giulio.benetti@benettiengineering.com> From: Nick Clifton Message-ID: <2c9bcabe-99d0-c305-26aa-08fee85654d3@redhat.com> Date: Fri, 16 Jul 2021 15:04:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210712103256.2275617-1-giulio.benetti@benettiengineering.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_STOCKGEN, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jul 2021 14:04:48 -0000 Hi Giulio, > use a separate entry > in switch case R_OR1K_INSN_REL_26 where we need to check for > !SYMBOL_CALLS_LOCAL() instead of !SYMBOL_REFERENCES_LOCAL(). Patch approved and applied. Thanks for reporting and fixing this problem. Cheers Nick