From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2064.outbound.protection.outlook.com [40.107.247.64]) by sourceware.org (Postfix) with ESMTPS id F0E8C3858C53 for ; Fri, 25 Aug 2023 13:01:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0E8C3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxpikPZNr0IVDw6FIYCfsuHihe4FK/xkjcjgy+l351SkPeGszLmcX/i0gwflMnXHv+Cnk0evj3nrrJ2omJ8O7KPt1io4Ww2+tWZTz3PtFA8boUTk5WylTueZlVZlwfI6kvN55oK8F3Xkdt4SnTLa5QcitZl0i9Q8FdhYDkswnajfiKx4zEYZOXfiMDwrliuhlOWy0FG/TEHsrNXGy+wuuAzOKYwIxZNj66HwhXri59mX+1EouzJj5a64Hm4uiU4GeGyMWonrPd0mKhkX4W9H2ztwVISr6+PYd3GlB+EwPXYdmK83Gp91w1cSBAfNoKuJVNqeDstegZT5ik3jNytBYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1pmihrVZ8nRFmdtzzCewj8U+/VdjXHyts/ExUz+QZzA=; b=E3/bTArdx2opBDOXu9D/nBJrjGmTCzFqPndxPkBrGTGu5kmEh+JjHSZlt9pjZ0xp8I24RsksMhlovQnqzFhehZRksuxlsW444nfULhMVxPcRSHe3axcWmVQqvXpnoHMRhkq3eyOrshIriKdCvhrDSFoLDK7P68LWILo9F3L40lvXR+jA1tpdLrGK0vdabXsWC7dF1Qk03UbtaWrnL6VrLozsd+48W1rOWg35HmtktFdEdO05YqxhGdNoPepWQhfksiVhNWszqVX7SuAwLDjrSs3Ua2tG6eDRn+sCRNuiR78Ld7SYSXFIIwVbf4E63srliZowYCeZZD0edZF+7BLYYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pmihrVZ8nRFmdtzzCewj8U+/VdjXHyts/ExUz+QZzA=; b=aC6z1MLBwihAdFc9PULRzBC+8aBOgwQnPGK8dffhzLCqWZX2zMh90sPAIF3zxEz384kGLXNmVr7g4daGtnLjYqd8Zm2mzZeJlKt+Cj4eCFVraMWS9jfmCHkBvUswPtOJReb/rv9VWWExwBOeD/6T7MK2xvdMfwZ8rexzc2bBv7qs75+FFh5sdM7DJVdhJF73ztVTW2BXJ+GuWfEJRlmUq5QLTSa9w5uE/Laog4OEHv1oQbRXtfVY2+G2pdL2jA2a9CbiFtlvQTyaPKAVIf0mqBNDkrQHZYEpv8e/Gc0VPwHXFbScj6vzT+WXLuhSuOrFhGicNB/bDrmddM52cwWfow== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8866.eurprd04.prod.outlook.com (2603:10a6:20b:42d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.27; Fri, 25 Aug 2023 13:01:09 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::f749:b27f:2187:6654%5]) with mapi id 15.20.6699.027; Fri, 25 Aug 2023 13:01:09 +0000 Message-ID: <2d277339-6428-4197-6951-4698ede1edef@suse.com> Date: Fri, 25 Aug 2023 15:01:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] RISC-V: move various alias entries Content-Language: en-US To: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu Cc: Binutils , Tsukasa OI References: <453ed3cb-35cf-46ec-b323-f7fe7cfe7d39@irq.a4lg.com> From: Jan Beulich In-Reply-To: <453ed3cb-35cf-46ec-b323-f7fe7cfe7d39@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0139.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8866:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cbcae68-4b9f-422c-0f72-08dba56b5a32 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TfabWcVbUP5MMMOZM7K4sDvb7VRErHLfG0bFkoCjV+VoWWOL0a4i1tye94g4kr1JbMez6VdEZwo66FF+d2ekLe/Yy87GJa+oMo1DtvLERKr94CehSjFnWdBYcE/GP9BkSgq0cplCx6ojKYnxKbORVt4udJKMEvBOU3WsNBlJqwKJ0Wzch56tWZe7J/3DljT8SkKnfdR7Q0y4GSlvegEiv0vrVpAQ7OqZUu+TSm1Uhhn7LRZUXu8UVUFXWTjW55tP01c5fCoUrD21AEneM1QY/acbGZxMitf+xk49oI94gxA/Joe7NXwPvQRaWk0mTcY29RyfOQJ5qT9u7mTqlO2y7vldFBPg/s0UnsTR72PzkLla0tEogvgOahjICrF3HXI3M9+KfwV7N/5Pe50VKBXizEwy3m0sU4ViAvLU4ukQIH8ThzPNf9vbKmuRzkp4Gg8H3nlCpbJtu9ouS5bFtchb/1k1xnnOUfl4I67NYyAZn0wOdAOfkNDRUDSTxjqxAh44ECyWlGLoa5JD7PFDAWdDe7MBXqAbdCGG9D61eFUKUset7y7JPZy6AkLOBX7P8hJxxk3/VneiNfTqz0EPWrV0rHyRjYJgrl+T5vdlGQIfZUlVZ6FP9u9VlZwq3ikLrkJj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(396003)(376002)(366004)(136003)(346002)(186009)(1800799009)(451199024)(2616005)(5660300002)(8676002)(4326008)(8936002)(36756003)(83380400001)(26005)(38100700002)(66946007)(66476007)(6506007)(54906003)(66556008)(316002)(110136005)(478600001)(31686004)(53546011)(41300700001)(2906002)(6512007)(86362001)(6486002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUVuNTRMTDBzcnJXZmQ0QjZMYytVcW4zdkY0emlJYy9GRmtPcmZoV1orSVg3?= =?utf-8?B?eXhxeVRyUkI0SGZpVkN0TEVmWmVuWHhzWG01cmpYUHlTMU9ZN2xWUFhLaEhm?= =?utf-8?B?ZXFSKytPbVJaRTNHM2FRajdNNlJDdGR0ZEhRb3VZQ29vTlF2cDRyeC9yVnJS?= =?utf-8?B?bS80UFowOTdsd3lyc3ZvSTVUWXlkdzY1MGdpdUVRZ1d1T09Tem9adTJTcENy?= =?utf-8?B?N3BXYk1JejZCT0JpWVVNWFhTeWc3NE9YdXJha2xPYmF5amEwMmRRUlVVcitF?= =?utf-8?B?YnJPT2pCaEFQd3VVQmkvaWdRVk5PWk5zd3BJbVFIMUUrNFdFRDBrZ0pjQ25M?= =?utf-8?B?NVFxdlJqR2ZkRnVpSklUMitwbFJHSjZ6aEQ2UDBHTFdLbGFMOGUyOWc1azZM?= =?utf-8?B?KzJ4UU8zRmx5d3ZOeTE0ZG5iTkNsNFA0eURIdU9SOE9rV05TR0o0SUZDcjl2?= =?utf-8?B?dTdxa1FpUU5VOVVCYUNsR09vczNMTGZEejhsQWhTOFB3Mm1kRFFiUnc1ZHJu?= =?utf-8?B?NXhQaEozSE9rc3dXbE9xM0IxL1c5bDRRMy9mbGhQVmNscGVPb0VxVnpmVFcz?= =?utf-8?B?RTlTaHRHS1FtZGMwMG1SZEpyTnlQL0tFSkVGMkZtZk0vclFMVlBRUmRQZFk4?= =?utf-8?B?eEhTZUpqV0lRcTZrN3FJR1RJYnFLbXJ0ZitsQW45RmdlbWtPTGQ1dVJ1c3ZB?= =?utf-8?B?K0tZT2h2VXg5Vk5UT1lHSlQ4WHRSNWlVR0NjcGt2UkwyYVlTeHhYT3F1aWZs?= =?utf-8?B?RVI2MjFyOExaRjRFK25GOHJRblZKN0JTZ3JoZUdzUG1iUURCZzNKdUt1NkFi?= =?utf-8?B?bk14N08wQUlVSTZhb2Z4QlEzdWgvNjYxelIzcTlHaG1OTVhLRDNYQkxJSytC?= =?utf-8?B?a3EwRXNYUmRNRisyWUZMaWRScWNjakcwbVMwYVlyQnVxYi9YT2ZRNDdrZzR1?= =?utf-8?B?Vlc0dWVDK3FWd2dINzVxUmhUSU03Q3NHU2duZ3hCd2cyNU1VaEZZTmlDNXlr?= =?utf-8?B?ZHZCLzVwTkdGa0lIc1M5QmxLUVlHcjZqWFd0ZGVYWG02eFdGSER6RDZaQjRL?= =?utf-8?B?ZnVvRG9KbnVJTFFmZTlMREhiUHF5S3VIOEZjTGNhZTNaZkhtWWNJMEpJYVFw?= =?utf-8?B?M0FZdjlJWFczcXg3d0kwUTg5VHl3VXNiRUJ3S0xveVkyZ3YycEhKcVBvNTRz?= =?utf-8?B?dkJPMnJNL2xlMFV6cTJuM0ZTbEhLdk1vS0ZQY2RPZTFMcEsyTnUyZitUcGQx?= =?utf-8?B?SkNnNkxGNStEMzIzSWNiTkJxTW1rTUxXMzhwRmdYTzk3ai9jQlZsdkJiZTh0?= =?utf-8?B?VjJTSVE1YWtwdTBnUmlvTTFiTXlrcW9XUTVIdE50N3p0T01LdnppN0pleFJW?= =?utf-8?B?TDhBanVKQVBXSzJCbUpORlpqbHFzcjdJS3YvazBtTFpqdnlaTWpnbXNsSjln?= =?utf-8?B?ZkF0NXVockdMNWFZNjRyaG1TcFhiSHphVnNHY2M5eE1iWmppY2ZrSWxFK1U3?= =?utf-8?B?MzZZSHczRGg1b1YwYWJIdGJDMlJFMWdHSENyaEJIZ24rTFlqcURFU0c2TFpV?= =?utf-8?B?R3R2aHdmdlJscElmSXcvYmcvVFVlelVkRk13Rk40M3Z3SE53bGN1Q2ErYi9B?= =?utf-8?B?NnVmdGVDS29DekZEWDFSM2JZNlhGOElSblBJbFRwbzJQaU1HcWs2anI5blk1?= =?utf-8?B?eXR1MUU5R1ZNUWx1eVV0cktSWi9SeGJkeE8yQ2tKQnFlQkd5RXpWaXpuZlVB?= =?utf-8?B?Y0hhVVk3WkV0NjE0dXJXOVI4dEtMa2RiMUJ4QVZZRXJsYjNqWmZEWG9JMFhR?= =?utf-8?B?US8rZ0dFYld1TnV5WndoeE5FcHhWazVxalNOTnJsR0xWdzFreW1JcTl6Z1Rv?= =?utf-8?B?NFVEU1lWb2hVNUZwb2ZodEpCOGR2Q2lvRjBYazJDWk5vbldzbThYVHZaYWJi?= =?utf-8?B?dnBiNi9TN1Q2aExNM3R1YlVKRTBPNWllNHlEQzVFaTRwMmVMdmJnK1FhYklN?= =?utf-8?B?c3JIY2h4UXBtSVJNS1NNWG9zd1pIOC9LQnd5RmNzTzV5S05QWFNLUUhvc0xu?= =?utf-8?B?Qmtzalk2VEY4MnJ1UnpMSytpaWRXTExhaWw2c3RXYTRaMVM4dm5mTGNuWXF4?= =?utf-8?Q?HGh4Rdal5jOjI6wxWpGLDVv9a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cbcae68-4b9f-422c-0f72-08dba56b5a32 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2023 13:01:09.8395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: luzU1esR/qHBPBWrkJZ41cGAXD2d6pI3B5KTY4VvJL5YRbKaoz3VTC0D6eylPMsO0M3HSTqoO5uEtx/RIHttVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8866 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.08.2023 03:40, Tsukasa OI wrote: > On 2023/08/04 21:00, Jan Beulich via Binutils wrote: >> For disassembly to only use spec-mandated aliases, respective non-alias >> entries need to come ahead of their alias ones. Since identical >> mnemonics need to stay together, whole groups are moved up where >> necessary. >> >> This partly reverts 839189bc932e ("RISC-V: re-arrange opcode table for >> consistent alias handling"), but then also goes beyond a plain revert. >> --- >> I did not adjust JAL back, to continue to match JALR. The spec doesn't >> spell out how operands are to be specified, and hence it also doesn't >> mention how many explicit ones there are supposed to be. >> >> What about NEG, NEGW, and RET (and perhaps more)? The spec doesn't know >> of those afaics. > > I think JAL, NEG, NEGW and RET are okay as is. > > For JAL, I support Jan's opinion. > > For all instructions Jan pointed out (including JAL with one operand), > they are listed in the RISC-V Assembly Programmer's Manual: > > and should be considered safe > (unlike "add rd, rs1, IMM" == "addi rd, rs1, IMM"). > > I support merging this patch without modification (or perhaps, with > minor modification to the commit message?). > > Reviewed-by: Tsukasa OI Arch maintainers - any view? I guess I'll wait another week or so and commit if I don't hear anything to the contrary. Jan