From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 1FB743858D28 for ; Fri, 22 Mar 2024 10:59:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FB743858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1FB743858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711105162; cv=none; b=i9PRRYYIRhv/EwztrKz1upPkO/Mw7kVnQGvEzyDV1IfAQzhYUOOduVRL4AKfjNyCCsfxXC/mSym+uICTkCqX4f8oru7mnkOe4t+9s68kkUVr2AHkLPD86Sh5wEnKOE+fdoy/0w0B08TIp+LFnMxb5/+aGtmz/SGN/BxO820ARKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711105162; c=relaxed/simple; bh=h7wfbOeLoi4YoQ4O9CuCkVa7LbBMaCufIFPXKNyPouQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=IvzcJhqOzlSmIWk1eMJo/brqpiwsQ05C89D2TK/wANfVAotIiNGJ4YJjeEbz70klhxXOeWcol0N/rMYcmzG+JvKuZjJh/HXDcYQI2sEjraZErf3GTNT0SYmxeP6+ZarTJAAovzMW9j3E5/BHawJPXpa+BcyRc9JBtYyoGxpi1d0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-56bdf81706aso865151a12.2 for ; Fri, 22 Mar 2024 03:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711105151; x=1711709951; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=gxeRBsyhN9HZhn8Za4/aG+Hmx8cosXpX00TGFwOxOuM=; b=RPBOPNNTpcdrj9kdhzgVZwzeBEUHVWxqVGJHZKbXREX3jNiFy5jtzhMi/ndkivTluS U920xl7Hl9hpEvPSZm0Z1R8AwO4hSP+6okhywsCDa7t/PeTpJwvJLqkUJuqMvsoEQSeg bgBP9dfB/EmS8XoCnD15hsgYkaV+01HJYQo/5k9ZXuQ3yQ/8PSeTFmN6d/VsopFqbaJT F9RKYs6g3QP/pHk2mjgmuDUdeshzw33cmAnUNaKqSA2LH0hciAdicT3dkpacS31/LXDQ aah+cJzqOfIsuKaWN25I7VO19F4lXbPSLyJvZ6kgiwQEiCyhGbDEAAJwvk6zNva9IG2M o6bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711105151; x=1711709951; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gxeRBsyhN9HZhn8Za4/aG+Hmx8cosXpX00TGFwOxOuM=; b=CXpyGBrmpWsNjZN5Clt7SaKA41W2wiGLGSI9ct6qTLLfLFDR/Vz7AnAAdnBAdnc8aO ZrQP88vuFNxGoXt6e5EAI2RdDwjR7dKYsXrCA0beB8vUlmBVVWWc0idMr1FOGpKg0SXv Wl21N96xlmkHJh5MmYku60I5z5ODxAua8MLnu9SoaTsmp7BAe0gwOZxj/QIZSKbU8dIu HSxXkFg7bQC8z8v9D1eF/iGtyweKnay7Wk7J3N/Go4OL7nB/e5OwFjmgAiDqEhqu0i06 rrLdx2gg1DiS+mr60TzIeoB9/gTITiiQGZuCptmEUBQxTgmO31AdRDH9xV7a6U4N2Jcd LXKQ== X-Forwarded-Encrypted: i=1; AJvYcCXI9PASXgYIO6yld9AQuaBeSlG2SdCsMvmOEpxGCdUZCOU7n4/9VcrNq7Sdwp4HSKCVHHWOJV5nl1AZuz3e7JpRLtuubTZtew== X-Gm-Message-State: AOJu0YxCwrCHuKbTu+5Ui/lP5ybHtojRQwqjeAusdKtpBtrZdY5B/cpR m+6Ya82x4jVEVtfDS+SB4C95c3796kuaVBplhCkK2wdd4caKMwAARTLt096sLQ== X-Google-Smtp-Source: AGHT+IEXYo0Jw4AhzRj3HSJtgIJVJQKqQWXQQ6bABKPELXgBs86n3sIN/PKFlfaIlGq99g8veFBILQ== X-Received: by 2002:a50:9f84:0:b0:56b:b5a2:bada with SMTP id c4-20020a509f84000000b0056bb5a2badamr1466444edf.0.1711105150804; Fri, 22 Mar 2024 03:59:10 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 11-20020a0564021f4b00b0056bdf694890sm718677edz.43.2024.03.22.03.59.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 03:59:10 -0700 (PDT) Message-ID: <2d45e9ae-5376-4d05-94d4-e1104ba59a11@suse.com> Date: Fri, 22 Mar 2024 11:59:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/9] Support APX NDD Content-Language: en-US From: Jan Beulich To: "Cui, Lili" Cc: hongjiu.lu@intel.com, konglin1 , binutils@sourceware.org References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-6-lili.cui@intel.com> <8077dbe0-4519-4438-a943-5a310ff5f523@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <8077dbe0-4519-4438-a943-5a310ff5f523@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.03.2024 11:02, Jan Beulich wrote: > On 08.12.2023 15:12, Jan Beulich wrote: >> On 24.11.2023 08:02, Cui, Lili wrote: >>> +rol, 0xd0/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { Imm1, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >>> rol, 0xd0/0, 0, W|Modrm|No_sSuf, { Imm1, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } >>> +rol, 0xc0/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { Imm8|Imm8S, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >>> rol, 0xc0/0, i186, W|Modrm|No_sSuf, { Imm8|Imm8S, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } >>> +rol, 0xd2/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { ShiftCount, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >>> rol, 0xd2/0, 0, W|Modrm|No_sSuf, { ShiftCount, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } >>> +rol, 0xd0/0, APX_F, W|Modrm|No_sSuf|CheckOperandSize|DstVVVV|EVex128|EVexMap4|NF, { Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } >> >> Didn't we agree to avoid adding this (and its sibling) template, for the omitted >> shift count being ambiguous? Consider >> >> rol %cl, %al >> >> Is this a rotate by %cl, or a 1-bit NDD rotate? > > Btw, while this comment was taken into account for the "normal" shifts and > rotates, SHLD / SHRD still have this odd extra form. I have to correct myself here: RCL and RCR had such an odd form retained, too (as, perhaps, a side effect of prematurely adding the non-NDD forms there). Jan