From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2049.outbound.protection.outlook.com [40.107.14.49]) by sourceware.org (Postfix) with ESMTPS id E68CC3858D38 for ; Wed, 1 Feb 2023 09:24:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E68CC3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LOYYyplPUu7BCT3dIKpSczEuGIqdFffevXcR9Y6W0YlMX7N6XVjtlnDeYN+Ll3/mhouJsn3TN1CLTICd1u913hZ4Riuu6z27xDvMVRAcnAfhE1ydOHi40sX7oUG9Y9tXTh1Z8i29eSGkLat0FrssnbHgcPzQQ6S2m/D7XK/c/q/vHxEFa530nfabJ1SsDNg70Njkj+20YounW+NmLUjKD4D+/hMJgRtU8Zd/r3gYsDHHvLEX4NAHP1ZKZ9xt3ZcPVp38n/eWvijgDZi/xJjPBRBBE+1m+YiSHbgyHTuHeRVuJIBvGtWvaaAY50OlH7Al6vNC8cklHkwyqoh82/ALxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lOv74VY8NFTF85Os/lgAYarf0PsLUXK9Z+SVk57teTI=; b=XWXcX5St0FrAv60STRYUIc5erkqK8YVCRXEe1r65UylbVBcuuRzXBd1UOf+iFWVkggk6vcUCI8JGgs7JxsQ0UoMni2C70H+jZ/zgNeU3541ThR2oJPfgOvc+zNtFKyKP3lWNSSQpt2mlOOFYt0QNdSHYgzmRIqCuuOHUEhrBy/gpGXajgVhsoduNL0GfA3CsNqsZskfh+RacujSJ4/J77dmHTXBwMyebQZjVMhCRgHVUI6AQc6T8jjoSSXsdCo7x/BLu02wKuGnrstMJNr/FN1jKnd2nQKCFkrItNYzCW+ghtSox3mVPAGLvwc/gSDqFfaMbS5KOqdbmD1VWlmPrKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOv74VY8NFTF85Os/lgAYarf0PsLUXK9Z+SVk57teTI=; b=F0URbX1bEK+QeZueDeh1VxonXR/iW5rqr/AXIfbgWNaktAGgaBQsI/638ASI+8o/oHQkPY1GgQr78BasR6/zyr7t+kWp+Q6BaKY+3Xk2/NGVPvwN8xKMjee3eRCVHDQ2AJXwuU49j+ImcbzNMqYjFgjHGIi4rqrxduFFB7MI5LHDsvC2XZnSmXeF6eeTVqS9aLfUyWeh69n44izPxjfJO7JTmsxn1Ou9D5q6qDrt1cEdjI0BeRUvAbg9rXJRanFYt0Q1b6lnV9/tP+iRG3UyaThSkB+xlDzTqzIpWO4d80jCuTDEyZgsPt3EQl0FYwzbA+VUTjsilj7nhDArsDDABg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS4PR04MB9623.eurprd04.prod.outlook.com (2603:10a6:20b:4cd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.33; Wed, 1 Feb 2023 09:24:26 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::bf72:b6d5:ae40:e192]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::bf72:b6d5:ae40:e192%7]) with mapi id 15.20.6043.036; Wed, 1 Feb 2023 09:24:26 +0000 Message-ID: <2d6291d4-7307-079b-1cfe-54ae6eb0f951@suse.com> Date: Wed, 1 Feb 2023 10:24:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Recursion in as_info_where Content-Language: en-US To: Alan Modra References: Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB6551:EE_|AS4PR04MB9623:EE_ X-MS-Office365-Filtering-Correlation-Id: c5aea4eb-eec4-4987-6026-08db04361cfa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qRI8WxFjiX9zoQCmdPDb6C3VIDdk6qRtUO8vMqWTtIUJ6/xjs68uyWa112WFkuY4vuh3gTKYpVGCaM2aHbsSqutsR+QnmIPnGnexbBXLMBYaFjX78ufwAIqhWz+JFzQarcq3KkH0V51QeVFWycseLqa8IhYDkUAeqiE3f4vC4u0/mjtsrZ2PPxGMuaIp3gaNoRHF61jqmlwl+EQtAwbs0+6g463/SufsFcw+hLFknmUC+7gIw38KthmYGxxIqNd9SzlDQf1uRyivU1XIR7GpEQBOl/xwTLLB2xR9jHL690jDfNOEDMNHovdAwZaR9uFS+NgzDYLPQ6/6iw4n64wE/IXI68xtSpuS1G60rCjYCvHAxA9hyPfTVV/84f81y/6aZuS3HzPlrZmVN+15lHqduXWiLsgWXublM7mXQyQ0Qzu6Fj9ckkzXMGGICmP26G+V2qWwUbKq2iOnVbffBJOpQ4pLbK2RAbsE/bWTg9FrE70ECGvSFMO7Wy3bkvJY9ucGrKWUOzghHAtsii5d74dminG1vGK6gAD6o/qOwQ3d1QRz05qJuZ6QMQvK1tbZzN9r8WOyZdj4bpT1/Gq/ya/Wf18kxTsHLqOnINoxgCKAB4J6c26/JTOMfkQFzLuvQFzFEVK9fS6T1CcV0Uv1OK2YALpJ7oalljsIHqyTddRmP4y7bFNaLGZhHqFWSfNOO/Ze4vnNNsKPT/B3y3bJFOce+9FG/a+MJUH0uqrwdxxM+y0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(346002)(396003)(376002)(136003)(451199018)(4744005)(5660300002)(7116003)(8936002)(31686004)(41300700001)(2906002)(66556008)(66946007)(4326008)(8676002)(6916009)(316002)(66476007)(6486002)(478600001)(31696002)(53546011)(6506007)(6512007)(186003)(26005)(2616005)(83380400001)(86362001)(38100700002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGNLNHBMOTJ1TW82R09xa3h6Tm14b01QZ2gxWG1IemNRajhPeFRudld4U2Ry?= =?utf-8?B?b1NFeTFBVUZtbEw3elQ1aXlUT0EvOVBxWnZSVlJaczdEV2RvM1dKVkZnTkw1?= =?utf-8?B?Q0lIeFExQU9xckgvMERxV1pmaVdEYnVLbEFZaXRhV2lIaDNNcjlFOXlFTmV4?= =?utf-8?B?cXFUNUp2UVhpeGIrK1lERmNrTTk2UEp4M2tTRDA2bGNSSEtrVmtzY3ZyOXFy?= =?utf-8?B?YVJEbWpQZGNPOWxvSllJS05ieDJ6WlE1VFZxcTlIajlaSlhCKzgxKzV2UE9B?= =?utf-8?B?UFVLNzZpbXE2bXNEWTI5dWc2VElQbjV6LzNsVGtuazRJVGhGSnhJSnZPQi9F?= =?utf-8?B?RUh2THNrMTJDeGwyY1ZSVEtrbmd0NzkrY2F6ZWV6TzBUZ3phUFVZMGJZdHMr?= =?utf-8?B?b2NKNFpwU3gvNnQrWVdVcWdnT1pYZVVCbTRoL0dJbnZ5Mm5QUXY5ZXFReU02?= =?utf-8?B?NEQ3czFjb2RwdWIvVWJMUEw1WnlNMHEvTlhrbkU3RE9YSXo4aFI2ay9NOFpT?= =?utf-8?B?ZlFDODROb3BVUHVBUEJmZE9wd1J2V3hPYW4yOVU0V1lMeDd1cHRpeDA4RUE2?= =?utf-8?B?L3RyYW5UNWxpRzlHa05ESGdKcXV2anovNFVYYWZqMTdEZHBKVVJ2T2VjR0RV?= =?utf-8?B?b1NEb2MrYkd6cHkyaEY4V2dCWGFtVThnYUx3VlhKUmx2NVloQ05JNW52RXkw?= =?utf-8?B?VGtUN01xWnhKKzRTZmg4bWtmbjhPQXZIdXU5b0loVXplWm1tcjBnMVlKQ3F5?= =?utf-8?B?cUg4aDNORVpDY25Dd2xlakRwc1FBRmVYZU9MYko3d3pnYlphRjdFdzJMa1kr?= =?utf-8?B?UC8yMkhGWUJJUnMrMHVyTlhGelJOWVpYaXpRRHN6LzlTbTJkeU05MWlYTjRP?= =?utf-8?B?cVBKb20wKzVPVVI3Qzk0cFJsZGNSWEtJemlGWGdoekRlTmx5eXgzclV0bFFw?= =?utf-8?B?cTM3S1RXRERranVrZWR5dEkxSW13SEd6NDdKdXNlVk84RGdUTUJHUFVDeEZh?= =?utf-8?B?bklSTlVnY0dCUVdZOENhMFBjNmpsb0ZmWjZjUzhtdDdvWEJ2NDJKekxiRmdM?= =?utf-8?B?YmZMelVVbXVldGhJZkI4c1FpOWlzRWZIelphTnJLYTFkbmhISTIrSm42QXIv?= =?utf-8?B?TGdEOXpOSytITTFGakV5WmNiUWQ4a0tBcWZJWlJkWGRwZVFmOUJzUDZObVVn?= =?utf-8?B?TlV4dC9OTERIVWdva0t1NEtOQU5jV2VHa2xDRThObUJ6b0tmM1FBTnlCL2tZ?= =?utf-8?B?alZlaHFROGJLdHVvUGlMU3crR1J2WmUveVJUZ1RQWGdjeGN2bWEvaGF6ZTRK?= =?utf-8?B?UkY0UU9OKzgxTzdMMVNoTXhuTmVOUnUrS1MzODQ3UGlYUkVmZmpyMEp2dFBX?= =?utf-8?B?K05MTmVKV2QvOXM5c2U3eFFtVXd0dnloa3BlanRWcWNDa0NUdG9OLzVsNHpW?= =?utf-8?B?NDYvK3dRMmt1VnFUQWJSeFRWZE40Vk9tTjBXeTBGNTBzdktydTV2eEZ4SldL?= =?utf-8?B?WmVtRHA5OXhmeFUvTTl3SVNRRzN1cFNmek9kY2NKS0pjeDNtNFNsbzJta1py?= =?utf-8?B?WnNHMnhTV3lwYk9rVmwwdjNrS2k4TnRBd3VJZ3ZJZG5EREdhYlc0U3YvVXBR?= =?utf-8?B?WSs2WHhsa1J3TW1UaVQwbEt4WGZUYWplbWRPR2xrT05zNTFhcW51MXdPMnJn?= =?utf-8?B?YXRvT2pJeW5MYmxCZktDenJsZHk2N1V1ek53TzNLQmVIOU5ldURBL3l2ZEJS?= =?utf-8?B?ak9kV05uWjlCRkk2UnFzbnRzRGJiYXZiUkxGRmFXWjl2aVY1S0lkb3JCenNs?= =?utf-8?B?MVZiUE9XZTJwZGF4eXhzWC9rWis4OTRoMjJNZk0yM3JoaE1pSHVlSDdCdGlJ?= =?utf-8?B?cU9kcWsyRlFnY2syM3Fjd3BVb29Gd0J2RlpEcXBHZHB3OUxEMTBiZFM4ZEJs?= =?utf-8?B?a3BBeUJ1Z2ovUk9jYjF3TzJYZW4zcm50OVJOeDZkNC9STGc0TW85ajMra2xD?= =?utf-8?B?OElyeWNVMWRQL2ZVbjVuWXRybGM0Z1h2MFUraEt5ZWw3dFI0MUpYRU1yYUNC?= =?utf-8?B?UXkxbVFGaThNWFc4U05XRDJFMzh5NHJGR25aTlVLT2ZUVTdqQ293dUdqK2Er?= =?utf-8?Q?Kp5mDU+bgOuUXDsu3dxXwAguD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5aea4eb-eec4-4987-6026-08db04361cfa X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 09:24:26.6004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d3I5dM2XA30AgJX9YZd4vmQoIBwMevasqAF4T5w17eZFsCx2kk+qiRSHLZhY2G34gMw9EXQI9EjcPPsXzIy6DQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9623 X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01.02.2023 07:36, Alan Modra via Binutils wrote: > This function has a gas_assert, ie. possible call to as_abort, which > calls as_report_context, which calls as_info_where. Attached fuzzer > testcase managed to trigger a stack overflow. > > * messages.c (as_info_where): Don't gas_assert. > > diff --git a/gas/messages.c b/gas/messages.c > index 0db075d779c..7c018acf69f 100644 > --- a/gas/messages.c > +++ b/gas/messages.c > @@ -141,8 +141,6 @@ as_info_where (const char *file, unsigned int line, unsigned int indent, > va_list args; > char buffer[2000]; > > - gas_assert (file != NULL && line > 0 && indent <= INT_MAX); If this go in the way, isn't it that the assertion actually triggered? In which case shouldn't the cause for it triggering be addressed instead, to avoid subsequent knock-on damage (e.g. from de-referencing "file"? (I may want to play with the testcase a little myself.) Jan