From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id CC46D388451F for ; Fri, 18 Mar 2022 07:12:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC46D388451F Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-3--xwMw2nAM4mk49kueX8ozQ-1; Fri, 18 Mar 2022 08:12:49 +0100 X-MC-Unique: -xwMw2nAM4mk49kueX8ozQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LAiUaJO06sM8eDbZz7pVwaRAcIwkMlFhZalWwEdQZ4A/FC9+2RU8Dtidk2vGljzV7nVTS6MlqcGdUTNudWqJNen5rT1W3Kuo9bzXUEWFkQrEQfOsjkGnvdq4tv+YBJtOIxqXaTYoTCDIzWJZv1kA/hKTiTlEm0OwXI9KbjXV4qDqee95OFLg3FnZt9tarxSpLXAFFd7TcEMvFj/ju69q8b+rfcMFwRZ89XVnZKlRfv0dEbfteW9ScdM9N/Svth2YELazqfO95Wk31wAUnQ51tHt0eXDM8q/uaRompN43MzF1ZldMx5Gd0PvfyOtKL1Kbo6TgRjc4FEVRu1ru9QRtnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AxsOROpdNfQQN7J8iv5TStzPc433IRs9YuYU7nnKPYA=; b=EbRpkXX8FLd2csaK06000yutJTZXZRCHGMQ71P/o9SAjb2BysuIigOvpUU979dmJA5AXoILH9c9TknFd2vtOC+03y2WBD81l2lFTI5Gso0fNOBNwo3QC81yG0NJNcWk2sdqSDh60KifjIUMFR0BaIJtGbIz3KZ4Pb/UVdQIf99SPTf6HgW0A2xQ5E2HH4UYZzPw7T9k++YxE7N4aovnH/OW8KzsJl6Nzfa2UbYMo5i+ZFMUFOZJhNqLW61t8F3r8hb5m5AvpjYJKb/ONs1zZx4SSXnBOK6s69LW0pJz0IHXCdBTV7goLdR6IUgCgue8xPShoqd+xHnpHjkkGru17Vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB4280.eurprd04.prod.outlook.com (2603:10a6:209:42::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.29; Fri, 18 Mar 2022 07:12:48 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::2d79:4387:3887:ef9d]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::2d79:4387:3887:ef9d%9]) with mapi id 15.20.5081.018; Fri, 18 Mar 2022 07:12:48 +0000 Message-ID: <2da05d25-9304-bb71-1fee-9370a0171331@suse.com> Date: Fri, 18 Mar 2022 08:12:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: PR28977 tc-i386.c internal error in parse_register Content-Language: en-US To: Alan Modra References: Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0077.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::18) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2603c32c-c54c-4a2a-fdfb-08da08aeb4f2 X-MS-TrafficTypeDiagnostic: AM6PR04MB4280:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lUMWSU1aXajlg02htpREh1O9PXJocR5V+X853zThghUMSXbjhJX0ovi1yeGek7AAUlbG9hbw+anR/fGHlp1VLmuAe1HiOdVMXdatA11j4bG670aPTW4k9FpF2NhPgNkp/r0K094yu8t0SzeO+LlNpajmUtAcavPQPV/a4r/x1oQndFr7gtSPhvFjJcBnoxIPl4EY6ofcDOrxWJ2k/QZzmaF3kw3XsCFzaCKu77ciazS0qEmWaDGqVCybaVC863cFq4hGGT5kafatNF36ZGCAFiyZJCpxzOEZIopSWfSjjCzs026IKDfGLO7JxcwD9ReTk9FPJaQIt+CfvMkT3IzXn8LKkK99mfXugshmStq6o1JyrgPhxPi9iL3QmTmBbgnZoujs7I3TwTxuPuzDZOi9nknygic6EIH199wYjp92aITeqoI8tdoBiBb4K5AVymmYVszGCXDutkhbkTh0tjqkKesW7web/Qu3K5oKc7oTDsVZo7FQ3za213ao62JuW9gOMcL10Ux+4iO+GKMhDd7jkCcVpNaJUp8DtHV+ztcX+C0/+aJP2WaqR9+4YREvQ2nhlZOsR1xATAIn7FODb7xavoczgFnCvLQftPxLIuSp5CmQecnJ8Coodk5GOWOHD9+0lAxthPcZCOmSk8dvmv8qkwoIdl+SXIb8YXK+TZfz9NXNvLCTRaHv2wcFFFw/4jQI2XwltrW+pO9vLkkdZ15F9xU0reACnLrgpc/uyq2WcWg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(2906002)(5660300002)(6916009)(53546011)(316002)(6506007)(508600001)(6486002)(186003)(26005)(6512007)(4326008)(8676002)(2616005)(66556008)(66476007)(66946007)(38100700002)(36756003)(31696002)(31686004)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S24wbUgxbUtCVDdDWGhKRTE1anNTUEdoQ05Zak9Fc3ZVUFc5QWs1dkFCT0o5?= =?utf-8?B?Q2UrODNBNjh6VDg4eXZ5QnpYQlBrNllJYk5ldWxiYVZXSzZmS3hDdm03TVJN?= =?utf-8?B?N2w3TEt2eUo5dG5ScHc0VGdVTmloS25NTVBxa29tVE5uQjRwNGhwR21vOFA1?= =?utf-8?B?R2M1cEhadTVoUThaRnRXalZIektlQkRIMGpGdHlHNGs4ZU53RlFBUnE3S0Jx?= =?utf-8?B?cTJDTXZBYXhOTk13OVZ2WGNYcE5BS1BSNlFLc0w5UHRnVVhnVStDYlBERnh3?= =?utf-8?B?MS84d25KRHlkMG5CZU1vN0VPTERheE43Q3lvNkQ5bytSUEZRcEtydWh4eDkr?= =?utf-8?B?dGdjendZSkNuNS9OSmZGeU41ampySnpvbmlPZTlTOFk1Zkp3RHJsWnBQODNT?= =?utf-8?B?YWo5cHhoVmRqZHNMVlNYVEJTWnRnelJvalNnWUlSaHZvRXNGV01DdGdZcjdK?= =?utf-8?B?M25qQllwTC9VMWdxS2NTclhoMmF3bU43OGlTUnFJaUx4NUx3STJQdHE3Tlky?= =?utf-8?B?b2R2NXRPZklTeElOdlBYQkNOTUovRWZaQU12d0tKY1JkdWpDb04wR2NuRjIz?= =?utf-8?B?Njkvd0hONVdtMUhhRFVsSlo4MjlSWTlpWUpNYkYvNW8vNThOZkFpUmFkdlRa?= =?utf-8?B?L1ZDbFlhamVnUGVKdDd0NEVSODRtT3FFUElnR2R1UDdqa2VMVTNKc1R0VVcr?= =?utf-8?B?amlpRWtnVWQyTndCNnI5SkFIRWdObFc1d3RCSVpaMTBHZkhhTkIzOFVSd0VG?= =?utf-8?B?Z2t6bXdaOFk5UmsvdUQ5NGxFNHQvTlpWbGZNUDY0UTQvcXdrcHNiTHA2V05t?= =?utf-8?B?SHAxYStScHowYW5IUkFESkpORytIR2QxWnNwOFJwdzAzZEpOVDhFTmsxMjNh?= =?utf-8?B?Qkx6bjhvdmRTU0JlMWZ4L3RMOHJESUVCVWdlMU94OTJFbjF6TGhLWE9yK2RW?= =?utf-8?B?WHB1dDB2Ui8xUjU0c1ljaEhCMmZTaDJpSUszVmtjNGprM1RybkZTTVlhWjQ0?= =?utf-8?B?cEdOVnBILzQ0UFIzcTVZa2R4WFpubEQ0OTJJMnRwNkxKV1NiUXM5aTFDTlVJ?= =?utf-8?B?MEZ6OHJ2QWhRMzFVaHltZHI3dWZDaU5DM1ZYamdOMVdpZCtBblF2WjdPR0lD?= =?utf-8?B?anUxOENvZXFBUVRheU5PQURjSXJPSUlLdDhoaFVpN2FreStkcTZLMlN2dy9V?= =?utf-8?B?OE1zbHltTDIvZ09scW4wU3REeGFJaDJlYTF3d3RjaVREVjVvdVluOXZQaXVL?= =?utf-8?B?V21PNHVlcTBoZy9vbnVMYVYydjZXMlZyVTlOSFBRR3hmd3QrVDRRaFFCRFc3?= =?utf-8?B?UFoxVmJaUU45SUpPK2tCN01FNWdOcStpWG1tQzl4RXhCZFMrU3hYbE9LNFlB?= =?utf-8?B?UU5wL1pIY1NrUG5zVUk4dmNab1I2dXJpVFdydW11RFNoOHRiQmovOTRzVldD?= =?utf-8?B?c2ZsalVhNHpUQlo3SXMzbStnZDU5ZmdpWFNVbEF3RDBIbXlZbDlJUm4yTGlk?= =?utf-8?B?NktLaTk2dHJZRndQbVVUT3NzamtENFpqU2NyYWsrWGFIRVlvdmo3Q3NXNUVT?= =?utf-8?B?bkRWOW02UnRLQkNvV2lTM3dFRDZTK3BPbU1PNWY1YTBMMGlBSXhtSXVKZU13?= =?utf-8?B?QTlqOUdacVAwMmZzbFdwVlhQSUZTbGRVK0VGVlV3QWlGdmdSLy9QU1RISGNr?= =?utf-8?B?dUNtRFFUTUFCdFlBSWRDTFBKVTdwdkphaUo4TFVYUjNMSWZwelJRR3hrb01V?= =?utf-8?B?d0NvMzJCekhpcUE5V29XTFBXejZ3cHQ2QTNiZW10UlFLMFZ3UnVTSHd6ZFBp?= =?utf-8?B?NUF1Tmh6aWwzOTJHSTFEMnJTcDU4Mi9xa1ZjWVd0Z0MvRktIU0RJUVNESlVt?= =?utf-8?B?K29DVmF6Ylo4QmFrTmprVWxhdnNiVkRLV2lTVXY1ZHZSRGJQTFB5dHc4SEVJ?= =?utf-8?Q?OXZEnhgGi0TRj+L4GaH5q/OXbOv5OX6F?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2603c32c-c54c-4a2a-fdfb-08da08aeb4f2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 07:12:48.1376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uycqKDjKHfIw+UaOcfF8mv9OG/2lWgdtDDxQujJ8/LHUjBEn06B8sm6vmUV+tqwb/o/BUQ8p3cpTmDTuRufscg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4280 X-Spam-Status: No, score=-3031.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 07:12:54 -0000 On 18.03.2022 07:56, Alan Modra via Binutils wrote: > PR 28977 > * config/tc-i386.c (parse_register): Handle X_op not O_register > as for a non-reg_section symbol. Simplify array bounds check. Hmm, isn't it that ... > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -12952,17 +12952,18 @@ parse_register (char *reg_string, char **end_op) > { ... the if() right outside of context here is pointing at the actual problem? Why would "s=%rdx % %rcx" result in a reg_section expression? Imo this clearly ought to be expr_section. Jan > const expressionS *e = symbol_get_value_expression (symbolP); > > - know (e->X_op == O_register); > - know (e->X_add_number >= 0 > - && (valueT) e->X_add_number < i386_regtab_size); > - r = i386_regtab + e->X_add_number; > - if (!check_register (r)) > + if (e->X_op == O_register > + && (valueT) e->X_add_number < i386_regtab_size) > { > - as_bad (_("register '%s%s' cannot be used here"), > - register_prefix, r->reg_name); > - r = &bad_reg; > + r = i386_regtab + e->X_add_number; > + if (!check_register (r)) > + { > + as_bad (_("register '%s%s' cannot be used here"), > + register_prefix, r->reg_name); > + r = &bad_reg; > + } > + *end_op = input_line_pointer; > } > - *end_op = input_line_pointer; > } > *input_line_pointer = c; > input_line_pointer = save; >