From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 1DA883858D28 for ; Thu, 25 Jan 2024 19:43:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DA883858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DA883858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706211821; cv=pass; b=hgrsZuT9bsWIYOQwqlHrlzc39rK3wUqN8YoUWG+++djo3V4PYl8EtSqwJTTCmFXP4D4zWWmnGPKZBUB/0X2X24iXDE1xvaUqGrqrJy3IumCKe/879IbzubzQSa/aBZy5jTz2dolk+uoCC0t+ELYtjYqhduCz9OY/SchbyENtjUQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706211821; c=relaxed/simple; bh=C0AKGNtrPN13ZEuZMNzOl+2EAVYTc/zM5NYBykVH27Q=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=o6wxcbD2hTRrto08IlMKF4gixb5SQs+jUsN15x4JXPGaXf/cIxNMGEZYeapk0FzcyfV2/K6xXAsnebiqRNQvKWclG5xyqt25moJYNiKkIg1z889QChw42k95A9+j2Qqt4FToDnmQomI/KXT73OdbzkolGnYXW4ykIU+NelMxKfs= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40PJNv6U007283; Thu, 25 Jan 2024 19:43:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=Wo6JoJvPFOidEqsKynwOzcAJ5WRoy1LaQrhIpUQtc/w=; b=mZfp+E5XxPW/UxFL3JWWRds0AR/3OJX7JSkNC29MdHnqpF95qKRHuP/2GT41iJduzH5z ekc7M7GtBq/wAlMaNriLt+2azAEpsbjQPdll4XN3hIH9mYzveEEPQpG+70skUKR8UkeP aeeT7LsCNq256YEFgMSyRnBd+4MHOJn3xJHpNDqmalOTz3ARnLue6+jXlTxWrK0ybSY3 +IRPNP1JPTAw3hvliGab2qFUsGVZqczXViT8kySi9Oc0JpekppmN/T03cF0pmgV3mEEL r0FIE/ScWd/ZDsVaMEdK4yoxD506ioyyVwfIxdy9U6aAD5sYRFX5IX1tDDAnC6L4Wdtu sA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vr7cwqvb1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jan 2024 19:43:39 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40PJSNMm011804; Thu, 25 Jan 2024 19:43:38 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vs326dv72-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jan 2024 19:43:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMpcmNF9pf+d8u9dOQqj8zcQTInle6x4RANaPoXiaTz2laOQ7ciI/tq5+U4igqc+QwJRRgI631JnLOaRcYMMxhdCuGSTAWjxSJaq9sRh/AifuAe0Y3z/z+rW3tQ1bqsn6msxfB9FYjdvgjiZGEY0zf8x2/tkOtEttYetE75Tm+OVUjKqxOlOLmZcc/lSzbZKFgF56Xf5O35wJOhTKWxM2r5evi0+6VgLhqIiGOUeaSNZ2miMa9tgAbmDMuzFTKqLuOdZmnA+XPg+1HsGdbfSDmin9/yproBNCUJl3HsNJKFwouXLt+TyfZrtJ7PF4KMju8lhyvw+/7aIAVhp3XEj+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wo6JoJvPFOidEqsKynwOzcAJ5WRoy1LaQrhIpUQtc/w=; b=UrOujKl3CjpwnNrYNRt+F4KG2ISnCskKp87FDlCyolvBW994nFStFY1zvORHHGhwa0fclwaulIL6bowiFKiG8xbvPzvJLuWua0wtALNBwOa0rCP93rCk4QXkNnT1hNQeK8GI0z5JuGs02OmAlv/v646f7fzmLJZwd4/JeUv9A6cl8wTf5RNRObD0ztCK5drjV9wIDIq1m1tHxVVOpxVXqZr+dc2mKvNVLbCaszfBVwp5PDr7CzEJyJrWi2eFUYb9M+rCW7k31+pLWHNzpnvWXuPoVEZg20TkP9Ul0M+7VIm7ajF6gYsl1Yd5r+0h8J3ArGTaUx8pE5JPmU/vrGA0oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wo6JoJvPFOidEqsKynwOzcAJ5WRoy1LaQrhIpUQtc/w=; b=MzhCn2NRVEyuz15s5drso12Lxt1TdK9/XDT8uMpRgqjL5zFRb6AAzvV63GAVuEKS1EGOVLDtHL2YLGOftfFcC1GLYdmEffY+vpLJEz25YAZELjDVYCbzPc6vGtRH0kVG16JfISn/4LY1lpftaRdbpkyIp1ypIOpeDFvgQA4ZKEI= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB4464.namprd10.prod.outlook.com (2603:10b6:a03:2d0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.27; Thu, 25 Jan 2024 19:43:13 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7228.026; Thu, 25 Jan 2024 19:43:13 +0000 Message-ID: <2db392d1-fe13-416f-a0e7-e7b81906ad3a@oracle.com> Date: Thu, 25 Jan 2024 11:43:12 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V2 2/2] gas: scfi: untraceable control flow should be a hard error Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <20240124072629.1193542-1-indu.bhagat@oracle.com> <20240124072629.1193542-3-indu.bhagat@oracle.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR02CA0002.namprd02.prod.outlook.com (2603:10b6:303:16d::10) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB4464:EE_ X-MS-Office365-Filtering-Correlation-Id: 571e3f74-d6bd-4ba8-5263-08dc1dddde33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YPdF6KS/HBjI1aHjfyv5RohXK0DKLZ++p3B/vWMZSlyzK3/TzNlp1qFFhRC5Vyc3EeUk4lRsRbe+7bDDgc08zTNglkZF6ahTVc6rtV2eflWYJJszX23/kRW1T70k6gxi40qESCRmL89KBr/DWuEBf4JjiJcc/4EMNFT6xYsTJ7bThx7Haz8Hxz4IfyVind1aC75gaIifJKGM8/Io8OKLxlMEcanB69bADpp+hNaD0/EMQTqRfxtaKW+R60O2GD8/rdg+fGBQtuFZ77XkGzmyyiRFlSbbmwgCuO5OH6BNbnKSz5lJBmgfHGPieOvsalR+InU5/WjU7bffPrpv5lXth+tf3wPmkhu+FIFvIt99g7m3Ie5hUS9JlJ/SPqaVgTb0Kapmc1XitRV7fZllZgvGevMo/98VrNpUkdiLSAgqlcBRY1Ma3jT/0ftZpBQkT3MZw0TgPFjxh0m40JLmdCTPrquong6dFmg/7gqO2inADEqa8MnWIM4iO0Sj1q/fB2fsYhb4KyclE4XRaEs5UXqtauI1f0ZKX7+bKRzOcebXOIeR4qV6ps5y/lAW31ac4p9l+3b4b9n4TZ9377NmoBNIhotpaCWYdiWH4cMHZAxC0dB1QI+6BYeB1fGDJgSIwKRit/9/0pLid7lWOsfBPCQQEGNHt3cARRftRdWF1nk75+Ujxm7tt7GqMn4TBs31SDOB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(346002)(366004)(396003)(376002)(230922051799003)(230173577357003)(230273577357003)(186009)(451199024)(64100799003)(1800799012)(66476007)(31696002)(8936002)(4326008)(8676002)(2906002)(5660300002)(44832011)(66556008)(66946007)(86362001)(6916009)(36756003)(478600001)(6486002)(316002)(38100700002)(53546011)(6506007)(6512007)(83380400001)(2616005)(41300700001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vzd0K2VSQmMwU2xJODJqWEREcjIwQlNPcXhiK1Z0Umt4YWN0WnExTzVWY2o1?= =?utf-8?B?QU91RGZieFV6dkZ1VlJZNjRHVllkVnZvbG9CTjR1UVJjVkZQeUI0eUJEQ0h4?= =?utf-8?B?NWsxQnZFYUtkdzBlclJwNGxrTFg0aE9hVHBXV3ZWY2xwMFAzWjhWelFUTk13?= =?utf-8?B?eEJHN2pMRUdRUGRyUS9FUC9CUU8rN243UEdUcHhwZWdSdmJlTmFOZVo0Ulpw?= =?utf-8?B?ajRDMUJuakhDQjIxOGw5aTZsbGhZd25HMCt0WEtOYWY5eUJLVWMvdmNORlEz?= =?utf-8?B?WDRjeWkvZUt0a2dKb2loV1RWY21aVFNmU2g5dlNXZWY1bEU3Smd0TkZIbzZH?= =?utf-8?B?ZlQwMWlNZWJHcmN3V3M3V1pMYldUTzdWR2VSRTFiYzV2R25SdTBsODVCaFNL?= =?utf-8?B?Z3RXVzZuMmRuOFBId0dEOXBITkFJdmtFVldSSVp2Wm5vQzNhaFNKV3I4NFhY?= =?utf-8?B?Qi9GVnU0NDFDM0ZzVUlYVGhMTW1PZ0FZbDE5RVlWdnQwU1hVcG1oQjdnTmZ0?= =?utf-8?B?Vkw2UytzdEg0RlEzNmpGckl0cC9sUW9jd2dHYUZ6d01LeFVOK3I4UnorZVk0?= =?utf-8?B?UjFEZFlUT3BJaXNiL3oxZDJ5Wk9iZ3RRcHN6NDhqR2haWW1DVEM1YWg3bS8z?= =?utf-8?B?LzU5WWNkUVRBaUw5YTNiVXdEeFNudlloM0plRUxqQjcwbkZzK1Q0QlNCaWRU?= =?utf-8?B?YXY1eGVONjV6bUZpZGxhbnVYWXRraVVPM0lwaklYMm83aGRhbnJZLytqQmtP?= =?utf-8?B?Q2pmVjRpSlJibi9hdmZCUzJRTHpHR2lWRzBEWk8xMXdVVnpJdnFaV0ltdW5j?= =?utf-8?B?M1l5a0Q2Z21IODdDQkcyU1BoU1hUZUc2bzRJUW9rZEZNNVJYVUxqNWdhNXEv?= =?utf-8?B?YXFLM2p1Yit3MGFhanp4RDJld2hBbHcxT3NSWE90NnQwTXAwd2RKUkNWbGZ0?= =?utf-8?B?Q2sxRzI1RWlISml0eXpIUThrQ2FJYWV0QVR3RUwzNjYvaUlDVFJnUytmQUhn?= =?utf-8?B?aThSdE42dlhHRlRhSW5mQzlxbjdSUndPbW9uLzBNbnFsc04rbEt2dlNoU0Fy?= =?utf-8?B?R2MwVDJMaGo3N3BZUWRRTXhNOFltSmNHcVo0dG9sTTVJNUgwZG05emdtQ21G?= =?utf-8?B?enVwVjZycGZETk5seXF3NUhoUjBYdmxqWnZpSW9nM2RIUUw4RDhkSjFWSjV1?= =?utf-8?B?OHh4eUpmN3M5eno5NjMwOVpMdmVGTE1pR3RjQ2lEelBmNGY2MnRDbnF5Zkdz?= =?utf-8?B?anlnNytIbWFUR1BkdVE4SXZUUjlobDlscTZRazczeGxzbmZBRnVad2ltOGZh?= =?utf-8?B?L2pmeVY3NEdEajFTMU16MFJObTZPK0lFak01b3lzQ3dUQkQ3RWpTOUxDdXln?= =?utf-8?B?RGdHWFJ1YStZWVE3emVQbDU4QlgzNjc4Ni8wNWMyaVdvRTJhL0JtYXlpMUIy?= =?utf-8?B?TnE2aS9ycGpvL1U5dUN3MkVqaGRQUnJFV2NFL1hnc25GbUtwS2pwTG9Da3NB?= =?utf-8?B?U2RObVEzdFIvZ2hmSGx5Q3hKUDFTYUUyS3pZWUN5ZldMWmlBTjV6VWpYb3NJ?= =?utf-8?B?Y1V3c1VWbjhGaFg0ODdOcmxhRS9YMzlObkNSRzZNSmd0TkN3ZUZXaTBuSEt3?= =?utf-8?B?UTVPM0tKWWgvbFU3N0dQZm01NXNPeHhHWkc0eHdvODJPRmM3R2FKb0E1N0xI?= =?utf-8?B?dGQzMGZ3cUhNQnpRQjJCcEo4ZnNMYVFsZVF2eWhrdXREUWxqRHhSKzJ6bjc3?= =?utf-8?B?RFNRZ0p4by9VYWpVcHo1Q2Q5c3R4RUZWRC83ZlRLVjhSbXFxVzU2M0pPeDFW?= =?utf-8?B?eG9vdC9XaC9GeWpqYVdyeDhVVng0SWVEeUwxbG1IdGQwZ3FwdURJMUhEb1BR?= =?utf-8?B?Z3FOYkhkbnZKMHZhOFVtdlJyV1A2dG5WbktmdWdGZDZDTENWa2NVeGt2ZENW?= =?utf-8?B?NTJkWjQwWHhYVW1NMnF4eFU4MnplSEN5Nis1Y1lFYlpVVUdTY2F2RWNtQ1Rl?= =?utf-8?B?RHg0MWl3eTRyL3pqVld4UExhRmp0TG1UMjNPRFpNelpXOGdHaXFMTi9RUDZz?= =?utf-8?B?Uk80dHZUWnpZL21YU3RpUU1MTXMzMHFVTjFITkxBbUNyUnZrT1d1RFpudDlz?= =?utf-8?B?anMxdG9udDVSajUrd0RUZW1XTGpNYzZqdjBHQVJidDF6SGtKTkNiay9pYkxI?= =?utf-8?Q?AHh73ixTVfnm/rswae+0/Mw=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: MLiLA26s+oPSdeozsW55hnClvEH0j2rvZCqjkFmdne/d+XkpP4a3a0+Ylow/udTkcsblTttMpvrbuNnlKXGiKe4RFZvskyMVwtCH62uMcYmOXXbeY642owr3hQCxIauwrP3AoCVzssluByUG2w+vIWgOsLLfGczc7pKB175asVAjImdnmavwDSN2E3wMWxSFNj80hYEzBiuK4OxKOSQMrOY+raTfGFiOc7AnVGbMsVVuMPFi/Z6Z4t40sv4khlqIuieOHwCVVDEWbEUDXkGn+woGzOWfP9I89rp/uyTyURyGfwRzErxlaTka5Gr8pFemltbo5qTx4dHS8KJvSopGFQP58eB6lR9xK0xlI6AlA2AOlmmylnoOmYy9gGykHBO8PBQ4EQGWFxWG9qqLH8UrFd86Jvdn2k69L8eNPn1jQ4F5sRH+hzEvXCawnFE6taXOy0OU9JW6aZOoMKsK3M9PoxdhM4/pzwDKiMk0avM4w3qVuSGXILa6s4g7hL0Kpgk1LpUrpHMczcP/acebG0epGsqbJopIrKt0SBl6QG9yygbbiaNs9SomC4ko/dQgge1A6iljM5HgVKIKdv6dHOj14CVyLrEPn5oU7z35R/bZWdU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 571e3f74-d6bd-4ba8-5263-08dc1dddde33 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 19:43:13.3463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GRA4gSIXLqMtk40c/7V/u3A+ouFV4ykzK1r72yNk8NE5MuBKL8+JJlxstnuiYqXcrli2G11r+btUbj+JxEp0Qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4464 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_12,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401250143 X-Proofpoint-ORIG-GUID: Gqjnn4yyVTQmAP1r9SnzING9qC5DMRLl X-Proofpoint-GUID: Gqjnn4yyVTQmAP1r9SnzING9qC5DMRLl X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/24 05:59, Jan Beulich wrote: > On 24.01.2024 08:26, Indu Bhagat wrote: >> --- a/gas/ginsn.c >> +++ b/gas/ginsn.c >> @@ -1161,8 +1161,8 @@ ginsn_data_end (const symbolS *label) >> /* Build the cfg of ginsn(s) of the function. */ >> if (!frchain_now->frch_ginsn_data->gcfg_apt_p) >> { >> - as_warn (_("Untraceable control flow for func '%s'; Skipping SCFI"), >> - S_GET_NAME (func)); >> + as_bad (_("SCFI: untraceable control flow for func '%s'"), >> + S_GET_NAME (func)); >> goto end; >> } > > This switch is probably fine. My question here is: How come ginsn.c issues > an SCFI-specific diagnostic? Really most if not all of ginsn_data_end() looks > to be concerned of only SCFI, when e.g. ginsn_pass_warn_unreachable_code() > might have value on its own. > Thank you for reminding me that - I do remember being of two minds on keeping the string "Skipping SCFI" originally. On the one hand, the argument was that "ginsn_pass_warn_unreachable_code() has value on its own" (like you mention). On the other hand I wondered if users may find it confusing to see this warning about GAS trying to decipher control flow for a function and whether this affects the synthesized CFI. So, I ended up adding "Skipping SCFI"... I will remove the "SCFI:" string from the message. I think switch to error relieves me of some of those concerns regarding 'confusing warning when SCFI is enabled' Thanks