From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 1A4BA3858D35 for ; Tue, 16 Jan 2024 08:31:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A4BA3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A4BA3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705393900; cv=none; b=GZbDEFLQc1bQ5XkcCNu3/pMSTa8tGk6X//9SIjuLC3yi2IlIyL8CJhi01x/srz4hVFjGpq1DfeKaXUo+sKlq/sQQWNvpsVNoV/Q1yUS6YQfZAETZPpa1PBWtMxH7bToqeLOQJjY3XnNsp0W5nKyMoCCubfVpIF3lWozFXpTu3NU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705393900; c=relaxed/simple; bh=hagsMNc4gERBY9Du4E0+FxdaVd9iylTlcpiop0dp2OU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=U5vinW8ke3kiTvuUFjkCi5Jr/1qg966lsBmCt7710b/ejUf0oP/oqdDD3uL1vkOEnvQAvZg+WpdeBiNLFkVEJkwwqrCsY/ra9oadoAikSW9xFlMM2FR1IQTFAjnEMTbbiRLV0qRWGI3FU0CYtpAd+H7SRBslnPrP3Wd6oEbn5gY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-337b583453bso295024f8f.2 for ; Tue, 16 Jan 2024 00:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1705393897; x=1705998697; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r99FZ/OBTcPgxrt3VIhNFoGmHt+OAMqcQvZqiaLyeaI=; b=RQmTlSi5g6wcxDFNu47+M3k87B/epmVvGXqGqVLCvmcnFgegCdZ5cd8QKOLojj2exv t5QtRmP/pF2yuGtY/77gWcZuIeCV0d6SljptlvbN2K0nCg3JgF5SJ395+cUQJwzykQw/ l+z5Y+GJQQQAeSa5olhXokP0POb8+M9A6/BexcnXWnHapBubA9eTmN8wf+LBdo4K71RW Urvd9fUdr7DlEnV3a0TpgxnbRYil9dv6uQulTMzy+U/r/OXO4apY+bY/UXS4ESfnnYgd 6aE8b5Bq63Z04KWY+iNspzdx6+90LsklD7FnF6qA+enYqWdVtgrVhDBqfLpZXRNENtpl jKSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705393897; x=1705998697; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r99FZ/OBTcPgxrt3VIhNFoGmHt+OAMqcQvZqiaLyeaI=; b=Zxo8+KfquAGmkzZ3D9zG8XLmDQqOVOgtoABUfvfNg9s2JF1XaVgxeZYSMpgmfCpH/0 kHRBE48b4kqxgGmRN7FpxhXDhMTTxdzdrrbg+1MMAIREYeG9X/unLc9lESElg+c6mYpn q9u/TINnj7+gKVgfVHupvv6vRSflGKPEc6UvetOJwQHWMTBlk64OOVOeTJZ8tuvHjD+J K5Z0M4t7dpZ8jy+KwD71NSlK+tKxxacfSujpQfUYxZHq5OHr2HWtOWQ+c9F4SYqaTT68 6vi8z4xTJKoaqb1/HzKIdVCnHHMcqLtjvF9QDsccD/NH//Rn2g36HC/8cTTPR/POyVMw I4YQ== X-Gm-Message-State: AOJu0YxI5dq84Owhp9pOEk0BzwDHRSQRRwGET4LTTnZCNEiHLaQs2tE9 msh8N69HNwa5bgU3a+sVy60ahnxyeP0h X-Google-Smtp-Source: AGHT+IHBd8ikot4yhhMU/R/0nWxguWfr7kSFo3wEdPGK644y0CEkOkFEHjw/DKysLybn54jv/MDH9Q== X-Received: by 2002:a5d:4e8f:0:b0:336:d086:84ae with SMTP id e15-20020a5d4e8f000000b00336d08684aemr2796278wru.73.1705393897048; Tue, 16 Jan 2024 00:31:37 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id k6-20020adfb346000000b0033671314440sm14068395wrd.3.2024.01.16.00.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 00:31:36 -0800 (PST) Message-ID: <2e1a11b1-8661-4f97-b153-d3a1b2861815@suse.com> Date: Tue, 16 Jan 2024 09:31:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: support APX forms of U{RD,WR}MSR Content-Language: en-US To: "Hu, Lin1" References: <20240116081923.2189141-1-lin1.hu@intel.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240116081923.2189141-1-lin1.hu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16.01.2024 09:19, Hu, Lin1 wrote: >> @@ -3482,11 +3482,13 @@ eretu, 0xf30f01ca, FRED, NoSuf, {} >> // USER_MSR instructions. >> >> urdmsr, 0xf20f38f8, USER_MSR, RegMem|NoSuf|NoRex64, { Reg64, Reg64 } >> -urdmsr, 0xf2f8/0, USER_MSR, Modrm|Vex128|VexMap7|VexW0|NoSuf, { Imm32, Reg64 } >> +urdmsr, 0xf2f8, USER_MSR&APX_F, RegMem|EVexMap4|VexW0|NoSuf, { Reg64, Reg64 } >> +urdmsr, 0xf2f8/0, APX_F(USER_MSR), Modrm|Vex128|VexMap7|EVex128|VexW0|NoSuf, >> { Imm32, Reg64 } >> uwrmsr, 0xf30f38f8, USER_MSR, Modrm|NoSuf|NoRex64, { Reg64, Reg64 } >> +uwrmsr, 0xf3f8, USER_MSR&APX_F, Modrm||EVexMap4|VexW0|NoSuf, { Reg64, Reg64 } >> // Immediates want to be first; md_assemble() takes care of swapping operands >> // accordingly. >> -uwrmsr, 0xf3f8/0, USER_MSR, Modrm|Vex128|VexMap7|VexW0|NoSuf, { Imm32, Reg64 } >> +uwrmsr, 0xf3f8/0, APX_F(USER_MSR), Modrm|Vex128|VexMap7|EVex128|VexW0|NoSuf, >> { Imm32, Reg64 } > > I think change the space name from VexMap7 to SpaceMap7 will be better. Perhaps, but nothing I'd like to do right in this patch. Jan