From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D46853858D33 for ; Mon, 23 Jan 2023 10:59:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D46853858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674471590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9BNy5Kz3gxs0ji+TB6eo7xFgQiyHB8QwxCyGFqFfWyk=; b=WFX0XUlRGyTSgsVB6ocoMpE8YkMxgLQWJ5pizNYC8w31LXC9m37cdnEGm2x+4NK2HxnPaR 51m20aVTzKCrg3EgPOZ8IB/S3bN9u1BqDx1deJwoxvib3VNFMBd5e4d6Qn4pMck+Xqi/f6 ddGRwqe7gxbDNWHG+C1ZRGAzH7yaeVg= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-358-nwBl1KQjOEem7wmuiio-EQ-1; Mon, 23 Jan 2023 05:59:49 -0500 X-MC-Unique: nwBl1KQjOEem7wmuiio-EQ-1 Received: by mail-qv1-f69.google.com with SMTP id nk14-20020a056214350e00b0053472f03fedso5763497qvb.17 for ; Mon, 23 Jan 2023 02:59:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9BNy5Kz3gxs0ji+TB6eo7xFgQiyHB8QwxCyGFqFfWyk=; b=4M9lNC6CU6+cZ6uhO3XqC+lUBtLslCbh/lWwbhoJVvjH/a60iysYlrahofA0z2wKWx BKPwiLduM7hSH3p24158ql2L9H8AU255Z9Vun2xrwzS5INLJMl3ELc07Xdcm/ueyQmy9 rFn5S6pio+eT5Mel26pVSfhSOvl1CqXJjlb/cEDRMLPiYis+2/c2yzSsmmjUsiEyZTZA LAo91iWk4uFp8eDuzBznDZ8av39AszC751NklMqHgVmPTTuABNBC0kj8gyMSeiHgG0GV Z3bt24vrdsGt7KAs1z+lRpD6uRIEBAbLAjsOd+yKxoAdhzNi6t0YUpNoqkOktotvr9gb sZ6Q== X-Gm-Message-State: AFqh2krD/y0ZJLCBDpHcUmeEcYF2Vjsu6hOTaFHepmeiP08yqrfhPqnQ PP3J8CTna0cRhcOxRE7A09tyOi+ZKB+eTGU6b7/eWmhbNRhNDnC68w6yZIpAmZZvBX0r2GNDgVw 5iRCeuH5JK+1mT2+UyA== X-Received: by 2002:a05:6214:5d82:b0:534:a801:1131 with SMTP id mf2-20020a0562145d8200b00534a8011131mr37668798qvb.43.1674471588371; Mon, 23 Jan 2023 02:59:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXuZ5B8gTt0yJZ+4iJwXpqhPIlwS4xYw1Lslxiiv+QsEDnZXOLihZN6WAx72BNMOx7mvkVsbNA== X-Received: by 2002:a05:6214:5d82:b0:534:a801:1131 with SMTP id mf2-20020a0562145d8200b00534a8011131mr37668784qvb.43.1674471588168; Mon, 23 Jan 2023 02:59:48 -0800 (PST) Received: from [192.168.1.18] ([79.123.83.169]) by smtp.gmail.com with ESMTPSA id h18-20020a05620a401200b007064fa2c616sm17159787qko.66.2023.01.23.02.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 02:59:47 -0800 (PST) Message-ID: <2e3f67f8-c401-b1ae-6ce8-1de7a8613975@redhat.com> Date: Mon, 23 Jan 2023 10:59:46 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] ld: Set default subsystem for arm-pe to IMAGE_SUBSYSTEM_WINDOWS_GUI To: Mark Harmstone , binutils@sourceware.org, amodra@gmail.com References: <20230122235733.4160-1-mark@harmstone.com> From: Nick Clifton In-Reply-To: <20230122235733.4160-1-mark@harmstone.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mark, > This fixes the test failures introduced by 87a5cf5c, by changing the > default subsystem for arm-pe from 9 (IMAGE_SUBSYSTEM_WINDOWS_CE_GUI) to > 2 (IMAGE_SUBSYSTEM_WINDOWS_GUI), which matches what happens with other > PE targets. Approved - please apply - but ... > -#if defined(TARGET_IS_armpe) || defined(TARGET_IS_arm_wince_pe) > +#if defined(TARGET_IS_armpe) > +#define PE_DEF_SECTION_ALIGNMENT 0x00001000 > +#define PE_DEF_SUBSYSTEM 2 > +#elif defined(TARGET_IS_arm_wince_pe) > #define PE_DEF_SECTION_ALIGNMENT 0x00001000 > #define PE_DEF_SUBSYSTEM 9 > #else I really dislike magic numbers. Given that coff/pe.h has been included at this point, why not use IMAGE_SUBSYSTEM_... instead of 2 and 9 ? A separate patch that does this for both pe.em and pep.em is pre-approved, should you feel motivated to do so. Cheers Nick