From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 27EA33861001 for ; Wed, 24 Apr 2024 08:19:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 27EA33861001 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 27EA33861001 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::230 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713946795; cv=none; b=ncKGMemTg0K08VUi1/ymdBkgmSl/nQOqn47xmeThL1zWgdcOFrAYXF2tcpOzB7hYqu9/Kmp46x8mlsjlGHXYudA/APdTcEBk7ymtlfw1dy0VeIZWQmp7kGw/th3RLuhtw/h9CUt+NYzgY+85Hh3kUW6qLc/rGXL5XB8CiRzWipw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713946795; c=relaxed/simple; bh=BNzJsrvF/kI/qoby2zB1BW6Bb9QCEy+/O+h3twp8eGE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=e9I5UA3LCHFjLUoKXiNf/Eg1678xR6g2wcHcqrLDNjnF6j1bqJnImaRXwTzhpYkd6fo5CxyBEEW8KNWdoFin6iVqtZqMusyMLH4HnGZgo88ec1o5/8Nm59KYvL8rPODRmpxwBIpyn3f8wftNckEyoAn+QeFP4BWueVoRLa5Lsgs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2ddc2ea2091so26845851fa.1 for ; Wed, 24 Apr 2024 01:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1713946789; x=1714551589; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v8tYxJhqffnacRwSUv3JLIhcfTNiE997TW0w34yWP9c=; b=O/ZQlJHNU91fxmNkN7LQn4A8ldEDioMpuC+G4J25RQY6u61m2YPfmE9chu/V2lxYY9 jLN4/F2qmJEOKv338xyew5bLY+h1Mq1Cgj9Re29m0agTacOG8khnxWTmSRzJov1A82Q3 /WWmfss7UhUgWmJQSYpH/QhUiIir2vy6IGpxm08p/SvbdiSXRgr8/qhmnIjSbokc9z/P 8XCvOurDshfhkzSWdnvRkSIQXQx2S9xiWz+055vimt6vxEGfOQxfAjcgVsQWlrUdpjXY Nu0GWbRiXUFRdYDukGD0Tspr+Qkh5OTNy9jjh4OsxxiCEI7IkI1ljo1mlDbS+l56wC17 F6Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713946789; x=1714551589; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v8tYxJhqffnacRwSUv3JLIhcfTNiE997TW0w34yWP9c=; b=g0hxTb2gYT5YaM85rN5OU471dzFrF0MBKIu6/RNRdR6KXnZyAM7lQQcjaOwzx92S7v l260Kl7OkRWQA904elegn0ncT66kIrmFbMrS7/WkahiTQqmRCy4FvipNiZ9iCtpmywZO 7n+d1zKZ8T6dyzaJI3uwUDvaJ/qPJWkWhVPAQRDQYUs9s3bPsaZckjG4nIQhTKGppRxL 5PYaflX6K3gXP/tD429CFa5mmDgTuoB51x28SIv8DBzUd8OJB6wHRj0nOiQniyxX7F7y 7T9odvw66mlC6AB6HoMGiW3WRMTdSB2bLn23RLEQFX2SF5sfOyhReRdCjQuw9NPdOSwR ltUg== X-Forwarded-Encrypted: i=1; AJvYcCUmIhcNNDRtmFHIRTu4J08mstv90IejMJoZ+lSBz5258icXX3h5l82yhNF06JtpYNgqTuMNNxdmYg9mLxlWtcT5oLfkmb89fA== X-Gm-Message-State: AOJu0YyJP/FH5rGe2sR8tLINyBAdwF6XzP3uosEXtMkwDlzIu23lmNpc jBes/q3QawbytpXIoY67B72wN1P39XdchherLruqxxQ9CZE+FBrE7EKYcjGAug== X-Google-Smtp-Source: AGHT+IEw1FUGCTQpBHuVzCfppwZqiUvX1meug5bRzkZsHQN/29O8BjsZYeEvxmrN6DK0IQt6rqjNGg== X-Received: by 2002:a2e:87c7:0:b0:2dc:d7a6:1e53 with SMTP id v7-20020a2e87c7000000b002dcd7a61e53mr1011265ljj.18.1713946789522; Wed, 24 Apr 2024 01:19:49 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id x8-20020a5d60c8000000b0034aa0fc51f3sm11184341wrt.80.2024.04.24.01.19.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 01:19:49 -0700 (PDT) Message-ID: <2e942a80-bb0e-486b-b97d-9baf95560ce9@suse.com> Date: Wed, 24 Apr 2024 10:19:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] x86: Drop using extension_opcode to encode vvvv register Content-Language: en-US To: "Cui, Lili" Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20240424072356.2433122-1-lili.cui@intel.com> <20240424072356.2433122-4-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240424072356.2433122-4-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.04.2024 09:23, Cui, Lili wrote: > @@ -3427,9 +3427,9 @@ uwrmsr, 0xf3f8/0, APX_F(USER_MSR), Modrm|Vex128|VexMap7|EVex128|VexW0|NoSuf, { I > > // APX Push2/Pop2 instructions. > > -push2, 0xff/6, APX_F, Modrm|VexW0|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > -push2p, 0xff/6, APX_F, Modrm|VexW1|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > -pop2, 0x8f/0, APX_F, Modrm|VexW0|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > -pop2p, 0x8f/0, APX_F, Modrm|VexW1|EVexMap4|Src1VVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > +push2, 0xff/6, APX_F, Modrm|VexW0|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > +push2p, 0xff/6, APX_F, Modrm|VexW1|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > +pop2, 0x8f/0, APX_F, Modrm|VexW0|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > +pop2p, 0x8f/0, APX_F, Modrm|VexW1|EVexMap4|DstVVVV|ImplicitStackOp|No_bSuf|No_wSuf|No_lSuf|No_sSuf, { Reg64, Reg64 } > > // APX Push2/Pop2 instructions end. The latest now is the point where a comment wants adding here, owing to the fact that PUSH2 has no destination operands, while POP2 has no source ones. Following the common pattern "mnem %,%" DstVVVV is indeed appropriate here, but the anomaly for PUSH2 imo wants clarifying. Okay with such a comment added. Jan