From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2075.outbound.protection.outlook.com [40.107.247.75]) by sourceware.org (Postfix) with ESMTPS id 242A7385696F for ; Mon, 31 Oct 2022 09:37:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 242A7385696F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffTvcacjpOdUcAHQZaH2HNJ4BZ11bzkiFE19LhwY+biFKoFMAJ1iswQtY1QBieUgI/dy1Rr4CKH+E99DkVWGpPQuFCS/vbZq++uEvT1R16oW/UAQ2nCJlYO86W+xN4vRma2iPewdK3gobh12Kjyjrt76o5TEh6zlC9CFPFWYconvunW550cvZs/k2qNvsEIM9wfrYbjP/kwZibqE4RpXuX2pi+04CNXihDoJtSS7U4LZ7ybrRYbuBOjXNCxAnWSm53xLD5hKKbHXQuAAqYhbK7y6nGaIGgjg0bUTYW67q7LJoDYeW9/hJPpg94BJ5MwKcp/Oq9QzrtjADnKswH7+rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KPE3PWDwY8/LKcUhgdiPHTG7TtZhuxpBdreTH3i2O68=; b=W4XNufIKzf5W2kkX4XbaF0KjQQCswWP2lCaEmYqPO0i5K3hnd3mkJVtLFW3uOoITvcxarAqyEwGvWnSW4Z62S7n3+koXex7mWvLh+JE1N8yh6u8jZVg+lYVyk9LkLt+i0eL4nGVqd0FrTUXv6QA7VSeWfsP2euJuiEZBw0zTg0al+IEHzQ9sRGJ1TRiJdCYugMFVWA38K4dUG0esY4p+EGh+vLlHrtJ/o02KJvJ4FRQ4mzK4KwgpADpI9ygAleKWbRo1JZmSLRgujpaPo4FLR0nHX7QH8rrZJiYSH1GTs48Bz8D7rZ7yWGojkbGM2XJlwwk2YXjWjY/1CQCcpLeaPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KPE3PWDwY8/LKcUhgdiPHTG7TtZhuxpBdreTH3i2O68=; b=NasUghsftP4F03sC+VBKnPcAVuDPjcPa8WMWciOEq64+Tu2XeM11A9KWugVGaReoom82JWy2pO77/zNndB82FeseGFlpN2sncjjlAS/IS9amLnjRl/LAqjk9zYtQqGZg6T6vFW5D4jF4kqJGf/zdDVcf86N3EDrg5+9lbEulrZsBm3g/sn8TXDOLdxSS62WMr5Zgy1MX79AA08k/GgLeufo8OI/Ri1fpZ1uk3pGy3Zov1a390ctafVHsyzCvcfcYSmh/i9aMOEvHfCOx+0kXU86iNDQCUp7HsKrAj4iOHjN3v754rME5p7cKcvLXTYF9qzf0ZSvhAtpKdwQLXeR7NQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8464.eurprd04.prod.outlook.com (2603:10a6:10:2c1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.18; Mon, 31 Oct 2022 09:37:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022 09:37:43 +0000 Message-ID: <2f2df7ef-e15e-4d1d-a965-8c9abc8d1ffc@suse.com> Date: Mon, 31 Oct 2022 10:37:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Content-Language: en-US To: "Joshi, Tejas Sanjay" Cc: "Gopalasubramanian, Ganesh" , "H.J. Lu" , "binutils@sourceware.org" References: <28044500-4513-3d31-db60-946f873524ae@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8464:EE_ X-MS-Office365-Filtering-Correlation-Id: 490a96aa-29f6-4ea1-00b7-08dabb238fb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ll1TYIchjqpzO5eQwBEl6cNlDfoFHYFjOpipq/XphUX6fbX7/wzn9CimnmNUR75eMRFHE6cXlylGDQEBZstFfy5BMcCtmcB/T+TE6rSBAek6TwSAlK+pphqVubBzFYtjYukCBGCA1oHyjqvSDkbRpuKs86uRw49mI2agoX55Sa/VEnmOLk4Jd5+7NoBcg9G2+rdt7mPWps3cUNKB23hHtFs80ywf0E+EvPE4fOqEeUBLsvECzhv+W2zTj6Wf3TGgVagCi6D8bBOgWCxxtSw2QARicMgRQfs6J3uTtPvvWNZ0aeGryXOFxk+YvODNi2vtIT+kKiiM7CSHVqf28qlIhvSKjwcEWt7+gBC8YxXWlT94Te8Nub3o28Aenf7PVacSdwGk+3HjTZ0yQPv9I94MwXkd62Zeqh9nUX6sh6oqAnMxbKWExkOruiXvbHqUCB4MBHicVnCLg3F/W/pQkAT+uK+tuVC+f8B90aQnGt7qpLC5qBPkyf9nOEmAT4ipCexijso7waI7Tpwb8RsYeXs9sZziQKsQpfDCgQitFlwyc/Xykc0oh1v+KkyfpBts1FAYk9zC4NgUIEqs9h/uM96qACS5UZDYAKGLXSwSc/671m/S3iJHtNqecO1alrCUe3xKXpzC1HOMT4Iu4QNhUEfXO3buynfL2X5SXXGQMV3HUhHLCD8mlS5qnPQP9OAK4qVLX3FeN1lxA81sDqi7pDWrbRS7/bhycpyD7qEjnIjYSO3cyj5n8TJGXRZiCWOUHyax2QNgI4pevn9sCUgS+kGJlaDdftKMvqSUFsYAG6d4ndo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(366004)(346002)(136003)(396003)(451199015)(478600001)(8936002)(186003)(5660300002)(2616005)(6486002)(31686004)(54906003)(316002)(6916009)(83380400001)(4326008)(8676002)(66476007)(66946007)(66556008)(6506007)(36756003)(53546011)(86362001)(31696002)(2906002)(6512007)(41300700001)(26005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K29Ra2QyejB0dVR4SG96dURPcE5PSjBoamFwUGF1eDlHdkxpdzF5ME9GSFFx?= =?utf-8?B?ZGZ2VmtJWDNwdkpoVXRHVmo1eUhqcVRtK0tiK0NHd1NBSktTb1VKQXhBWW5S?= =?utf-8?B?eDZTMnB5YXRweU51bXBJMkFJQk1UTkQvdzFXNndndE5MZFBiNWZtTGdsYlo2?= =?utf-8?B?OE9VdnZ1K0lTUGJzSVlZVSswVFR3OG9HMVQzcy95U1VhTEpOOXhJU0RLeWh3?= =?utf-8?B?d0lNYzIveFBpYlo5WDgvenlMblEyMmFOL09tdk1FM3ZzaWowN3ZOMHBZaFJX?= =?utf-8?B?T3VzZkVUcWU2WTNmVVlIWVl1c0x0bXRyQUpDYU0rM0lhbXh2dmZZbmRjMnBo?= =?utf-8?B?Q2h6alhGWUVGWjFVNVVMTVZ5dmZyQ212eE4wUEV4MjBXYjBxZ0JIeVY4YTA1?= =?utf-8?B?QXZ1VTM5clhsVHVoalhUZlNJYXB5NXlZSlprMlN2YkduQ3NydVNDd2tzQXZE?= =?utf-8?B?YmZNM0phVlpTZHc2SDY2ZVdOcHAwaVFFcjBieGxOaG1FMDhqRFJzNElkU2FV?= =?utf-8?B?NFZEQUJENzIvYTZXNGl4NEU2aXpmSnlHclhnR2U2Y2lxVFBqcE90bzlBNnlo?= =?utf-8?B?QS9NY1BkTUNRQXR0T0dtZVc3ZHdRL3F0U1Vkd1A5MFo3WjVyM01xdm95NjU1?= =?utf-8?B?OXlMOEZWNlMxNFYxQ0ZUMDVlakVxK1VheGZJUjZlcWw3QXZsVlZVaHE4U0c0?= =?utf-8?B?aHhJRi92MmtlYXhISmJ6cWVxWTViR0w1VHgzbTV4WGpKaGhvZVVwWWt5bmo0?= =?utf-8?B?REpmK2wydDlsMEJjemljZnhuak1nalJPV0hrZmMxUnN4UXNvUHhBUVI2bmpQ?= =?utf-8?B?eFdtVldSN05FbjEwMlFzRU5xbXFnWXlZQjI1S2xLdFhXenR5TDNYMmQvakNL?= =?utf-8?B?ODVXclVQYUtLaVJqaklzSzAzaHd5emExdFUzK0YrZ2xhdUExdEQ2RzNvZVpL?= =?utf-8?B?ZjZmUjJtZ3g5M2luQmRDWDN2RzFLRWlUa1plRUhuaUhId0N5RDBINUlyZlll?= =?utf-8?B?UGV3dis4QzRVZHRuT3dtVEExRmhGWlBWOGYwbk9zS0JCWkw0N244ZWFMQ2dE?= =?utf-8?B?THBabVNQbmhiZ3g1MFRoTXFKR1dld3pCUk9jSlgrM3Y1Y1RFUWhHbzhDbjI1?= =?utf-8?B?azgyWk4rNWtkKyszZnhqb3N6MjhqeExmcnBFTWpvSStUSmFxdkloMlBwUG56?= =?utf-8?B?SDFONmpTcThtNHBPMmJFa28ySk90ZVdLeWhadXBlZlhieXBIdGwvR21qRmh4?= =?utf-8?B?MjNvd0NoTWpsU2RKQWpOS2VaVTk1NmhXZXU1eWZwaTZXL3VqTUdqNGtua01O?= =?utf-8?B?TzNtMmN0WVBwclQxS292T21hRVNVT0RMbzArMWdjclJuNWttWENtWGxnMlQv?= =?utf-8?B?bzJ1Q2JtQnRVRzJTaHI4VktDaVU4YXc0SHM4TnYydzR5cjl2ejNmdVBjWFpt?= =?utf-8?B?STJRVFpqVytkem5DRHhBYmNCRWxnWjVSVGQ1MTNXWWdpZGRjWGMvalhKakwy?= =?utf-8?B?citxelkrSnlzYUk0ZVV3c25rUUhYTlFQM0p4cERhZnFxZDhFMHBkOHNsVXBo?= =?utf-8?B?Y2M4TWN0ZmVLNXV5M0hiR2VFY3Q4by9XaVV4dmhXYmZkMUpUWmVrUWdwVVFp?= =?utf-8?B?bHo5eTAwaC83YmM4clppYmp4WGZWeWcvNXhZbmJESjFBelN0YjA3WlRkY3h1?= =?utf-8?B?M3JRMk9QVEZPVHYwRFZpMUlUNWl6SURNeGJuYi9aQ0gzUE9Vb284bDk2V0Uv?= =?utf-8?B?Q3R2bEJBbFBuK3QrU2M3MnpSVDhiemVOTFZwWDh6Uk9zc3N1a1liNVl0RE14?= =?utf-8?B?RHVRMVM0eGJqV3lLSXozaGxJM1MxYVRlRE1yenJ1K3ZTT2RaSGpNazFRQnNI?= =?utf-8?B?eUp3cTh4b25pcFVyR1oxS2FIc0hEN2NhS2tKU004NW50SVU3ZzcwbzVPSjRX?= =?utf-8?B?SlIvMnNEaE8yVVNHYWJoSGZXL2M4YVczelZEN3g4K0pHS2pXSktQU2Q0dkFN?= =?utf-8?B?eC9oZko4bUY5dFdSSy9wTE9wS1IwNVgydkxvYytRL0JieGlJNkZIQ1kySmc3?= =?utf-8?B?YWdEOVIvVUpneGtJVTV4Uy9wRWhzNUpqOGthUklSQlc1Q3ArM2VmUXREclhS?= =?utf-8?Q?qnwcxen/e58QIwIU+geS72f4H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 490a96aa-29f6-4ea1-00b7-08dabb238fb7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 09:37:43.7449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0jzckj8AGnmpWpotfM1/Q2blW2D6lXvxNvJWU/Co2938hgUr35JTfSFumxD1Tz83IHNF0YIRZ+HFrYmeIcSC/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8464 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31.10.2022 05:37, Joshi, Tejas Sanjay wrote: >> You also (afaict needlessly) add CPU_RMPQUERY_FLAGS, whereas >> CpuRMPQUERY isn't applicable here; you already ... >> >>> (cpu_flags): Add CpuRMPQUERY. >> >> ... mention it here, where it is applicable. > > Corrected this in the ChangeLog. > >>> * i386-opc.h (enum): Add CpuRMPQUERY. >>> (i386_cpu_flags): Add cpurmpquery. >>> * i386-opc.tbl: Add rmpquery insn. >> >> The three relevant SNP insn have a comment: "The single-operand forms >> exist only for compatibility with older gas." Therefore I'd like to >> ask that new insns (like the one you add here) don't have that strange >> form also added. > > Yes, the single-operand form for rmpquery is also added in this patch (RMPQUERY > has virtual address specified in RAX register): > > +rmpquery, 0xf30f01fd, None, CpuRMPQUERY|Cpu64, AddrPrefixOpReg, { Acc|Dword|Qword } That's what the 3-operand form is intended for. For insns like this we mean to allow a shorthand (here: no operands) and a variant with _all_ operands spelled out. There's no need for "half" a shorthand. See also H.J.'s response. And note how you already don't test the 1-operand form. > opcodes/ > > * i386-dis.c (x86_64_table): Add rmpquery. > * i386-gen.c (cpu_flag_init): Add CPU_ZNVER4_FLAGS and > CPU_RMPQUERY_FLAGS. I see you's corrected the changelog entry, but as previously pointed out it's unclear what you add CPU_RMPQUERY_FLAGS for. You don't use it anywhere. > --- /dev/null > +++ b/gas/testsuite/gas/i386/arch-14-1.d > @@ -0,0 +1,22 @@ > +#objdump: -dw > +#name: i386 arch 14-1 > + > +.*: file format .* > + > +Disassembly of section .text: > + > +0+ <.text>: > +[ ]*[a-f0-9]+: 62 f1 d5 48 58 f4 vaddpd %zmm4,%zmm5,%zmm6 > +[ ]*[a-f0-9]+:[ ]*62 f2 7d 48 1b 31[ ]*vbroadcastf32x8 \(%ecx\),%zmm6 > +[ ]*[a-f0-9]+:[ ]*62 f2 d5 48 b4 f4[ ]*vpmadd52luq %zmm4,%zmm5,%zmm6 > +[ ]*[a-f0-9]+: 62 f2 7d 48 c4 f5 vpconflictd %zmm5,%zmm6 > +[ ]*[a-f0-9]+:[ ]*62 f2 7d 48 1c f5[ ]*vpabsb %zmm5,%zmm6 > +[ ]*[a-f0-9]+:[ ]*62 f1 d5 0f 58 f4[ ]*vaddpd %xmm4,%xmm5,%xmm6\{%k7\} > +[ ]*[a-f0-9]+: 62 f2 57 48 72 f4 vcvtne2ps2bf16 %zmm4,%zmm5,%zmm6 > +[ ]*[a-f0-9]+:[ ]*62 f2 55 48 8d f4[ ]*vpermb %zmm4,%zmm5,%zmm6 > +[ ]*[a-f0-9]+:[ ]*62 f2 7d 4f 63 31[ ]*vpcompressb %zmm6,\(%ecx\)\{%k7\} > +[ ]*[a-f0-9]+:[ ]*62 f2 75 48 52 e3[ ]*vpdpwssd %zmm3,%zmm1,%zmm4 > +[ ]*[a-f0-9]+:[ ]*62 f2 55 48 8f ec[ ]*vpshufbitqmb %zmm4,%zmm5,%k5 > +[ ]*[a-f0-9]+:[ ]*62 f2 7d 48 55 f5[ ]*vpopcntd %zmm5,%zmm6 > +[ ]*[a-f0-9]+:[ ]*66 0f 38 cf ec[ ]*gf2p8mulb %xmm4,%xmm5 Please be consistent with output expectations at the very least within an individual new test: You want to use [ ]* also on the three lines where so far you don't. Same for the 64-bit counterpart then of course, albeit ... > --- /dev/null > +++ b/gas/testsuite/gas/i386/x86-64-arch-4-1.d > @@ -0,0 +1,23 @@ > +#objdump: -dw > +#name: x86-64 arch 4-1 > + > +.*: file format .* > + > +Disassembly of section .text: > + > +0+ <.text>: > +[ ]*[a-f0-9]+: 62 01 95 40 58 f4 vaddpd %zmm28,%zmm29,%zmm30 > +[ ]*[a-f0-9]+:[ ]*62 62 7d 48 1b 31[ ]*vbroadcastf32x8 \(%rcx\),%zmm30 > +[ ]*[a-f0-9]+:[ ]*62 02 95 40 b4 f4[ ]*vpmadd52luq %zmm28,%zmm29,%zmm30 > +[ ]*[a-f0-9]+: 62 02 7d 48 c4 f5 vpconflictd %zmm29,%zmm30 > +[ ]*[a-f0-9]+:[ ]*62 02 7d 48 1c f5[ ]*vpabsb %zmm29,%zmm30 > +[ ]*[a-f0-9]+:[ ]*62 01 95 00 58 f4[ ]*vaddpd %xmm28,%xmm29,%xmm30 > +[ ]*[a-f0-9]+: 62 02 17 40 72 f4 vcvtne2ps2bf16 %zmm28,%zmm29,%zmm30 > +[ ]*[a-f0-9]+:[ ]*62 02 15 40 8d f4[ ]*vpermb %zmm28,%zmm29,%zmm30 > +[ ]*[a-f0-9]+:[ ]*62 62 7d 4f 63 31[ ]*vpcompressb %zmm30,\(%rcx\)\{%k7\} > +[ ]*[a-f0-9]+:[ ]*62 a2 6d 40 52 d1[ ]*vpdpwssd %zmm17,%zmm18,%zmm18 > +[ ]*[a-f0-9]+:[ ]*62 92 15 40 8f ec[ ]*vpshufbitqmb %zmm28,%zmm29,%k5 > +[ ]*[a-f0-9]+:[ ]*62 02 7d 48 55 f5[ ]*vpopcntd %zmm29,%zmm30 > +[ ]*[a-f0-9]+:[ ]*66 0f 38 cf ec[ ]*gf2p8mulb %xmm4,%xmm5 > +[ ]*[a-f0-9]+:[ ]*f3 0f 01 fd[ ]*rmpquery[ ]* ... this last line shouldn't need the trailing [ ]* (iirc as of recently it doesn't even need " *" anymore). Jan