From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 718EC385B512 for ; Mon, 8 Jan 2024 08:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 718EC385B512 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 718EC385B512 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704701571; cv=none; b=hbah0yUSytbO2Myrxrt0Nnb3Qar17zT+wDpwkDmlgnuwDsoIT2EBY3sLTS7zPpjpeFvg7y9woLqD9oBEZJ1aQ1A3anuU4BQgMve8Qcg8ZknBzbqYHzmFGrGjfu/8v0rEeiNJ8YCfykPYjfenO83b0WNP9fNaMkKr3lMBF31Zy3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704701571; c=relaxed/simple; bh=tfREAwi0pjnAzy9jqS/1BWecNJetlz+k7eRU8zbqJDU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Vl0n7Ob5CvnXWPo3ZfT/uamgK9+cxN9tJE5KXBkYygMana3mu7Fc+7bwJFAqsd1q+lxu8V6W24/SJ7t+SPYlckOFa8LQcKjppXREl3qDKcD/b826GsjAWAL3wgT3GSgjxbGZ22UlvK2T4RC2JZ68RfS8Wpni6H6qAtdRFGhdjSQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-50eabbc3dccso1312676e87.2 for ; Mon, 08 Jan 2024 00:12:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704701564; x=1705306364; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZMfTgPGE6CTnhSyasTqyArNPW2362xY/7CXcrqIAq+E=; b=aNJDFY2YQJ2JYtjHIPSLMx4FpO8otpFqlrO0hzLq7XfguFoAGrTKGWn0rqikWyFYJB KudbjXRLbFhEAmFA+JF/zUS2pv+9RtTzDRHcEeXGm8ZLG5WeFIXEfCEdR3Uu/nyGxYL4 dsMS0ASkrYyfexqYGYvCJNfWQfV8O4ypD+ZTOLxpFNiVGsxUK3np6E28lDJS7NpDdOwE 3WT7gYr4SJ7OgzO/GFHrOvsGjNO0Nr5QrkNMaBCB+8hWQsbtxtpQrZalOcSG9OpIjqNP btFumP/0twXHGPuyDIASOKztlWj7kNfPc1i1Yzkzxc2VlGkxejd7w8W5h/N0N51cf68d b8mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704701564; x=1705306364; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZMfTgPGE6CTnhSyasTqyArNPW2362xY/7CXcrqIAq+E=; b=W5VU4q81G3lcSRHx8SyvuojxmKeFTblHxDuLfiIXZMiclEKo5GNlz7pQO+eKD4mkjE eNKhIQ9fweKUleAuxYKEOsM9HZCPsShvTxZ5p7XgT8Vnho9X5a4668n3PRkqU4IzFJz9 AX7iBdHt2DSg7TPujSdrGTu0pFlCI0MWLT97hoRp0PjAUJ/3vxgzmHajAS3TcO4Oc4OF 7XfRWntKFEz8ZgW/y9AAx0Gp3xuwGcaClT8fwYVNLtI/aMmAn1Aph0HTJ74iCDkEY5oS ZwDlq7P+p9vZGDDZlr5RF+fOrI60EoyVd/St83z32Bc8Ffg4wHqqR40vzt8d3vP/CyIa bhEg== X-Gm-Message-State: AOJu0YwcSXW1JzX3FWG6MJvHg67ASpt3lpeg+uYYL5cu+eAW2c1Xe8Os YbtIppIhJdgArzfNPcmmHfS/KgxRsOb8 X-Google-Smtp-Source: AGHT+IGTwEL95KMu/Nqv8M/lbT1TdKR560qtkSYtleOzYydps6EUASNFkoD7i5vYJWmyEQeUpPxctA== X-Received: by 2002:a05:6512:368f:b0:50e:b23e:ee68 with SMTP id d15-20020a056512368f00b0050eb23eee68mr675134lfs.51.1704701563991; Mon, 08 Jan 2024 00:12:43 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id y20-20020a6bd814000000b007bb3c9b3187sm2110112iob.4.2024.01.08.00.12.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 00:12:43 -0800 (PST) Message-ID: <2f496ca2-0efc-4a49-9b8a-a346df0739cf@suse.com> Date: Mon, 8 Jan 2024 09:12:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V4 09/14] opcodes: i386: new marker for insns that implicitly update stack pointer Content-Language: en-US To: Indu Bhagat Cc: binutils@sourceware.org References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103074341.3858511-1-indu.bhagat@oracle.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.01.2024 11:08, Indu Bhagat wrote: > On 1/5/24 06:05, Jan Beulich wrote: >> On 03.01.2024 08:43, Indu Bhagat wrote: >>> --- a/opcodes/i386-opc.h >>> +++ b/opcodes/i386-opc.h >>> @@ -750,6 +750,9 @@ enum >>> /* No CSPAZO flags update indication. */ >>> NF, >>> >>> + /* Instruction updates stack pointer implicitly. */ >>> + ImplicitStackOp, >>> + >>> /* The last bitfield in i386_opcode_modifier. */ >>> Opcode_Modifier_Num >>> }; >>> @@ -796,6 +799,7 @@ typedef struct i386_opcode_modifier >>> unsigned int isa64:2; >>> unsigned int noegpr:1; >>> unsigned int nf:1; >>> + unsigned int implicitstackop:1; >>> } i386_opcode_modifier; >> >> I'm not happy to see a new attribute be introduced for this (a new >> OperandConstraint enumerator would seem more appropriate), while at >> the same time I can see that the Rex2 attribute used in two of the >> affected insns presently makes this impossible. However, with no >> other way out, I'd rather see Rex2 become a standalone attribute, >> and this one be another operand constraint. >> > > To be sure I understand clearly, the ask here is to: > - Use unsigned int rex2:1 in struct i386_opcode_modifier instead > - Add a new OperandConstraint=IMPLICIT_STACK_OP > - Remove the OperandConstraint=REX2_REQUIRED > > Is this right ? Yes, that would be my personal preference. (Subsequently I'll likely see about replacing Rex2 again.) Jan