From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 860F03858D3C for ; Mon, 24 Jan 2022 18:38:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 860F03858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 2q6vlhAMqWRbKHybELvLGYYZXJVKXlVGA7YoAhept+S8RZiqHXi5t+tltKU/gvIoPepIbd0rMM FMpYsnDhM+jViVX9b0CgaEIglfup91D6XUergwS+6vnmaLG4SKvj2RM17tMbeP55YrWTTbfzR4 jIjhbfJVIq+wLQmOO2DtR8bEWyKs2gDIc4rSK5a55ZoMybpqDEt7sO41wPnqBBFYSckqC2LOT9 LUfwYXCjlIUXVsqYgTf0QtV+auXxK9fnR8pvFP2aRDt4i6jMxzNlClMx4R4pPsvZcHX8UfaA1N 3CRzP8FlHJTl0DEvLZfTGiy5 X-IronPort-AV: E=Sophos;i="5.88,311,1635235200"; d="scan'208";a="73684388" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 24 Jan 2022 10:38:18 -0800 IronPort-SDR: Dk3e5XXLvuC0v6JdeT5z74SdAaV1gvil7LRfLBB83PKDn0J/oOr+WIFHmYBrQI+xAQlDR1pOXF bbDF2IXTvg/vSijSZ6xsmqcFopC1wCO8lZHJnam+Y9OCYgf92VJnw4nWIZzltvm/wsBcp6FaBJ nSHcMPoYwx05zjd4OL2sWIaqWXkzEwtTBZMc+ElGSt6WzO89XME3lU1m7jP/qQ2VqAtmW+UkXw 153ZBo8RAO/BDopniqZWPaefrktkrRijL1qrbfd7cJXXXFzhQ/oQyb/3ZXxf8iTsytubuBrerr RZA= Message-ID: <2f5ebae4-1d69-d529-f113-999cff3f5962@codesourcery.com> Date: Mon, 24 Jan 2022 19:38:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] bfd: Update doc/local.mk Content-Language: en-US To: "H.J. Lu" CC: Mike Frysinger , Binutils References: <2f05350d-1edf-f8ef-5fdf-4a250d53276b@codesourcery.com> From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 18:38:21 -0000 Hi H.J., that works =E2=80=93 but not completely as texi2dvi itself does not get pas= sed the -I path. Thus TEXI2PDF doc/bfd.pdf fails because: bfd/doc/bfd.texi:219: I can't find file `bfdt.texi'. l.219 @include bfdt.texi I wonder whether part of your changes could/should be replaced by the following, which mimics what binutils/doc/local.mk does: --- a/bfd/doc/local.mk +++ b/bfd/doc/local.mk @@ -80 +80,3 @@ info_TEXINFOS =3D %D%/bfd.texi -AM_MAKEINFOFLAGS =3D --no-split +AM_MAKEINFOFLAGS =3D -I "$(srcdir)/%D%" -I ../bfd/doc \ + --no-split +TEXI2DVI =3D texi2dvi -I "$(srcdir)/%D%" -I ../bfd/doc At least it seems to work when manually adding '-I doc -I $(srcdir)/doc' to the 'doc/bfd.pdf' target's texi2pdf call. Seems as we are almost there and as if the rest seems to work :-) Thanks, Tobias On 24.01.22 18:48, H.J. Lu wrote: > 1. Remove %D%/bfd.texi. > 2. Pass -Idoc to $(MAKEINFOHTML). > 3. Replace bfd.texi with %D%/bfd.texi. > > PR binutils/28807 > * Makefile.in: Regenerate. > * doc/local.mk (%D%/bfd.texi): Removed. > (doc/bfd/index.html): Pass -Idoc to $(MAKEINFOHTML) and replace > bfd.texi with %D%/bfd.texi. ... > --- a/bfd/doc/local.mk > +++ b/bfd/doc/local.mk > @@ -118,7 +118,7 @@ REGEN_TEXI =3D \ > $(AM_V_GEN)$(REGEN_TEXI) > > # Avoid the %.stamp generating a builddir/bfd.texi that overrides the s= rcdir/. > -%D%/bfd.texi %D%/bfd.stamp: %D%/$(am__dirstamp) ; $(AM_V_at)touch $@ > +%D%/bfd.stamp: %D%/$(am__dirstamp) ; $(AM_V_at)touch $@ > > # We use bfdt.texi, rather than bfd.texi, to avoid conflicting with > # bfd.texi on an 8.3 filesystem. > @@ -147,6 +147,6 @@ MAINTAINERCLEANFILES +=3D $(DOCFILES) > html-local: %D%/bfd/index.html > %D%/bfd/index.html: %D%/bfd.texi $(bfd_TEXINFOS) %D%/$(am__dirstamp) > $(AM_V_at)$(MAKEINFOHTML) $(AM_MAKEINFOHTMLFLAGS) $(MAKEINFOFLAGS) = \ > - --split=3Dnode -I$(srcdir) -o %D%/bfd $(srcdir)/bfd.texi > + --split=3Dnode -I$(srcdir) -Idoc -o %D%/bfd $(srcdir)/%D%/bfd.tex= i > > MAINTAINERCLEANFILES +=3D %D%/bfd.info ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955