From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 69DF93834F3A for ; Wed, 22 Jun 2022 11:02:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69DF93834F3A Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-WUUJ370HOBa2EAzYDonpIQ-1; Wed, 22 Jun 2022 07:02:21 -0400 X-MC-Unique: WUUJ370HOBa2EAzYDonpIQ-1 Received: by mail-wr1-f70.google.com with SMTP id y18-20020adfdf12000000b0021b94ba4c37so1591995wrl.11 for ; Wed, 22 Jun 2022 04:02:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=RKK5qJW2aSEpiVcUe5Q4B6vx/covqWQssoJeAl21Fmo=; b=o0uYfx5Yssk6LNs9EJu3MfsZNb9FLvWn0kIO/6KSfeE41SUSbnBvTTfesg8cHmikJi YmpTsYNu3lemg2z5qp+tLCHccJDM3wNo49Yk+6Kf1rftKpanjSUISd2anKK5FdRzNS1b 3SN9sejvci4VXF1i5dJHMpgZZ8zQ4igpmJR02TquwABTz5iXvb02d3fzKQEUgko9inWv EMQbkimAJET5I0vXiKjMJP0Jrnua1HRTNT/quSR8M8HFhVgwlczepfx/ND63qOcO9xtT 4/DOs48L4mY3h2xc3rjh2PDZH3WI5FIUoGwnbQazCTFjCPmVfR1RCRPtM8SkGhQWN90q 3kOw== X-Gm-Message-State: AJIora8rocOPDqJkh/6AcYcXvxVzMQmH1Z1aBNU7JLNwj4Tb5Om19liI ZZXcs6S9xFDCOjdV/2FjT0mxu8CAxrZX02TwjQJeBdljLArKQxMgCJ+glQWoH3c+nbp3QH1OhQi xvaFK5YO1codwmMCnvw== X-Received: by 2002:a1c:7408:0:b0:3a0:173b:beef with SMTP id p8-20020a1c7408000000b003a0173bbeefmr3312688wmc.90.1655895739734; Wed, 22 Jun 2022 04:02:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tEi7h9gt7Te83WVrXFIfsVZuQBTmU49aUSOtQSRwnZIY2vOGx0/a6gQPS3RN2cbDdcaUcJzw== X-Received: by 2002:a1c:7408:0:b0:3a0:173b:beef with SMTP id p8-20020a1c7408000000b003a0173bbeefmr3312672wmc.90.1655895739570; Wed, 22 Jun 2022 04:02:19 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id ba7-20020a0560001c0700b0021b903a018bsm8966692wrb.92.2022.06.22.04.02.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 04:02:19 -0700 (PDT) Message-ID: <2f9eb769-46d4-2450-ac62-7767c4b31b21@redhat.com> Date: Wed, 22 Jun 2022 12:02:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] opcodes/aarch64: split off creation of comment text in disassembler To: Andrew Burgess , binutils@sourceware.org References: <96fd8fa2c7f20081998cf1e4d9800f3e65f6d8d8.1655810414.git.aburgess@redhat.com> From: Nick Clifton In-Reply-To: <96fd8fa2c7f20081998cf1e4d9800f3e65f6d8d8.1655810414.git.aburgess@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2022 11:02:23 -0000 Hi Andrew, > In this commit, I propose to extend aarch64_print_operand to take a > second buffer. Any comments for the instruction are written into this > extra buffer. The two callers of aarch64_print_operand are then > updated to pass an extra buffer, and print any resulting comment. Patch approved - please apply. Cheers Nick