From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 2368D3857361 for ; Fri, 16 Sep 2022 03:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2368D3857361 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x433.google.com with SMTP id d82so19965023pfd.10 for ; Thu, 15 Sep 2022 20:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=I+3PdWBwKI9xpbplWfjxnipmiNzR0fNYIo9btg6xDoE=; b=XmzZ2WQ/gQ5lyUW97+biGRetWjz70w7710zabH2oge4V/VAv2b62pYYcmIADuu/5xX a1A5gybdHO37XRAx+/eDax8elI+XWT076IAvQ4d63no96AwHqs+QUFyIIzgqqaG+T94a Na4axv7nqDZDzlpFP3UzNWkPxk4G25A876x/0ii4elCG9zp5HELw1S/1dKbsb/AmovnO P6rimMhCdot73y15O+DUgh8+zt/oDPaNgR3Sn8VGXp8nY/LR0S86+QKfBjBmYFAu4cLf yb9sfSMgFsea6Xx4rjGeLDrkB99KHH7gp/l+NAX4fvRuTlLMYyKJosu/oMfD0slAvtI8 QzUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=I+3PdWBwKI9xpbplWfjxnipmiNzR0fNYIo9btg6xDoE=; b=Irkn8j1JZUjuaAUquDKsFY5Ddus0cOMQ/B+QFWMXZUVE2P3020X8yP+uyUeDBD6MBS 6EQu/Ea4bDYeK1UFxxTLEEequ+X4ZOk3Ze/PrnI6bL2IrzuwzsMEePXh2d4hyHd+zvpF 6QkfsXb+hU3Wct9AJUdgfjFF8a8GGvh4ctzVZapyGXP+DHbtCBCmQL0Do/fJheyhJhRQ 5J5J8xKngR6H/xuQO5iAc7Vjoq51l4qAyQ8qS1T41AXEQ9+Ok+r7At3/raDBQplqGBGa FqVJEjxA1VW7ZZkbPLhotYR2RePiuj8Qy7UEWGM5qGqJxG6iX0zpyx6nqc4X5/t7BuGT DIGQ== X-Gm-Message-State: ACrzQf1UMO0k87wFp1+sLbjwQxkKbDXjemtxG3Ax20MXxyE0BqEFSw5s GnmaAHaHJ/r5hV2JvP1WtWKkY0AZxn3fDA== X-Google-Smtp-Source: AMsMyM7adH0Cey5eBkJjmhuAR/nvOyXz5BW0jE5LaHFDX8xNynB1EWm7mGfI/w50mz9h5eGuFOzu7Q== X-Received: by 2002:a05:6a00:1624:b0:540:984f:9a64 with SMTP id e4-20020a056a00162400b00540984f9a64mr3241851pfc.46.1663299010040; Thu, 15 Sep 2022 20:30:10 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id w10-20020a170902e88a00b0017829f986a5sm11008417plg.133.2022.09.15.20.30.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Sep 2022 20:30:09 -0700 (PDT) Message-ID: <30112927-4d04-1388-0b44-69bb4c84239d@gmail.com> Date: Thu, 15 Sep 2022 21:30:08 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [committed] RISC-V: Make g imply zmmul extension. Content-Language: en-US To: Nelson Chu Cc: binutils@sourceware.org References: <20220916013903.45339-1-nelson@rivosinc.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/15/22 21:26, Nelson Chu wrote: > On Fri, Sep 16, 2022 at 10:34 AM Jeff Law via Binutils > wrote: >> >> On 9/15/22 19:39, Nelson Chu wrote: >>> bfd/ >>> * elfxx-riscv.c (riscv_implicit_subset): Moved entry of m after g, >>> so that g can imply zmmul. >>> gas/ >>> * testsuite/gas/riscv/attribute-01.d: Updated. >>> * testsuite/gas/riscv/attribute-02.d: Likewise. >>> * testsuite/gas/riscv/attribute-03.d: Likewise. >>> * testsuite/gas/riscv/attribute-04.d: Likewise. >>> * testsuite/gas/riscv/attribute-05.d: Likewise. >>> * testsuite/gas/riscv/attribute-10.d: Likewise. >>> * testsuite/gas/riscv/march-imply-g.d: Likewise. >>> * testsuite/gas/riscv/march-imply-unsupported.d: Likewise. >> Does this happen to fix this kind of failure that started showing up a >> week or two ago? >> >> /tmp/ccdAErP7.s:6522: Error: unrecognized opcode `mul a5,a4,a5', >> extension `m' or `zmmul' required > I get the same error message if I just assemble files with > -march=rv32/64g, or just use the default rv64g arch setting. I > remember gcc should always pass the expanded imafd for g to assembler, > so the errors won't happen. This error should only happen when we set > g for architecture string. Hope the patch can fix the problem you > mentioned, it seems like the same as what I meet. In that case I'll just fire up the riscv64 bootstrap-in-chroot job and check on it in the morning.  If it's still failing, then I'll start debugging again now that I'm out of the covid brain-fog. > >> I started chasing it down and concluded it likely wasn't the compiler, >> but couldn't take it further before covid knocked me out. I'm just >> starting to try and catch up on things today... >> > Glad to hear you recovered :) Not fully, but I feel a hell of a lot better today than I did yesterday! jeff