From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by sourceware.org (Postfix) with ESMTPS id 7EA2C3858D34 for ; Thu, 29 Feb 2024 21:39:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EA2C3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7EA2C3858D34 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.82 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709242773; cv=pass; b=g+YngG1nanqoV5H7/nkyLz9ty2SU2d4c4uVy7XtjAqj6qqqii4N5Rx0fW33+mL1F6sWIuG0+/vjUhjjNcU+h3qjX32bg83w24cy8wZ6Emo4mvnuzYGx10KCIm1Q0iNdIR4Xfkap4tFCQ/G+LNbkiyM1Vjc97ui5cW3Fkjg7mrqY= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709242773; c=relaxed/simple; bh=4AGmG0x5gbQMCp8IfGWMig1t6S3W8ihQ2MPiQiJIngY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=hzRAl6nz7943OfQoBoSboQ3PHG+cY6R0PAWqJuLpKD4EXX0Jo6Bt3aTPOJhuMktpk1W6hHYmXxCrMYlVaAkCpJhan0ocSnmCwx4ITbnIy0nrbS7eZ3nQu0zNNNBs9+IPzQC7gG0hPbO3QQmACaQWBAjvBVKLr9nD8bF4MjexpHQ= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DwQYOQAlmvG0babHpiuBISaWkoUYDazJ0eEn3Kwy3k0b3TjdhFqzZH9Pe7TC3RW6pY2W0G01h2gmqfJIY2X0xN0xoB5umm77iucQy+kTDcGb+RsFN5qCs8jztsd6c4uIqiwk4l8C+DSu5DqPzeI6zhVWiUlyycvZd+UXPyp/2T4ZZKpEC81+Qe+jij9B1jInJXzo1kqrktxCtcJZD4EJwLUmI6Xi3QYDv+Ckd1lMGUTcFGrkbEL26kPsRWoWe09/Tn3ThHsocT2OoL1PeMogXU7iTCnBQnLo8I3qeGpKCKX8C/S/uLurIwCQ5CRUwY/34usBNOfNMABcHXnjPnqKGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IKWQkMg/hl9/C5Jwqm/6fXwcWDuqCqzChg1h4d658C0=; b=OKz8cYJ3PyquHl1wcqJILH3GT4YLRe9ct/I58CvLPmxGQ5hOGIhf7M5drvzWUaIhxWARXlY6u3FVcScB0nybkCUfXMar1jf3c+CGaW+RaXAkYL/OVSZfb9vJh1K+Xz8ryFzysRavejgevUPAujlWqeMEloxhuQc4zxIbaTpyVdMwlY7+EDAjjaGGmLkwbN5xucfekKvyF9PBss4K/LC4XPptKFbWXlDJUSuQhb7uX8P2Vfaxqde5XL/Eur68kHcdKODFcv8k6Lf0HOgZD4CtoAAc7XXlAJZFgmXnQNqwuxaJo6GhS3cFl/FeeYAdheDkzkKMroCDB9T/+ZJU74ZtPA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IKWQkMg/hl9/C5Jwqm/6fXwcWDuqCqzChg1h4d658C0=; b=qy9hH+Y+T6BEleCSPqc7Qc7Htly0ngKqPzQioyUHyiReEBg7JCaM+AsHpFNX533MNrRjD0lINt0gHN0SM07NbcByjJFV18nOer9jP04/YTNnwLqd3PMkvQkNcUdIOl0hugigqWrkJ58IL2edhfDvWnGbaj988Sz0fLyb2sNY2Po= Received: from DUZPR01CA0065.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c2::8) by AS2PR08MB9048.eurprd08.prod.outlook.com (2603:10a6:20b:5fe::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Thu, 29 Feb 2024 21:39:28 +0000 Received: from DU2PEPF00028D13.eurprd03.prod.outlook.com (2603:10a6:10:3c2:cafe::22) by DUZPR01CA0065.outlook.office365.com (2603:10a6:10:3c2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.31 via Frontend Transport; Thu, 29 Feb 2024 21:39:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028D13.mail.protection.outlook.com (10.167.242.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Thu, 29 Feb 2024 21:39:27 +0000 Received: ("Tessian outbound 081d54b8cc4c:v228"); Thu, 29 Feb 2024 21:39:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8c0eec50475ea138 X-CR-MTA-TID: 64aa7808 Received: from 2e878fe8f3a4.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 33E7E84F-842F-42F4-B516-1284E32DC50F.1; Thu, 29 Feb 2024 21:39:21 +0000 Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2e878fe8f3a4.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Feb 2024 21:39:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dST7iHRSW1q8DlJUJsOls1hu+0LaqC8BPTmhPmn3+2WMqWY2w7En2fPjXAk2m4p3ORoSdd9YeyzQTfZSQlq1W30sLq33ngOo81iWx6EaE6KLfjHWa/jvMAEl1dpGYWE0ChM31XioGLlHNp7k06tAIY4J6ng6bdKzGHUJPPtxP15YZArvJHE+Cy9lfZSPq/BBK3hc57ATl/9QdCKCE/Cxj25WKROkf1KmBhtnNgJbIi/iXvs8b2bWvJLcrPvc8sJKcRd2GLML/0TWgj5qA7Ofn7jTRaCx+jG0nsjtqrG2G/pJun8UrJY9On8tmtWFjFEyGqIqO7DEc1x1vLLlIqL9jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IKWQkMg/hl9/C5Jwqm/6fXwcWDuqCqzChg1h4d658C0=; b=W4vCktIMjrU/jwdn/6DmiUtLtOzEfbKNF9NltZIwkE6INZUQE7rFAxdUEo2baKCYq3qOCk9CwFRgAaluARprpfY88fbVLiiognDVR0D4dylK/8FUYwNXjMUBu9JVjy2lKU2rbApn0ZCE05e6qwKplX9c4XL+AYRDDqVU4GpyymPGmF8mXFdXpH/krgzlDN/BvAQ/CqqmWX7bCEx9DRdewP1W1KQYurxuhDWvbj0rVzMjGvXxCKCLgesRPNr6YWbErje+JHOCj1HMilrgHlhFwwo4TuZbtAuk5j0m+Zk6nlmKOttUkzWuInMI4qDllP/UP/Sx4LDTQWz80rIa1FRB8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IKWQkMg/hl9/C5Jwqm/6fXwcWDuqCqzChg1h4d658C0=; b=qy9hH+Y+T6BEleCSPqc7Qc7Htly0ngKqPzQioyUHyiReEBg7JCaM+AsHpFNX533MNrRjD0lINt0gHN0SM07NbcByjJFV18nOer9jP04/YTNnwLqd3PMkvQkNcUdIOl0hugigqWrkJ58IL2edhfDvWnGbaj988Sz0fLyb2sNY2Po= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VE1PR08MB4893.eurprd08.prod.outlook.com (2603:10a6:802:aa::13) by VE1PR08MB5711.eurprd08.prod.outlook.com (2603:10a6:800:1ae::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32; Thu, 29 Feb 2024 21:39:17 +0000 Received: from VE1PR08MB4893.eurprd08.prod.outlook.com ([fe80::5c18:a286:6426:d418]) by VE1PR08MB4893.eurprd08.prod.outlook.com ([fe80::5c18:a286:6426:d418%4]) with mapi id 15.20.7316.039; Thu, 29 Feb 2024 21:39:16 +0000 Message-ID: <3061a86a-e94d-4e5f-bf3a-c8210da20781@arm.com> Date: Thu, 29 Feb 2024 21:39:12 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [Committed][PATCH v1 1/1][Binutils] aarch64: Fix the 2nd operand in gcsstr and gcssttr instructions. To: Jan Beulich , binutils@sourceware.org Cc: richard.earnshaw@arm.com, nickc@redhat.com, Marcus Shawcroft References: <20240213180311.2141095-1-srinath.parvathaneni@arm.com> Content-Language: en-US From: Srinath Parvathaneni In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0280.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::15) To VE1PR08MB4893.eurprd08.prod.outlook.com (2603:10a6:802:aa::13) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VE1PR08MB4893:EE_|VE1PR08MB5711:EE_|DU2PEPF00028D13:EE_|AS2PR08MB9048:EE_ X-MS-Office365-Filtering-Correlation-Id: 30ffc6fe-5ad4-4cc8-a83f-08dc396ee7c4 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: py5gqwWbSPjgqwXajuSf3wA10dmCGPDWjJbVmRYybqY6OLoSRVAfKJqzPZt2/kyWeVq11Pn/ttkLJNJV9JxYP5ufdZrqDv+GFNmgorF62Q0i6ITZsDO9DThtQi6MDz1BUXPlYuPkvYzqJWovvAOAeNjBX/NgpttBn3xpq/gYeJM34x+5L5hrtnE5ffbd1Raqnofgm6SrE/50XiLqwfyScKGKkG9LlwLMJtHIeQvHWwnyJEQcueF3CCROL08rer6OXVpSuWrxoKEthHbEWqWgdQc3bpgNHJtbDpd23DJOt8kYB48igPE4ELkCPFHDOH159cIYggJCS6XYd8K3zjq90voovJWSO7O5NUTJVdILeo9nXQ2TrD+FH73jmvm9HJ3q8cgt0l/X+ocRFsm+QszbVg/rMFox0Ea91OH4yO5FxrPp++8mmSlFo18v8caEsV14fIJp7R4L8zgQmmia+rF3A9CjuzebLE578Qj7ZBI4J79nnRhNxKorPTYhgzyexlQRtoAqLGq/1W+u5xrO7fFzWyxAm965FNSyXy8yzHp2nUe/gu07REhfxEJMF5UzYXReqFGsxI/mZ+RdzGRN5ctr87lEzD+C7mnsmPmd0t9ofbKsHud8zOJhv/iXii/TGfVp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB4893.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5711 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D13.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0967856b-9794-49b0-02d6-08dc396ee0ed X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uShUdQ1zop1mr2jpfnrRpUlj2yUwrMpfU0NHI94hO0TXQh/yEFnRZHE4jF+7yfdtSL5n6IKIRMv95bYE23Nn1mOJWRJfmjxSA7C4Q8Lk1ncr35ybix3ZumWC6LjkhsPP9U4sO1LZL8P0E9iAbvRX1lL+7lTdJL1zsEkj9Kk9z+vZ0Dd3ULYTEaf0qAlg3K3Be1C4F3g1qJo8qF44Pt2atVvDviLlbhv0Fx3uF6Sv7J8saPEUGg0x90Owe18W4EOx/y+/RX4Cmo6csUeEoSpTO9xMp6b/GDYVpOfQ+Yb3b0lhp5Iv78gBFV3AyG4Q1PvfC9GhlB0EcI1olLsk1cc/Tc/7tnXbvR0snvUU+EHzNcZfvjH733bnKxr4mwAAIi4hn0WV4d1AqnuyHVW56SXFfQrWgGqJcAgUjltiwruJmEp+UImGGvmRLkS+T7Vwdh/EiOePKLtng8P/zz59S5nDERGT2I59VOl5vgv2Q9Q0mukpJOPNtYK/G9aoX35oCkxnbuq2qCnQWbFwS+iPnMPWAbJIVM3FK6Pq07DlmubA1gLIJ1OyxpvhuHaYfGVYwlH4fCyIKf1sGVxUYDDK0fE81/Tkwp+FJ8qzdQOuDiEzb67nEwjVRl3fjNUijEhjEUOwLxUilrt2fTHJFRuz6bB/gLtDiaBwOrxu5n+S6dRU8Uf67Pfjh3HrzJCjTFPZ1VMGWyWfh2azRVjYk1eDlczHFp3GdT/RFaIggkLsV/xOR1jBiRHR+4jsoB+TRoPT9+BZ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 21:39:27.7222 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30ffc6fe-5ad4-4cc8-a83f-08dc396ee7c4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D13.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9048 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi On 2/14/2024 9:24 AM, Jan Beulich wrote: > On 13.02.2024 19:03, srinath wrote: >> The assembler wrongly expects plain register name instead of >> memory-form 2nd operand for gcsstr and gcssttr instructions. >> This patch fixes the issue. >> >> Regression testing for aarch64-none-elf target and found no regressions. >> >> Ok for binutils-master? Also ok to be backported to binutils-2.42 branch? > Looks good to me, but I'm not an Arm64 maintainer. I'd prefer if one of > the two (you didn't even Cc Marcus) would ack the patch, but in case you > don't hear back within a week, feel free to put in on both branches. > That said, ... I have committed the patch to both "master" and "binutils-2_42-branch". >> --- >> gas/testsuite/gas/aarch64/gcs-1-bad.l | 48 +++++++++++++-------------- > ... the need for you to alter the expectations here indicates that the > testcase itself likely was having too specific expectations. For the > intended purpose, the exact set of operands isn't of interest and hence > would likely better have been omitted in the first place. I'm aware > though that it's a common approach to simply not edit expectations from > obtained tool output any further than to add the necessary escaping. > Yet I'm trying to encourage people to put in a little more effort, in > an attempt to limit follow-on effort for themselves or others. > > The more thoroughly one zaps irrelevant parts from expectations, the > more likely it also is that one might spot actual issues - this isn't > the case here, i.e. I'm merely trying to provide some further > background, but I've seen it numerous times that expectations were > derived largely blindly from tool output, without checking that the > output is actually correct/sensible in the first place. (I'm afraid > I, too, have been guilty of that in a few cases.) > > Jan Thanks for the feedback, in my next set of patches (bug fixes to sve2p1) I shall explain the logic I'm using to write the tests (covering most of the encoding). Also, I'm comparing the outcome of the disassembler with other tools, to avoid these kind of errors. Regards, Srinath. >> gas/testsuite/gas/aarch64/gcs-1.d | 48 +++++++++++++-------------- >> gas/testsuite/gas/aarch64/gcs-1.s | 2 +- >> opcodes/aarch64-tbl.h | 4 +-- >> 4 files changed, 51 insertions(+), 51 deletions(-) >>