From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id A8B013858D20 for ; Mon, 30 Oct 2023 08:00:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8B013858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A8B013858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698652861; cv=none; b=UAUD8yKOKIQslPEcn9soiR/oj/yiy71mTlI9l7lPXjlhvSHIRKql8rQDq2zdI0qYVdpevw2WN5wDQxm/ZxRRvukwJbZmCNzevy1PM8lzr2Lkbjhor4iUudwUf/79g7+vErtVSySLzPLvvqGUxMZwURgxzOhuzeNgZrPKOrqvY2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698652861; c=relaxed/simple; bh=mGAThrQ5Hr+0curshShehOmc4y0OWIcAaZdXY4WWjRQ=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=RrQC33vzb+yYlg9rk8WVo2Q+fRbJ1hLNxvZzAN/ozCMkaUZVUZ6NKJfmVXWIVnel53gDIg+l7O1UTWBfMh01/7+nhNgeqlTc9aojtkVELCyldsuMmLHhs4klsAZwmzsFE+m/4cOEPjBAwVJTYDE72QDXg3vOqD25aY/1Ma/5e9I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8Dxl+i1Yj9lHbI1AA--.3485S3; Mon, 30 Oct 2023 16:00:53 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8BxrdylYj9lBd82AA--.52009S3; Mon, 30 Oct 2023 16:00:53 +0800 (CST) Subject: Re: [PATCH 4/5] LoongArch: Remove "elf_seg_map (info->output_bfd) == NULL" relaxation condition To: Xi Ruoyao , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, i.swmail@xen0n.name, maskray@google.com, cailulu@loongson.cn References: <20231013082445.290062-1-mengqinggang@loongson.cn> <20231013082445.290062-4-mengqinggang@loongson.cn> <23e214a61579094d9367f7b089f9e139378f4b5e.camel@xry111.site> From: mengqinggang Message-ID: <306c2568-29bf-83e8-7f6e-68bf578fa5b1@loongson.cn> Date: Mon, 30 Oct 2023 16:00:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8BxrdylYj9lBd82AA--.52009S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7KF4UKrykXrW5uFykXF15ZFc_yoW8ZFyDpr 9YkFyfJFWrZ3Z5Jw1UXw15WryDG348K3WUtF1YgFyxCws7Zr12gr4FgrWq9F4DGrWxAr1j vF18Ja17ZFn7AabCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv2b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GF ylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8j- e5UUUUU== X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There are still some other modifications that need to be addend, and prepare to test whether a clfs system can be successfully compiled. 在 2023/10/30 下午1:14, Xi Ruoyao 写道: > Ping. > > Is there any reason holding this patch? > > On Thu, 2023-10-19 at 22:04 +0800, Xi Ruoyao wrote: >> Hi, >> >> I don't know BFD very well, but IMO this should be applied and >> backported to 2.41 ASAP because "not relaxing shared objects" is a >> very >> serious issue. >> >> On Fri, 2023-10-13 at 16:24 +0800, mengqinggang wrote: >>> --- >>>  bfd/elfnn-loongarch.c | 6 +++++- >>>  1 file changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c >>> index 47334943fde..38a25b63813 100644 >>> --- a/bfd/elfnn-loongarch.c >>> +++ b/bfd/elfnn-loongarch.c >>> @@ -3747,6 +3747,11 @@ loongarch_relax_pcala_addi (bfd *abfd, >>> asection *sec, >>>    uint32_t pca = bfd_get (32, abfd, contents + rel_hi->r_offset); >>>    uint32_t add = bfd_get (32, abfd, contents + rel_lo->r_offset); >>>    uint32_t rd = pca & 0x1f; >>> + >>> +  /* Because previous sections' relax, output_offset may increase >>> and need to >>> +     be updated before relax. But it update after relax in >>> +     size_input_section defaultly, so we manually updating here. >>> */ >>> +  sec->output_offset = sec->output_section->size; >>>    bfd_vma pc = sec_addr (sec) + rel_hi->r_offset; >>>    const uint32_t addi_d = 0x02c00000; >>>    const uint32_t pcaddi = 0x18000000; >>> @@ -3889,7 +3894,6 @@ loongarch_elf_relax_section (bfd *abfd, >>> asection *sec, >>>        || sec->sec_flg0 >>>        || (sec->flags & SEC_RELOC) == 0 >>>        || sec->reloc_count == 0 >>> -      || elf_seg_map (info->output_bfd) == NULL >>>        || (info->disable_target_specific_optimizations >>>     && info->relax_pass == 0) >>>        /* The exp_seg_relro_adjust is enum phase_enum (0x4),