From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id A78ED3857C7A for ; Fri, 14 Jan 2022 08:12:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A78ED3857C7A Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-2-0jleezmoOPCINmbt4XUV3A-1; Fri, 14 Jan 2022 09:12:47 +0100 X-MC-Unique: 0jleezmoOPCINmbt4XUV3A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Is36JkrZK3wA2HBBoyE+10jO4YTTeBTcNASUJBstrZzApIx+/Gwnn7wbhy3L3JVedQN8FWnU+oGk021e9LQzbUagKjNPYmt8CEeEkjjVun6F45YhcIQkzunVHb2uNZFqy/E7ZEIVR8Qfz+l5X5FDSYO0OvDJFTPw9PdgwLXAHaIQ3dANtiv4kxHUjYB6wfFM29Kz9LA+nO5VrWwkDBzC7MlMgRlwgWIeEX2FBzqmjNGpLOdGAA0wMu9IUZd/RFDCg2j+CSefFsvAYQZ2tR/AYsCzOkJ5PNHdfW6vzMyNQiYjNeOzAlPX7pGEs4TngB2Y2eRKK+TpXOQnuHAQ/1ExZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q9Un9vEdFDBGcLn3snzxi3mAcxL+mP8WbNugSrUxbMo=; b=HmSHLcL42Pg/fTnXTowr05AK4o58XezCUVgL+sOf5SUYeVo7OinfLmNv9g+ENB6SLBbOOrNF4ZoUgtHd+avwvNPZCuaPV5/r8RIOsXaF7FzOpXiVe5jpGvvkDA7TiVf5oIYCH7d/KOUrxx2HFBWpTKxV16HWgzmUjYWPVGGTdP2t3UtucROz7iyNnUlbVgJLh4cPnnGOktk7CchIZMTUXqaUnFsPA27i2jtpWFQCsBfj6xUys65IsyI4t2TD7fA7Dsa4xFJTzbkd5kpL350gOs7ciVPNm901d4HLYCc3J5zcLzLB89ovorqFKWURaQtPSVVGkPU+rugfFsaIRjLPIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5741.eurprd04.prod.outlook.com (2603:10a6:803:df::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Fri, 14 Jan 2022 08:12:46 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4867.012; Fri, 14 Jan 2022 08:12:46 +0000 Message-ID: <31e68092-781a-7787-cf6f-2668e47e5e61@suse.com> Date: Fri, 14 Jan 2022 09:12:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3] elf: Set p_align to the minimum page size if possible Content-Language: en-US To: "H.J. Lu" References: <20211229193949.146079-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20211229193949.146079-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0047.eurprd05.prod.outlook.com (2603:10a6:20b:489::26) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf409806-b949-4ea5-e4cc-08d9d735a5b0 X-MS-TrafficTypeDiagnostic: VI1PR04MB5741:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: APo6CJlGkKph0qH8+cyIEvp03WsMDwS5zprfwrKMwNCqlukOeeu2wA3F9cCVSnKGq22LyHfnPtcGuDpV+ZqULLYKG+XgDwW3E9OhLWK2xkW+uIoubNkfaZ/33ssD0M4KMiV8ozHsYVVwwwuMPb0F9b+j8R7AaOGL9esSQ5TVVFjkh7O9adACb5VxwLZ4f6OW+knV/8S9S8KtIISn4N8yTh19+rNDP8nDViHD1LPNzGQ26Beghlk5FH24FUfmA/zO9hFBwCSq8ShK7GSD4HHl2Jz+Sw6rIElipbuydhRTrd7GNjov/opl136yUuCkPrGZ5iMiMBpQEyGfCKYiii2U13vlZAltQJ7ashkWyCyMVXRvh5l+eL5bsDQmrtxl5KTGeWGBLh8PPqMD3S82OrUaZP85sjWEYy5ngsRjHnOEbiRFTYbU9RFMmyPLHNGF4f1d/cU8eYJB10SeOHVu2q5nyyyOuBYIh2wk3CLC7+jsVxF7Sy1VCDtViagtYmnRJAzzi+9XTTXm7h/5D6BtbgmB6bdpXqx0/rRraFS6AvklJbH4+tdILKPkiMEbLyEu6pi+wRRyPK4Lu/7tkeOm+JULiaciPTM6xO5UmGnS2Ocrh/ewJkYAsa/VQuLX6eWy6ivECiX7c6pHyHBgq4dJLbIwdsbvBFeo2d2Rlp6Jj+MEwwMFYjq9GuHmCsYeVwMZO/XvrwA6wOyw4h6s5S3N9I4nlj80l2/D/qOVFDyAAEmTnXI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(53546011)(186003)(8936002)(26005)(83380400001)(36756003)(86362001)(6506007)(8676002)(38100700002)(316002)(2906002)(6916009)(6512007)(4326008)(31686004)(5660300002)(4744005)(31696002)(508600001)(6486002)(2616005)(66556008)(66476007)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N21GeCtSNldjQ2hZZWkwNVZ1b3Yrc3k1b21rRTJLa20yanBVUGpjcGkxdS9Z?= =?utf-8?B?N0E4MWhreWQ4RUhCUHJiSWEyMnI3RmFiTm5yRG5LL3RKSGZNL2RTNmxMbVBB?= =?utf-8?B?UDRoOTZ2SXptYU9wMVZ2UFlrS3RHV0h5WmVKRkRqVzZrYmsxNHNMS0VzQnJz?= =?utf-8?B?eHduRHJwWW1RanJvT3Z4SE1PN0x6eVpWWm0rRzNLU3dCL3lTdDY0OXpyY2xn?= =?utf-8?B?alI4NU9iYWNYaHNqTm45anczZjczc1NGUi9ONXhXNld4U0EyTkIwY2pWR3JT?= =?utf-8?B?RWY2QlJvZ3FNMUhoOGdHUC9qdU0rN21lMllMRmhBelhFcU52dDkxSGZRbEEx?= =?utf-8?B?aDJnazY1SFBVUzB3cURET2pqTnVocWEzajQwR0dLVFUrYXo1SmVXcXB5N01J?= =?utf-8?B?TnhZRjJOcCtpOUdIdk5VdnBLbWNDMTJXbXhnYzZDc2F4RFhLckJJTnZic1V3?= =?utf-8?B?Q0RicDRPVmJ3S3M0dHZLRnVNUTFqNlJlMDZDVWZtUldRb1cra1A2c05EZldK?= =?utf-8?B?R2FWNElmcjEra3UrZWd1OU0yWXRybEs2U2xEVk9XUlFRRlJaRWp1Mm9NbDA2?= =?utf-8?B?Q0tNSjR5MDYwZXM0NkI4ZWR0eTJtRkJUWTQzc2RPSDc4Y1JJdDh2aVRQVXpD?= =?utf-8?B?eUJCd1Z1bk5VSVUyZW5lQ3FiQXpFWEJwV2FCWFpOUkdOdUVmbi8zR1JZQlRL?= =?utf-8?B?R3VLekNibHUvdXpyZkpackdWMU8vUG1ReXdtT2pNNEZ4dEtnOTdsZ2UySmJt?= =?utf-8?B?WE93QytLTXZTQlRoUFRtYzF2TCtqVmhZMm4zZTFrYkpNdENOdUt3bzdhd09X?= =?utf-8?B?RDNxS3gzcFdGdEUvcFJnOGlLZzcwdVZnOWhkVE5RaEZabGFtaGI5bnE2Z3NW?= =?utf-8?B?enhieGxGM1lSZHh0S0tlcFdYdTdrb0ZNRTFjUFd4amxiNmNQUlh2QTA5VUVP?= =?utf-8?B?MnJVSmhwclltejN4WFFWY2gvTnpRWFRVQUhLUEFpUkNCK1FkejhPUDUrdVY1?= =?utf-8?B?ZVVUYy9iNlBUK2J3cjQzV3pnNEJudmdGVFBwbkZoV3hyT0tVYnVQcnNDQXAw?= =?utf-8?B?Sm5NVTBVVDdWd0tNRVg1NDI2NGh1ZFhQeExRU3craGlDc0dpRGUwU0FCVG1y?= =?utf-8?B?ZnJyKzB2WEVEMGJFRTBoVC8vSHFaMkFCVUdTbG1GdHAxWnhLTlFZa2lPVnlu?= =?utf-8?B?RGM5YjVReXI5cEE2Qm5SWjRVNzBXSU1raE56ejlQeDBVSHJERFVxTDhlSEZM?= =?utf-8?B?OVdwWHNiVHAyZlo0dzRlWmUxNlpIeWpMdjJiWTYwZFpxSWdJZXBZVk56KzBR?= =?utf-8?B?Mkl3aVVWYmViaHNoazdlaENMM0JHQ0o4UlN1dGZwTU1Hd05aYzdwY3RWeFEy?= =?utf-8?B?S2ZBd1BKelJML0hkT3ZuYlA0ZzFZbmRJTDFXV0pFS3ZZR3RZTmhpM3ZieVhw?= =?utf-8?B?cVYwbTBSTWxoeVNmb0lLYlp1TEppeVQ2eGQvUExRemVOUWNPQVFSdms1dTVu?= =?utf-8?B?Q0pIQmJJRU5ucTRFMkdHRzVMQWNDbnhTNEh4Y2NmaHdPTGJlYzJMNUc4amRx?= =?utf-8?B?MzBEejd1disxRTBQZDdQWGxPL1V2SmtJK3ovOVFMcWZUSWQxbVVEOTdIN0F5?= =?utf-8?B?UTVTcXZINTl2RmJRbmRJdm9tNjErS25NQ3JwK2kraExPVUNXRGQvMTAyOXoz?= =?utf-8?B?MzRKWWpiZnlBdFFHL3czR2JRZUFRNEpzaEdWTUZBK2pBOEtqcld4ZzVGNVlV?= =?utf-8?B?bjVSTW1tWG5FeDAvdk1pbkEzZTBwbkJBejNTVm55THhDNU1MelB4dWFJMWVh?= =?utf-8?B?aUpHRURJSlBIOHhkT1gyQitTUFR0eFBUMUlCSDhHYnljSFcwSWw4Sm9oMXRV?= =?utf-8?B?NW1WMlljWnRLMlVYSWZsdktCdWp5OHYrSkdzWTJ0SURmM0VnK2lqOG0wMFRK?= =?utf-8?B?ckhPcEN4UFpMVCtsdnZuTFc5RS9Nb2Y3VnliZFkrc3dSWXNnR2hRNHBST2lU?= =?utf-8?B?M0dPWDFjelRvb0NuTERibXJsR3R4OEY1MkFrRldUMUhpU3V1QXVGYTk5NFRq?= =?utf-8?B?NlZidzBONkprZ2lkdUJCMUJKUWExNkF3QlJRMStWRTdhNldCanI3cWtkVGdP?= =?utf-8?B?TEsxc1ArN3dpbXVOeExOMEtxYmRhZU04TmxBWWFUSFFqNGE3VU8rd21IYWxi?= =?utf-8?Q?016La7QxB3+8WlvbBc+o9qE=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf409806-b949-4ea5-e4cc-08d9d735a5b0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2022 08:12:46.5016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OPDR7s+s5Tmxidcfh1Zg/g+CwSebBiPls+HeZWJIkzoo/FCyXpVVAoSjORhcvzVCPR4p9FCVtLk/pirGCZ3OlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5741 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 08:12:54 -0000 On 29.12.2021 20:39, H.J. Lu via Binutils wrote: > --- /dev/null > +++ b/ld/testsuite/ld-elf/p_align-1.c > @@ -0,0 +1,25 @@ > +#include > +#include > +#include > + > +#ifndef ALIGN > +# define ALIGN 0x800000 > +#endif > + > +int > +__attribute__ ((weak)) > +is_aligned (void *p, int align) > +{ > + return (((uintptr_t) p) & (align - 1)) == 0; > +} > + > +int foo __attribute__ ((aligned (ALIGN))) = 1; Alongside newer distros I also continue to build and test binutils on an oldish one. gcc 4.3 looks to silently ignore[1] alignment values larger than 1Mb on at least 32-bit x86. Hence all 4 derived tests fail there. I think you want to verify that foo's alignment is actually 8Mb in the object file, or use an assembler source instead of a C one (albeit I can see that this would undermine your PIE / non-PIE test variants). Jan [1] It's actually worse than "ignore": The variable gets no alignment at all then, not even the expected 4-byte one.