From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2059.outbound.protection.outlook.com [40.107.15.59]) by sourceware.org (Postfix) with ESMTPS id 58D853856956 for ; Tue, 30 May 2023 08:09:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58D853856956 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HicS1fOcoVkabWkLRxUiXzhdFAstabvwxco5BqWscj+ja9DlaKPxJWU4boFhNqNUW8qe0u9MX4yctCwQpAV9wK+sCC8jCLcqNaYtFLpGMiMP1vwKrF3H0ohAmR85YPEW8BeEojRPzdthyhzV7K2i97BUlzy8HtPsfAszgLBhenu0rXDvwEPWVMxzPlaWb6pt2/BwzNiJOa8XWWW9XBrbQ8+Jfmicyc6AT+o9c3d681YpIcnHChWLnhIh4+UhBu2lUE2scwpZOOZb+woVQaPXZUMZeeYNyCkTmOn8C/JvXVpGbND65LRtIzQOrMrKwB6s+bytPBl1MlmZ2OFVIs+1+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HQafBk6FnkphXoJfE9x0924WyPKTbW++OhPHmJ5Es1c=; b=VYCUOBQjvd9jYEydkz90uoYWfD2yoZbOLlwDztWdNlQwFXq3yhEt9zIhWAMaMa6CyQsAXL23/Lfeojst5d9dKYWBCAhsxEBp0vxvs4Kl9hyMcZnuj9V5BiF3HVkPL0rv1hyT70rgaWeEUOm9zyuUGsVrxysYQnElAAwZWQBVL0uiaSZDyQdGubThY1T196RldstE8nxGf329RXJaGWyem/O1k7S6VK1dSI8J4yQX9v60y0vjbDYqdfcmkWJIaMDoExorkk4fM2BUUZWTQaQ/9Ia10C8vCifCifWWFUY1PdFZ6m/mewR0a6Hgyq7OFRyUz6ZO6JW4z46Z3O71X2wPGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HQafBk6FnkphXoJfE9x0924WyPKTbW++OhPHmJ5Es1c=; b=m2K2Koow+sTvgb0YET96KTPxlB42thez/y6FCgH99XGPbo2kQhgPRhTQzPditEIgFjCaDSVVwjxT34m92+k7OnBBqOZWpMY5sU+6b4II4MxAXCuKnfiUZj0j+FBJF0CgvAtbchIBrKcXpJC5sWUYcY5WT6doRs9L0bP6zalG/vqbtu8HPwCuM5EbJ0J/JkW1Yj3/s1gVOfqCTZuQF7ITa809eMJp1gZs0W2PlpZGGPKIG4ttVe0VaNqj/3yNlS/CynDrEhEmvkm72cQFfj7N32DA2VIPvQpGaKG9zN1K97H2p8qIvpbWG+ZfM4Eh9rO2TpEqp0la02btf2UWU58byw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7836.eurprd04.prod.outlook.com (2603:10a6:10:1f3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Tue, 30 May 2023 08:09:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6433.022; Tue, 30 May 2023 08:09:36 +0000 Message-ID: <31f33bf7-2809-2199-9877-167854324924@suse.com> Date: Tue, 30 May 2023 10:09:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] x86: Add Evw to emit w suffix for several instrctions for word ptr Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "Zhang, Jun" , "binutils@sourceware.org" References: <20230526082648.1503574-1-haochen.jiang@intel.com> <24df0b69-1a0e-22f2-c1ef-a986293d2231@suse.com> <37736f27-73d5-6564-e27e-5e7cd5bf27da@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBBPR04MB7836:EE_ X-MS-Office365-Filtering-Correlation-Id: eb92b084-e117-46fc-83b7-08db60e5351e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gy9csKKgaVsLsGlpS1qAEkMcp3Gsmby28nW+uzzX3w2tTieoStX3OkFP2F06GwFSWLCkO65TYne3n7g0/Q/hCKr28rXtbOSGQLOm88/dsneSYzXIhqKy/y7941/+yHKmhrvWwayTU3MPcQxBjZUJZzeNHVl7fBBhCGcqrR3BR8inW9eKAEeUGmba/SgH55TPjomrdmQFh/T36adia4nRs27nYrUEZmta8iHSUNOG2IUPIhlputsRbhIEi7iPxw8iU1lED8GSXGyybMAWlcoVw/ZPQh8Lx2SN59uSSEmCxqi6gsfCY3i+I/kD75Sh6hazf9xmqKNrfVVPElhVpZ48MSKtWrpGdaJNu+lqMzS6/xkTl4O7eiAkFam6mOTv4DBaduTHW1QSxKHTUSsJRbUrIc+7AYuLK46Wi5McLifMqPM1DK/HCWHcrEz/TqWSEbOtraiAMW802T50hQKkgNboCQo16zBJJJLpIfFor5AawIUbN+wW29p3P29gXP3dE+3YXdrRrMvCsOnoy6J0jBhOezaEndxG4PCONl2Tn5D4lU/MmfsXJbjdDc9SOCsYcPKjEpVopcbOHVNKsZ2MDvdMxQFS88K6BEr7hFU+99OYXVmKFtODkmxrGUzfFpZZ6oh0fUnOcq0QdAtFLqY0mEeTHw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(346002)(136003)(376002)(366004)(451199021)(186003)(2616005)(38100700002)(41300700001)(31686004)(6512007)(53546011)(6506007)(26005)(6486002)(478600001)(54906003)(4326008)(6916009)(66476007)(66946007)(66556008)(316002)(5660300002)(8936002)(8676002)(2906002)(86362001)(31696002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VldReHd6QUFkclNLeDF0a0JwOGQ4Z1NWWElNQkNmRFhUOW5aYUl2Ky9QVS9y?= =?utf-8?B?cW5PTTEvMmVObzlmQnZkNzg3VVVmUVdCZWlZU2E2RjRTODMxTUpSTnNwSnRP?= =?utf-8?B?dGQ5S3RaMUVZUUF2dlNZTnhFM3lQbVp3R0szRDIvY2pTSzdYUy9aUC9qQXNE?= =?utf-8?B?NDkzbGlvWHBjd2cyNjNLcTB4QVlDdEJnMlVZZVFIWHZVZmd6LzgzVTNHUTRn?= =?utf-8?B?WnE1RjRBeHgva0NsSng4blRqdmJraWVpb0R4Q0puK3hoVVhmQ2I0R0NrSERZ?= =?utf-8?B?di94SU9JbC84WXd1bWNZSG92S1V5WDk1aE5WYXUwTkU5OHpMMXlLdHloRGhY?= =?utf-8?B?UmtDeXBoV1dPM1dyaXpmUE1wZFZJN3dBRGhSOVprdzlQRFNDdGdrS1JwNjF6?= =?utf-8?B?UUJ2b1FjL2g5aVZHSEFNNGN4eDNPdjBNSVlud3JFQkNUc3liaFVUTlZ6MHky?= =?utf-8?B?N0RKckRNa1hEY3ZkbjdQaUNKMlVmVlZlVkJaS1VNTENwV3hKWWViQ1IvRVRn?= =?utf-8?B?NmJES1NpR1VRUVN3Z3B1a0JTRE11OUY3ZEhnOFNhRW1zQ3J5YW92anhhQUMv?= =?utf-8?B?WmdxNndSbWcvVkhaL2tpWEhIUHd5Tm9wVUwzNWJEZUllYjQxSFF3aXpBVjZp?= =?utf-8?B?SXNEWldmQ1p3TnRtUkdlZ2xNbVFraEVnYXJ0dnJlL01CVVY0b1VjU2tPUC80?= =?utf-8?B?WGxNeUUyVzNTMGVvaXpES2FKZEpKcUtBZGZHVmhWemRCQS9mb0Nqa291NzdW?= =?utf-8?B?V0tZaUVOVyt2WmVaQzdhRzVyL1FKWUZpSEVia2lLcDZtd0x5d2NBQlEzVkdI?= =?utf-8?B?cElpODUwWlRKVjkrbXQ5V3VlQklMa1EwaTRkUEtoVlJwa0FDTkhPMUlaM0dK?= =?utf-8?B?K0dSS0RRU3JxWnB2RkhuVmI4cmJQQ2hJSlR6QXZYUGtVVW5Bc1NVcHVNZlo4?= =?utf-8?B?VG43UWdkWjV2RE5nS3VZSXAwellGQVFWalpzRDkvTlkzM3g5Ly8wR3drY3A5?= =?utf-8?B?SGRhdy85ckx2Q1pQNlpWM1U3ZXdBQWZvS0k1NmE0anptUUtIM1pqc0grTjVk?= =?utf-8?B?a05sK1BGWXY5Q0J1UWVROUtrc3pFdWdBUG1iRGNHY3R3SERtUUw1K3ZjZS85?= =?utf-8?B?RlhjQmp1b080L1MwK3lERmJJekZ1b0lPL3lNeDJRd3VxcDFibkovNGNXd0k0?= =?utf-8?B?UHdOMDNqTUJrZUt1ckhmMkVlQy82QXRNK084VHozaWNnSWdWc2F1cFhWbURy?= =?utf-8?B?UGQrQmdPRDJOK0lNVzNVR2VjbkdxeWFHMFJjSXJzRExBeFFjRWRZbHBYdFdJ?= =?utf-8?B?dzVwbi9YT1ZJNUhNUGNKQmdFMGM0QmRYRTRIOEdnVGFzTFNPTjJpUUU5M2E4?= =?utf-8?B?Zmc0NVpUZ2VGMnhUM1c3azdGQzdJZEE0eHFmSUFhSWhxNkpPTzRsWENvaWhD?= =?utf-8?B?NDgvVzBzZ3hVaGhFOTF0N0ZOSmhaTWtHWXMvbHI4enFjT1JXL3lRNlpISGNE?= =?utf-8?B?aFlDbDM3OWhLNUR5VUlscUR3dlJFV2lNc2IxMGlEbUh1c3dqMGhJNzg3VktM?= =?utf-8?B?UUh6aTgwUnRub0VoSm41dGE0RmhHN0VrNXd4c0tscC9KL1FYL0VnZ0VJL3lU?= =?utf-8?B?a0cvNzY0SDJIWmZ2eUpibHZDM01sSXJ5K2RObGd0eTM0MHE0VWxUbEE1TmNz?= =?utf-8?B?UW05QzR4cVZwZDNMZE85Wm1GbktYZkd2bmtYVHI1NHQ5NG1vNzZVS290STVT?= =?utf-8?B?NW9vV2NpamdPTkF6SzVITzZFakYreFRvQkI0M0ZTdzJ4RDhmRGtMOTJSNWkv?= =?utf-8?B?QUFtdzd1QlBDOFh2T295ZkRnZ3QwUkViZmc4V3daTDZBTVNmSDRiWU0xYlVB?= =?utf-8?B?U0l5b2JCb0pwV1NaMCt3Z3dFVStlNzhZWTY5NEltRCtMcE5qTjRLNVoyYlJj?= =?utf-8?B?a25YNEVJMlg2SjdvWjc5UEhIWHNBamJvUy9pc3NNbGtZQzhLZUg1MmM2YUI0?= =?utf-8?B?d0hFTytzTmIwSTBrTE8yU3JGVS9kK0Z1ZmUvK1E2b0pxdndlT3VOemozdkZy?= =?utf-8?B?Q2NxaVg0UFJKZHpGbzRhZ1lvVGxpTXgxWWsrYUd0OHhoWmF0ZHloZjczZURq?= =?utf-8?Q?bMr/cQYLujTPW720UEw9Hw4uE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb92b084-e117-46fc-83b7-08db60e5351e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 08:09:36.0755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vuZMqVfkh6kyq+vTxpyIdkWcgBMyjUw25GMAkxNxCoYfN1WZDoSI3AHR0HFueE3X/Mwus/s3yBnA02tlx6e/Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7836 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.05.2023 04:08, Jiang, Haochen wrote: >>>>>> Currently, for instructions lldt/ltr/verr/verw/lkgs, we are >>>>>> missing w suffix for memory operands like sldt/str do. Also the Ew >>>>>> usage is not that precise under this scenario. Add Evw to fix this >> problem. >>>>> >>>>> So why not Sv? It's used solely for segment register moves, sldt, >>>>> str, and smsw right now. We're aiming for consistency among all >>>>> insns loading / storing segment selector values (and smsw fits that >>>>> pattern, but note that lmsw does not), so introducing a new Evw >>>>> can't be the solution (or else Sv users would also need switching). >>>> >>>> There is a little difference between lldt/ltr/lkgs/verr/verw and >>>> sldt/str. We need to fix the register to 16 bit while sldt/str did >>>> not. That is why I am not using Sv. Sv will emit 'lldt %eax' but not >>>> 'lldt %ax' for current testcases and I suppose that is not desired. >>> >>> Did you read my reply on one of the "Support Intel FRED LKGS" threads, >>> which I think I sent before this patch was sent? I do not follow why >>> you think "we need to fix the register to 16 bit". >> >> Maybe I got some wrong understanding on that. It comes from the current >> testcase. >> Trying to clarify that on disassembler. >> >> Let's take lldt as example. Will 0f00d2 emit eax register or ax register for lldt? > > One thing to add the current behavior for disassembler or trunk is to emit ax > register. Which I mean always is to as always with other instructions. I'm afraid I don't really get what you concern is. Yes, ... >> If we need a 66 in bytecode to emit ax register as always, Sv+D fits the need. >> And then the only thing we might need to do is to adjust the current testcase. ... some existing disassembly testcases will likely need adjusting. Jan