From: Tristan Gingold <gingold@adacore.com>
To: Catherine Moore <clm@codesourcery.com>
Cc: binutils@sourceware.org
Subject: Re: [RFA] Linker script extension SECTION_FLAGS
Date: Thu, 19 May 2011 07:44:00 -0000 [thread overview]
Message-ID: <3230CCD2-DE93-451F-ACB6-48AD77F3039E@adacore.com> (raw)
In-Reply-To: <4DD41EB0.6040300@codesourcery.com>
On May 18, 2011, at 9:32 PM, Catherine Moore wrote:
> 2011-05-18 Catherine Moore <clm@codesourcery.com>
> bfd/
> 2011-05-18 Catherine Moore <clm@codesourcery.com>
>
> * bfd-in2.h: Regenerated.
> * bfd.c (bfd_lookup_section_flags): New definition.
> * binary.c (binary_bfd_lookup_section_flags): New definition.
> * coff-rs6000.c (rs6000coff_vec): Include
> bfd_generic_lookup_section_flags.
> (pmac_xcoff_vec): Likewise.
> * coffcode.h (coff_bfd_lookup_section_flags): New definition.
> * elf-bfd.h (elf_backend_lookup_section_flags_hook): Declare.
> (bfd_elf_lookup_section_flags): Declare.
> * elflink.c (bfd_elf_lookup_section_flags): New function.
> * elfxx-target.h (bfd_elfNN_bfd_lookup_section_flags): Define.
> (elf_backend_lookup_section_flags_hook): Define.
> (elf_backend_data): Add elf_backend_lookup_section_flags_hook.
> * ieee.c (ieee_bfd_lookup_section_flags): New define.
> * ihex.c (ihex_bfd_lookup_section_flags): New define.
> * libbfd-in.h (_bfd_nolink_bfd_lookup_section_flags): Declare.
> (bfd_generic_lookup_section_flags): Declare.
> * libbfd.h: Regenerated.
> * mach-o-target.c (bfd_mach_o_bfd_lookup_section_flags): New.
> * mmo.c (mmo_fd_lookup_section_flags): New definition.
Typo in the code too: mmo_bfd_...
Also, I am not sure that you really need to have elf_backend_lookup_section_flags_hook.
In your patch, bfd_elf_lookup_section_flags is simply a wrapper.
Each ELF target can simply define its own XX_bfd_lookup_section_flags.
Finally, in the grammar of SECTION_FLAGS, I would replace the comma with a '&' to clarify
the fact this is a conjunction.
Thank you for working on that.
Tristan.
prev parent reply other threads:[~2011-05-19 7:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 19:32 Catherine Moore
2011-05-18 19:33 ` Catherine Moore
2011-05-19 0:07 ` Ian Lance Taylor
2011-05-24 22:57 ` Catherine Moore
2011-05-25 12:28 ` Tristan Gingold
2011-06-06 22:02 ` PING " Catherine Moore
2011-06-07 13:11 ` Nick Clifton
2011-06-22 21:32 ` Catherine Moore
2011-06-28 11:37 ` Nick Clifton
2011-06-28 11:56 ` Tristan Gingold
2011-06-28 12:22 ` Nick Clifton
2011-06-28 13:30 ` Ian Lance Taylor
2011-06-30 21:11 ` Catherine Moore
2011-07-11 13:55 ` Nick Clifton
2012-02-09 5:27 ` Alan Modra
2011-05-19 7:44 ` Tristan Gingold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3230CCD2-DE93-451F-ACB6-48AD77F3039E@adacore.com \
--to=gingold@adacore.com \
--cc=binutils@sourceware.org \
--cc=clm@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).