From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6963 invoked by alias); 19 May 2011 07:44:43 -0000 Received: (qmail 6953 invoked by uid 22791); 19 May 2011 07:44:42 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_50,TW_FX X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 07:44:27 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id ECAF3CB022E; Thu, 19 May 2011 09:44:25 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5ReT7kiv92mi; Thu, 19 May 2011 09:44:23 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id EBFF5CB01E5; Thu, 19 May 2011 09:44:22 +0200 (CEST) Subject: Re: [RFA] Linker script extension SECTION_FLAGS Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: <4DD41EB0.6040300@codesourcery.com> Date: Thu, 19 May 2011 07:44:00 -0000 Cc: binutils@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <3230CCD2-DE93-451F-ACB6-48AD77F3039E@adacore.com> References: <4DD41EB0.6040300@codesourcery.com> To: Catherine Moore X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00281.txt.bz2 On May 18, 2011, at 9:32 PM, Catherine Moore wrote: > 2011-05-18 Catherine Moore > bfd/ > 2011-05-18 Catherine Moore >=20 > * bfd-in2.h: Regenerated. > * bfd.c (bfd_lookup_section_flags): New definition. > * binary.c (binary_bfd_lookup_section_flags): New definition. > * coff-rs6000.c (rs6000coff_vec): Include > bfd_generic_lookup_section_flags. > (pmac_xcoff_vec): Likewise. > * coffcode.h (coff_bfd_lookup_section_flags): New definition. > * elf-bfd.h (elf_backend_lookup_section_flags_hook): Declare. > (bfd_elf_lookup_section_flags): Declare. > * elflink.c (bfd_elf_lookup_section_flags): New function. > * elfxx-target.h (bfd_elfNN_bfd_lookup_section_flags): Define. > (elf_backend_lookup_section_flags_hook): Define. > (elf_backend_data): Add elf_backend_lookup_section_flags_hook. > * ieee.c (ieee_bfd_lookup_section_flags): New define. > * ihex.c (ihex_bfd_lookup_section_flags): New define. > * libbfd-in.h (_bfd_nolink_bfd_lookup_section_flags): Declare. > (bfd_generic_lookup_section_flags): Declare. > * libbfd.h: Regenerated. > * mach-o-target.c (bfd_mach_o_bfd_lookup_section_flags): New. > * mmo.c (mmo_fd_lookup_section_flags): New definition. Typo in the code too: mmo_bfd_... Also, I am not sure that you really need to have elf_backend_lookup_section= _flags_hook. In your patch, bfd_elf_lookup_section_flags is simply a wrapper. Each ELF target can simply define its own XX_bfd_lookup_section_flags. Finally, in the grammar of SECTION_FLAGS, I would replace the comma with a = '&' to clarify the fact this is a conjunction. Thank you for working on that. Tristan.