public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>, binutils@sourceware.org
Subject: Re: [PATCH] ld: ensure build-id is placed near ELF headers
Date: Wed, 11 Sep 2024 15:11:50 +0100	[thread overview]
Message-ID: <327f0101-1e98-48ee-8739-cc00aecc1a72@redhat.com> (raw)
In-Reply-To: <87frq7r01h.fsf@redhat.com>

Hi Andrew,

> Here are the results using lld 17.0.6:

> In every case the NOTE segment is placed towards the start of the ELF,
> which is good. 

Phew!


> Basically suggesting that the bfd linker should place r/o data before
> the code.  My concern is that if this was made optional, especially if
> this wasn't the default in --rosegment mode, then this would leave some
> loss of functionality in place, which I'd really like to avoid if
> possible.

Understood.

>>> The patch below is an RFC rather than a full patch, I've not update the
>>> commit message to describe the changes to the alignment code yet, but I
>>> wanted to share this so we could discuss it.

Bash shell syntax issues aside I like the patch.

My testing has shown no problems with it and it does still allow --rosegment
to make a difference to the size of binaries when -z separate-code is used,
so I am willing to accept it.

I am however above to fly off to the GNU Tools Cauldron conference however,
so if you could submit a updated version with the syntax changes suggested
then I will review and apply it when I get back.

Cheers
   Nick


  parent reply	other threads:[~2024-09-11 14:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 14:21 Andrew Burgess
2024-08-19 11:01 ` Nick Clifton
2024-08-21 10:57   ` Andrew Burgess
2024-08-21 20:45     ` Fangrui Song
2024-09-19 15:51     ` Nick Clifton
2024-09-19 20:29       ` H.J. Lu
2024-09-02 10:26   ` Andrew Burgess
2024-09-10  9:01     ` Nick Clifton
2024-09-10 15:38       ` Andrew Burgess
2024-09-10 23:03         ` Hans-Peter Nilsson
2024-09-11 10:42           ` Nick Clifton
2024-09-11 11:39             ` Hans-Peter Nilsson
2024-09-11 14:11         ` Nick Clifton [this message]
2024-09-19 20:53   ` Sam James
2024-09-20  2:52     ` H.J. Lu
2024-09-20  3:45       ` H.J. Lu
2024-09-20 13:20       ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=327f0101-1e98-48ee-8739-cc00aecc1a72@redhat.com \
    --to=nickc@redhat.com \
    --cc=aburgess@redhat.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).